[ObsUx][Inventory] Add actions column with link to discover for inventory #199306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jennypavlova
added
release_note:skip
jennypavlova
force-pushed
the
199025-obsux-add-actions-column-with-link-to-discover-for-inventory
branch
from
9de36da to
2c40baa
Compare
|
/ci |
|
Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services) |
cauemarcondes
approved these changes
Nov 8, 2024
x-pack/plugins/observability_solution/inventory/public/components/entities_grid/index.tsx
Outdated
Show resolved
Hide resolved
botelastic
bot
added
the
ci:project-deploy-observability
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
…-discover-for-inventory
💚 Build Succeeded
Metrics [docs]Module Count
Async chunks
History
|
CAWilson94
pushed a commit
to CAWilson94/kibana
that referenced
this pull request
Nov 11, 2024
…tory (elastic#199306) Closes elastic#199025 ## Summary This PR adds an actions column with a link to discover for inventory. It is available in the inventory grid(s) in both the group view and the unified inventory view. The column header tooltip text will change when it's available: [issue](elastic#199500) added⚠️ If the discover link is not available I added a logic to hide the whole actions column as this is the only available option for now. Once we add more actions we should refactor that to just not add the action and to keep the column visible (which doesn't make sense atm) ## Testing - Enable the Inventory - Check with/without grouping both the action link and the button - combination of kuery / drop-down filter - without any filters - With just one kuery or drop-down filter - When the link is clicked from the table we should see a filter by identity field in the query in discover (like `service.name: 'test'`, `conteainer.id: 'test'`) https://github.com/user-attachments/assets/bb4a89f5-2b30-457f-bf13-7580ff162a7e https://github.com/user-attachments/assets/2894ef5c-6622-4488-ab84-c453f5b6e318 --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
cauemarcondes
pushed a commit
to cauemarcondes/kibana
that referenced
this pull request
Nov 12, 2024
…tory (elastic#199306) Closes elastic#199025 ## Summary This PR adds an actions column with a link to discover for inventory. It is available in the inventory grid(s) in both the group view and the unified inventory view. The column header tooltip text will change when it's available: [issue](elastic#199500) added⚠️ If the discover link is not available I added a logic to hide the whole actions column as this is the only available option for now. Once we add more actions we should refactor that to just not add the action and to keep the column visible (which doesn't make sense atm) ## Testing - Enable the Inventory - Check with/without grouping both the action link and the button - combination of kuery / drop-down filter - without any filters - With just one kuery or drop-down filter - When the link is clicked from the table we should see a filter by identity field in the query in discover (like `service.name: 'test'`, `conteainer.id: 'test'`) https://github.com/user-attachments/assets/bb4a89f5-2b30-457f-bf13-7580ff162a7e https://github.com/user-attachments/assets/2894ef5c-6622-4488-ab84-c453f5b6e318 --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> (cherry picked from commit fcc3b06)
cauemarcondes
added a commit
that referenced
this pull request
Nov 12, 2024
… inventory (#199306) (#199789) # Backport This will backport the following commits from `main` to `8.x`: - [[ObsUx][Inventory] Add actions column with link to discover for inventory (#199306)](#199306) <!--- Backport version: 8.9.8 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"jennypavlova","email":"dzheni.pavlova@elastic.co"},"sourceCommit":{"committedDate":"2024-11-08T18:18:07Z","message":"[ObsUx][Inventory] Add actions column with link to discover for inventory (#199306)\n\nCloses #199025 \r\n## Summary\r\n\r\nThis PR adds an actions column with a link to discover for inventory. It\r\nis available in the inventory grid(s) in both the group view and the\r\nunified inventory view.\r\n\r\nThe column header tooltip text will change when it's available:\r\n[issue](#199500) added\r\n\r\n⚠️ If the discover link is not available I added a logic to hide the\r\nwhole actions column as this is the only available option for now. Once\r\nwe add more actions we should refactor that to just not add the action\r\nand to keep the column visible (which doesn't make sense atm)\r\n\r\n## Testing\r\n- Enable the Inventory\r\n- Check with/without grouping both the action link and the button\r\n - combination of kuery / drop-down filter\r\n - without any filters\r\n - With just one kuery or drop-down filter \r\n- When the link is clicked from the table we should see a filter by\r\nidentity field in the query in discover (like `service.name: 'test'`,\r\n`conteainer.id: 'test'`)\r\n \r\n\r\n\r\nhttps://github.com/user-attachments/assets/bb4a89f5-2b30-457f-bf13-7580ff162a7e\r\n\r\n\r\n\r\nhttps://github.com/user-attachments/assets/2894ef5c-6622-4488-ab84-c453f5b6e318\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"fcc3b0654525d67d34cc5916b4b6f7351892f650","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","backport:skip","v9.0.0","ci:project-deploy-observability","Team:obs-ux-infra_services"],"number":199306,"url":"https://github.com/elastic/kibana/pull/199306","mergeCommit":{"message":"[ObsUx][Inventory] Add actions column with link to discover for inventory (#199306)\n\nCloses #199025 \r\n## Summary\r\n\r\nThis PR adds an actions column with a link to discover for inventory. It\r\nis available in the inventory grid(s) in both the group view and the\r\nunified inventory view.\r\n\r\nThe column header tooltip text will change when it's available:\r\n[issue](#199500) added\r\n\r\n⚠️ If the discover link is not available I added a logic to hide the\r\nwhole actions column as this is the only available option for now. Once\r\nwe add more actions we should refactor that to just not add the action\r\nand to keep the column visible (which doesn't make sense atm)\r\n\r\n## Testing\r\n- Enable the Inventory\r\n- Check with/without grouping both the action link and the button\r\n - combination of kuery / drop-down filter\r\n - without any filters\r\n - With just one kuery or drop-down filter \r\n- When the link is clicked from the table we should see a filter by\r\nidentity field in the query in discover (like `service.name: 'test'`,\r\n`conteainer.id: 'test'`)\r\n \r\n\r\n\r\nhttps://github.com/user-attachments/assets/bb4a89f5-2b30-457f-bf13-7580ff162a7e\r\n\r\n\r\n\r\nhttps://github.com/user-attachments/assets/2894ef5c-6622-4488-ab84-c453f5b6e318\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"fcc3b0654525d67d34cc5916b4b6f7351892f650"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","labelRegex":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/199306","number":199306,"mergeCommit":{"message":"[ObsUx][Inventory] Add actions column with link to discover for inventory (#199306)\n\nCloses #199025 \r\n## Summary\r\n\r\nThis PR adds an actions column with a link to discover for inventory. It\r\nis available in the inventory grid(s) in both the group view and the\r\nunified inventory view.\r\n\r\nThe column header tooltip text will change when it's available:\r\n[issue](#199500) added\r\n\r\n⚠️ If the discover link is not available I added a logic to hide the\r\nwhole actions column as this is the only available option for now. Once\r\nwe add more actions we should refactor that to just not add the action\r\nand to keep the column visible (which doesn't make sense atm)\r\n\r\n## Testing\r\n- Enable the Inventory\r\n- Check with/without grouping both the action link and the button\r\n - combination of kuery / drop-down filter\r\n - without any filters\r\n - With just one kuery or drop-down filter \r\n- When the link is clicked from the table we should see a filter by\r\nidentity field in the query in discover (like `service.name: 'test'`,\r\n`conteainer.id: 'test'`)\r\n \r\n\r\n\r\nhttps://github.com/user-attachments/assets/bb4a89f5-2b30-457f-bf13-7580ff162a7e\r\n\r\n\r\n\r\nhttps://github.com/user-attachments/assets/2894ef5c-6622-4488-ab84-c453f5b6e318\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"fcc3b0654525d67d34cc5916b4b6f7351892f650"}}]}] BACKPORT--> Co-authored-by: jennypavlova <dzheni.pavlova@elastic.co>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #199025
Summary
This PR adds an actions column with a link to discover for inventory. It is available in the inventory grid(s) in both the group view and the unified inventory view.
The column header tooltip text will change when it's available: issue added
Testing
service.name: 'test',conteainer.id: 'test')without_grouping.mov
with_grouping.mov