Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security Solution] Invalid kql query timeline refresh bug #105525

Merged
merged 4 commits into from
Jul 20, 2021
Merged

[Security Solution] Invalid kql query timeline refresh bug #105525

merged 4 commits into from
Jul 20, 2021

Conversation

dplumlee
Copy link
Contributor

Summary

Follow up to #99442

Fixes bug addressed here where invalid kql query was displaying incorrect values or causing the app to hang. Disables the datetime picker in this one instance to restrict users from sending an invalid query until it's been fixed.

Screenshots

Screen Shot 2021-07-13 at 4 41 05 PM

Checklist

Delete any items that are not applicable to this PR.

For maintainers

@dplumlee dplumlee added bug Fixes for quality problems that affect the customer experience v8.0.0 release_note:skip Skip the PR/issue when compiling release notes Team:Detections and Resp Security Detection Response Team Feature:Timeline Security Solution Timeline feature v7.15.0 7.14.0 labels Jul 13, 2021
@dplumlee dplumlee self-assigned this Jul 13, 2021
@dplumlee dplumlee requested a review from a team as a code owner July 13, 2021 22:49
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-detections-response (Team:Detections and Resp)

@dplumlee dplumlee added v7.14.0 and removed 7.14.0 labels Jul 14, 2021
@dplumlee
Copy link
Contributor Author

@elasticmachine merge upstream

@XavierM XavierM added the auto-backport Deprecated - use backport:version if exact versions are needed label Jul 20, 2021
XavierM
XavierM approved these changes Jul 20, 2021
View reviewed changes
Copy link
Contributor

@XavierM XavierM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that's so much better!!! Thanks for fixing it!

@XavierM
Copy link
Contributor

XavierM commented Jul 20, 2021

@elasticmachine merge upstream

@XavierM XavierM enabled auto-merge (squash) July 20, 2021 02:28
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 6.3MB 6.3MB +492.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @dplumlee

@XavierM XavierM merged commit a34a15e into elastic:master Jul 20, 2021
@kibanamachine kibanamachine mentioned this pull request Jul 20, 2021
Merged
kibanamachine added a commit to kibanamachine/kibana that referenced this pull request Jul 20, 2021
@dplumlee @kibanamachine
[Security Solution] Invalid kql query timeline refresh bug (elastic#1…
1754bce 
…05525)

* poc test

* adds disable for refresh button

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
@kibanamachine kibanamachine mentioned this pull request Jul 20, 2021
Merged
kibanamachine added a commit to kibanamachine/kibana that referenced this pull request Jul 20, 2021
@dplumlee @kibanamachine
[Security Solution] Invalid kql query timeline refresh bug (elastic#1…
ccbf04b 
…05525)

* poc test

* adds disable for refresh button

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
✅ 7.14
✅ 7.x

The backport PRs will be merged automatically after passing CI.

@dplumlee dplumlee deleted the invalid-kql-query-bug-pt-2 branch July 20, 2021 04:42
kibanamachine added a commit that referenced this pull request Jul 20, 2021
@kibanamachine @dplumlee
[Security Solution] Invalid kql query timeline refresh bug (#105525) (#…
0fd0639 
…106193)

* poc test

* adds disable for refresh button

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Davis Plumlee <56367316+dplumlee@users.noreply.github.com>
kibanamachine added a commit that referenced this pull request Jul 20, 2021
@kibanamachine @dplumlee
[Security Solution] Invalid kql query timeline refresh bug (#105525) (#…
33dba4d 
…106192)

* poc test

* adds disable for refresh button

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Davis Plumlee <56367316+dplumlee@users.noreply.github.com>
jloleysens added a commit to jloleysens/kibana that referenced this pull request Jul 20, 2021
@jloleysens
Merge branch 'master' of github.com:elastic/kibana into reporting/onl…
17cbcc0 
…y-show-migrate-to-authzd-users

* 'master' of github.com:elastic/kibana: (187 commits)
  Space management page UX improvements (elastic#100448)
  [Reporting] Unskip flaky test when downloading CSV with "no data" (elastic#105252)
  Update dependency @elastic/charts to v33 (master) (elastic#105633)
  [Observability RAC] Improve alerts table columns (elastic#105446)
  Introduce `preboot` lifecycle stage (elastic#103636)
  [Security Solution] Invalid kql query timeline refresh bug (elastic#105525)
  skip flaky suite (elastic#106121)
  [Security Solution][Endpoint] Fix UI inconsistency between isolation forms and remove display of Pending isolation statuses (elastic#106118)
  docs: APM RUM Source map API (elastic#105332)
  [CTI] Adds indicator match rule improvements (elastic#97310)
  [Security Solution] update text for Isolation action submissions (elastic#105956)
  EP Meta Telemetry Perf (elastic#104396)
  [Metrics UI] Drop partial buckets from ALL Metrics UI queries (elastic#104784)
  Remove beta admonitions for Fleet docs (elastic#106010)
  [Observability RAC] Remove indexing of rule evaluation documents (elastic#104970)
  Parameterize migration test for kibana version (elastic#105417)
  [Alerting] Allow rule to execute if the value is 0 and that mets the condition (elastic#105626)
  [ML] Fix Index data visualizer sometimes shows wrong doc count for saved searches (elastic#106007)
  [Security Solution] UX fixes for Policy page and Case Host Isolation comment (elastic#106027)
  [Security Solution]Memory protection configuration card for policies integration. (elastic#101365)
  ...

# Conflicts:
#	x-pack/plugins/reporting/public/management/report_listing.test.tsx
#	x-pack/plugins/reporting/public/management/report_listing.tsx
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@XavierM XavierM XavierM approved these changes

@andrew-goldstein andrew-goldstein Awaiting requested review from andrew-goldstein

Assignees

@dplumlee dplumlee

Labels
auto-backport Deprecated - use backport:version if exact versions are needed bug Fixes for quality problems that affect the customer experience Feature:Timeline Security Solution Timeline feature release_note:skip Skip the PR/issue when compiling release notes Team:Detections and Resp Security Detection Response Team v7.14.0 v7.15.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dplumlee @elasticmachine @XavierM @kibanamachine