-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Security Solution] UX fixes for Policy page and Case Host Isolation comment #106027
Merged
kevinlog
merged 4 commits into
elastic:master
from
kevinlog:task/policy-isolation-case-comment-ux-fixes
Jul 19, 2021
Merged
[Security Solution] UX fixes for Policy page and Case Host Isolation comment #106027
kevinlog
merged 4 commits into
elastic:master
from
kevinlog:task/policy-isolation-case-comment-ux-fixes
Jul 19, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinlog
added
v8.0.0
release_note:skip
Skip the PR/issue when compiling release notes
Team:Defend Workflows
“EDR Workflows” sub-team of Security Solution
v7.15.0
7.14.0
labels
Jul 16, 2021
Pinging @elastic/security-onboarding-and-lifecycle-mgt (Team:Onboarding and Lifecycle Mgt) |
academo
approved these changes
Jul 19, 2021
@elasticmachine merge upstream |
…com:kevinlog/kibana into task/policy-isolation-case-comment-ux-fixes
parkiino
approved these changes
Jul 19, 2021
kqualters-elastic
approved these changes
Jul 19, 2021
cnasikas
approved these changes
Jul 19, 2021
kevinlog
added
the
auto-backport
Deprecated - use backport:version if exact versions are needed
label
Jul 19, 2021
💛 Build succeeded, but was flaky
Test FailuresKibana Pipeline / general / Chrome UI Functional Tests.test/functional/apps/visualize/_metric_chart·ts.visualize app visualize ciGroup10 metric chart should show PercentilesStandard Out
Stack Trace
Metrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Jul 19, 2021
…comment (elastic#106027) * [Security Solution] UX fixes for Policy page and Case Host Isolation comment
💚 Backport successful
This backport PR will be merged automatically after passing CI. |
kevinlog
added a commit
to kevinlog/kibana
that referenced
this pull request
Jul 19, 2021
…comment (elastic#106027) * [Security Solution] UX fixes for Policy page and Case Host Isolation comment # Conflicts: # x-pack/plugins/cases/public/components/user_action_tree/index.test.tsx
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Jul 20, 2021
…y-show-migrate-to-authzd-users * 'master' of github.com:elastic/kibana: (187 commits) Space management page UX improvements (elastic#100448) [Reporting] Unskip flaky test when downloading CSV with "no data" (elastic#105252) Update dependency @elastic/charts to v33 (master) (elastic#105633) [Observability RAC] Improve alerts table columns (elastic#105446) Introduce `preboot` lifecycle stage (elastic#103636) [Security Solution] Invalid kql query timeline refresh bug (elastic#105525) skip flaky suite (elastic#106121) [Security Solution][Endpoint] Fix UI inconsistency between isolation forms and remove display of Pending isolation statuses (elastic#106118) docs: APM RUM Source map API (elastic#105332) [CTI] Adds indicator match rule improvements (elastic#97310) [Security Solution] update text for Isolation action submissions (elastic#105956) EP Meta Telemetry Perf (elastic#104396) [Metrics UI] Drop partial buckets from ALL Metrics UI queries (elastic#104784) Remove beta admonitions for Fleet docs (elastic#106010) [Observability RAC] Remove indexing of rule evaluation documents (elastic#104970) Parameterize migration test for kibana version (elastic#105417) [Alerting] Allow rule to execute if the value is 0 and that mets the condition (elastic#105626) [ML] Fix Index data visualizer sometimes shows wrong doc count for saved searches (elastic#106007) [Security Solution] UX fixes for Policy page and Case Host Isolation comment (elastic#106027) [Security Solution]Memory protection configuration card for policies integration. (elastic#101365) ... # Conflicts: # x-pack/plugins/reporting/public/management/report_listing.test.tsx # x-pack/plugins/reporting/public/management/report_listing.tsx
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
auto-backport
Deprecated - use backport:version if exact versions are needed
release_note:skip
Skip the PR/issue when compiling release notes
Team:Defend Workflows
“EDR Workflows” sub-team of Security Solution
v7.14.0
v7.15.0
v8.0.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR makes 2 changes to the UX.
Removes the background color of the Policy configuration page. This is closer to the mock and makes it look much better with the new sidebar.
Before:
After:
Makes the Isolation icon the smaller size in accordance with the mocks.