Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ML] Fix Index data visualizer sometimes shows wrong doc count for saved searches #106007

Merged
merged 6 commits into from
Jul 19, 2021
Merged

[ML] Fix Index data visualizer sometimes shows wrong doc count for saved searches #106007

merged 6 commits into from
Jul 19, 2021

Conversation

qn895
Copy link
Member

@qn895 qn895 commented Jul 16, 2021 •
edited
Loading

Summary

This PR fixes #105951 which is caused by a race condition where the index pattern is loaded first before saved search is registered.

Flaky test suite runner:

  • 1738 ... successful after 50 runs ✅
  • 1739 ... successful after 50 runs ✅
  • 1751 ... successful after 50 runs ✅ (failed at unrelated test)
  • 1752 ... successful after 50 runs ✅

@qn895 qn895 added bug Fixes for quality problems that affect the customer experience release_note:fix :ml v8.0.0 Feature:File and Index Data Viz ML file and index data visualizer v7.14.1 labels Jul 16, 2021
@qn895 qn895 self-assigned this Jul 16, 2021
pheyos
pheyos approved these changes Jul 19, 2021
View reviewed changes
Copy link
Member

@pheyos pheyos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and LGTM
With the re-enabled tests this also closes #105087 .

peteharverson
peteharverson approved these changes Jul 19, 2021
View reviewed changes
Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qn895
Copy link
Member Author

qn895 commented Jul 19, 2021

@elasticmachine merge upstream

@qn895 qn895 marked this pull request as ready for review July 19, 2021 14:54
@qn895 qn895 requested a review from a team as a code owner July 19, 2021 14:54
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

peteharverson
peteharverson approved these changes Jul 19, 2021
View reviewed changes
Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jgowdyelastic
jgowdyelastic approved these changes Jul 19, 2021
View reviewed changes
Copy link
Member

@jgowdyelastic jgowdyelastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM

@qn895 qn895 enabled auto-merge (squash) July 19, 2021 16:27
@qn895 qn895 added the auto-backport Deprecated - use backport:version if exact versions are needed label Jul 19, 2021
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
dataVisualizer 1.1MB 1.1MB +14.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @qn895

@qn895 qn895 merged commit 3b921ce into elastic:master Jul 19, 2021
@kibanamachine kibanamachine mentioned this pull request Jul 19, 2021
Merged
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
✅ 7.14

This backport PR will be merged automatically after passing CI.

kibanamachine added a commit to kibanamachine/kibana that referenced this pull request Jul 19, 2021
@qn895 @kibanamachine
[ML] Fix Index data visualizer sometimes shows wrong doc count for sa…
0a4a4dd 
…ved searches (elastic#106007)

* [ML] Fix flaky saved search

* [ML] Re-enable tests

* [ML] Make data viz the only tests for flaky test suite runner

* [ML] Make ML only

* [ML] Remove describe.only

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
@qn895 qn895 added the v7.15.0 label Jul 19, 2021
@qn895 qn895 mentioned this pull request Jul 19, 2021
Merged
qn895 added a commit to qn895/kibana that referenced this pull request Jul 19, 2021
@qn895 @kibanamachine
[ML] Fix Index data visualizer sometimes shows wrong doc count for sa…
0b06c3b 
…ved searches (elastic#106007)

* [ML] Fix flaky saved search

* [ML] Re-enable tests

* [ML] Make data viz the only tests for flaky test suite runner

* [ML] Make ML only

* [ML] Remove describe.only

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
kibanamachine added a commit that referenced this pull request Jul 19, 2021
@kibanamachine @qn895
[ML] Fix Index data visualizer sometimes shows wrong doc count for sa…
9221bad 
…ved searches (#106007) (#106132)

* [ML] Fix flaky saved search

* [ML] Re-enable tests

* [ML] Make data viz the only tests for flaky test suite runner

* [ML] Make ML only

* [ML] Remove describe.only

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Quynh Nguyen <43350163+qn895@users.noreply.github.com>
qn895 added a commit that referenced this pull request Jul 19, 2021
@qn895 @kibanamachine
[ML] Fix Index data visualizer sometimes shows wrong doc count for sa…
1212e0f 
…ved searches (#106007) (#106136)

* [ML] Fix flaky saved search

* [ML] Re-enable tests

* [ML] Make data viz the only tests for flaky test suite runner

* [ML] Make ML only

* [ML] Remove describe.only

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
@peteharverson peteharverson added v7.14.0 and removed v7.14.1 auto-backport Deprecated - use backport:version if exact versions are needed labels Jul 20, 2021
@pheyos pheyos mentioned this pull request Jul 20, 2021
Closed
jloleysens added a commit to jloleysens/kibana that referenced this pull request Jul 20, 2021
@jloleysens
Merge branch 'master' of github.com:elastic/kibana into reporting/onl…
17cbcc0 
…y-show-migrate-to-authzd-users

* 'master' of github.com:elastic/kibana: (187 commits)
  Space management page UX improvements (elastic#100448)
  [Reporting] Unskip flaky test when downloading CSV with "no data" (elastic#105252)
  Update dependency @elastic/charts to v33 (master) (elastic#105633)
  [Observability RAC] Improve alerts table columns (elastic#105446)
  Introduce `preboot` lifecycle stage (elastic#103636)
  [Security Solution] Invalid kql query timeline refresh bug (elastic#105525)
  skip flaky suite (elastic#106121)
  [Security Solution][Endpoint] Fix UI inconsistency between isolation forms and remove display of Pending isolation statuses (elastic#106118)
  docs: APM RUM Source map API (elastic#105332)
  [CTI] Adds indicator match rule improvements (elastic#97310)
  [Security Solution] update text for Isolation action submissions (elastic#105956)
  EP Meta Telemetry Perf (elastic#104396)
  [Metrics UI] Drop partial buckets from ALL Metrics UI queries (elastic#104784)
  Remove beta admonitions for Fleet docs (elastic#106010)
  [Observability RAC] Remove indexing of rule evaluation documents (elastic#104970)
  Parameterize migration test for kibana version (elastic#105417)
  [Alerting] Allow rule to execute if the value is 0 and that mets the condition (elastic#105626)
  [ML] Fix Index data visualizer sometimes shows wrong doc count for saved searches (elastic#106007)
  [Security Solution] UX fixes for Policy page and Case Host Isolation comment (elastic#106027)
  [Security Solution]Memory protection configuration card for policies integration. (elastic#101365)
  ...

# Conflicts:
#	x-pack/plugins/reporting/public/management/report_listing.test.tsx
#	x-pack/plugins/reporting/public/management/report_listing.tsx
@qn895 qn895 deleted the ml-fix-dv-saved-search-flaky branch July 21, 2021 19:49
@pheyos pheyos mentioned this pull request Aug 9, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jgowdyelastic jgowdyelastic jgowdyelastic approved these changes

@peteharverson peteharverson peteharverson approved these changes

@pheyos pheyos pheyos approved these changes

Assignees

@qn895 qn895

Labels
bug Fixes for quality problems that affect the customer experience Feature:File and Index Data Viz ML file and index data visualizer :ml release_note:fix v7.14.0 v7.15.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[ML] Index data visualizer sometimes shows wrong doc count for saved searches
6 participants
@qn895 @elasticmachine @kibanamachine @pheyos @peteharverson @jgowdyelastic