[XY] `showTooltip` argument. #130530

Kuznietsov · 2022-04-19T07:47:16Z

Summary

Completes part of #127115
Added showTooltip to the dataLayer and extendedDataLayer expressions.

Screenshots

Testing notes

kibana
| selectFilter
| demodata
| head 10
| pointseries x="time" y="mean(price)"
| xyVis seriesType="line" showTooltip=false
| render

…to chart_expressions-xy

# Conflicts: # src/plugins/chart_expressions/expression_xy/common/expression_functions/legend_config.ts # x-pack/plugins/lens/public/xy_visualization/visualization.tsx

…to chart_expressions-xy

# Conflicts: # x-pack/plugins/translations/translations/fr-FR.json # x-pack/plugins/translations/translations/ja-JP.json

…sions-xy-show-tooltip # Conflicts: # src/plugins/chart_expressions/expression_xy/common/expression_functions/layered_xy_vis.ts # src/plugins/chart_expressions/expression_xy/common/expression_functions/xy_vis.ts

…sions-xy-show-tooltip

# Conflicts: # packages/kbn-optimizer/limits.yml # src/plugins/chart_expressions/expression_xy/common/__mocks__/index.ts # src/plugins/chart_expressions/expression_xy/common/constants.ts # src/plugins/chart_expressions/expression_xy/common/expression_functions/annotation_layer.ts # src/plugins/chart_expressions/expression_xy/common/expression_functions/common_data_layer_args.ts # src/plugins/chart_expressions/expression_xy/common/expression_functions/common_xy_args.ts # src/plugins/chart_expressions/expression_xy/common/expression_functions/data_layer.test.ts # src/plugins/chart_expressions/expression_xy/common/expression_functions/extended_annotation_layer.ts # src/plugins/chart_expressions/expression_xy/common/expression_functions/extended_data_layer.ts # src/plugins/chart_expressions/expression_xy/common/expression_functions/index.ts # src/plugins/chart_expressions/expression_xy/common/expression_functions/layered_xy_vis.ts # src/plugins/chart_expressions/expression_xy/common/expression_functions/legend_config.ts # src/plugins/chart_expressions/expression_xy/common/expression_functions/reference_line_layer.ts # src/plugins/chart_expressions/expression_xy/common/expression_functions/xy_vis.test.ts # src/plugins/chart_expressions/expression_xy/common/expression_functions/xy_vis.ts # src/plugins/chart_expressions/expression_xy/common/expression_functions/xy_vis_fn.ts # src/plugins/chart_expressions/expression_xy/common/helpers/index.ts # src/plugins/chart_expressions/expression_xy/common/helpers/layers.test.ts # src/plugins/chart_expressions/expression_xy/common/helpers/layers.ts # src/plugins/chart_expressions/expression_xy/common/i18n/index.tsx # src/plugins/chart_expressions/expression_xy/common/index.ts # src/plugins/chart_expressions/expression_xy/common/types/expression_functions.ts # src/plugins/chart_expressions/expression_xy/common/types/expression_renderers.ts # src/plugins/chart_expressions/expression_xy/common/utils/log_datatables.ts # src/plugins/chart_expressions/expression_xy/public/__mocks__/index.tsx # src/plugins/chart_expressions/expression_xy/public/components/__snapshots__/xy_chart.test.tsx.snap # src/plugins/chart_expressions/expression_xy/public/components/annotations.tsx # src/plugins/chart_expressions/expression_xy/public/components/data_layers.tsx # src/plugins/chart_expressions/expression_xy/public/components/legend_action.test.tsx # src/plugins/chart_expressions/expression_xy/public/components/legend_action.tsx # src/plugins/chart_expressions/expression_xy/public/components/reference_lines.test.tsx # src/plugins/chart_expressions/expression_xy/public/components/reference_lines.tsx # src/plugins/chart_expressions/expression_xy/public/components/x_domain.tsx # src/plugins/chart_expressions/expression_xy/public/components/xy_chart.test.tsx # src/plugins/chart_expressions/expression_xy/public/components/xy_chart.tsx # src/plugins/chart_expressions/expression_xy/public/helpers/axes_configuration.ts # src/plugins/chart_expressions/expression_xy/public/helpers/color_assignment.ts # src/plugins/chart_expressions/expression_xy/public/helpers/data_layers.tsx # src/plugins/chart_expressions/expression_xy/public/helpers/index.ts # src/plugins/chart_expressions/expression_xy/public/helpers/interval.ts # src/plugins/chart_expressions/expression_xy/public/helpers/layers.ts # src/plugins/chart_expressions/expression_xy/public/helpers/state.ts # src/plugins/chart_expressions/expression_xy/public/helpers/visualization.ts # src/plugins/chart_expressions/expression_xy/public/plugin.ts # src/plugins/chart_expressions/expression_xy/server/plugin.ts # src/plugins/event_annotation/common/index.ts # src/plugins/event_annotation/common/manual_event_annotation/index.ts # src/plugins/event_annotation/common/types.ts # src/plugins/expressions/common/execution/execution.test.ts # src/plugins/expressions/common/execution/execution.ts # x-pack/plugins/lens/public/editor_frame_service/editor_frame/expression_helpers.ts # x-pack/plugins/lens/public/editor_frame_service/editor_frame/suggestion_panel.tsx # x-pack/plugins/lens/public/shared_components/legend_settings_popover.tsx # x-pack/plugins/lens/public/xy_visualization/__snapshots__/to_expression.test.ts.snap # x-pack/plugins/lens/public/xy_visualization/to_expression.ts # x-pack/plugins/lens/public/xy_visualization/types.ts # x-pack/plugins/lens/public/xy_visualization/visualization.tsx # x-pack/plugins/lens/public/xy_visualization/xy_config_panel/annotations_config_panel/annotations_panel.tsx # x-pack/plugins/lens/public/xy_visualization/xy_config_panel/color_picker.tsx # x-pack/plugins/lens/public/xy_visualization/xy_config_panel/reference_line_config_panel/reference_line_panel.tsx # x-pack/plugins/lens/public/xy_visualization/xy_config_panel/shared/icon_select.tsx # x-pack/plugins/lens/public/xy_visualization/xy_config_panel/shared/marker_decoration_settings.tsx # x-pack/plugins/lens/server/embeddable/make_lens_embeddable_factory.ts # x-pack/plugins/lens/server/migrations/common_migrations.ts # x-pack/plugins/lens/server/migrations/saved_object_migrations.test.ts # x-pack/plugins/lens/server/migrations/saved_object_migrations.ts

elasticmachine · 2022-05-26T08:58:28Z

Pinging @elastic/kibana-vis-editors @elastic/kibana-vis-editors-external (Team:VisEditors)

VladLasitsa

LGTM!

Kuznietsov · 2022-05-27T09:13:46Z

@elastic/kibana-vis-editors, could you, please, review this PR.

Kuznietsov · 2022-05-30T04:35:34Z

@elasticmachine merge upstream

kibana-ci · 2022-05-30T05:37:08Z

💚 Build Succeeded

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id	before	after	diff
`expressionXY`	135	136	+1
`lens`	499	500	+1
total			+2

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`expressionXY`	86.6KB	86.7KB	+67.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`expressionXY`	32.5KB	32.7KB	+184.0B

Unknown metric groups

API count

id	before	after	diff
`expressionXY`	145	146	+1
`lens`	576	577	+1
total			+2

History

💚 Build #47773 succeeded 273d280
💚 Build #39772 succeeded 8ddc6c4
💔 Build #38937 failed 4d5eea1

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @Kunzetsov

flash1293

Tested and works as expected, LGTM

Kuznietsov and others added 30 commits March 8, 2022 16:08

added xy plugin.

9388bba

Merge branch 'main' into chart_expressions-xy

8df9659

Added expressionXY limits.

ab72728

Merge branch 'chart_expressions-xy' of github.com:Kunzetsov/kibana in…

5747322

…to chart_expressions-xy

Added xy expression functions to the expression_xy plugin.

b4ee9c1

Moved xy to a separate plugin.

400845d

Small refactoring.

b2090f3

Fixed types.

33a06fa

Merge branch 'main' into chart_expressions-xy

d94fa4f

# Conflicts: # src/plugins/chart_expressions/expression_xy/common/expression_functions/legend_config.ts # x-pack/plugins/lens/public/xy_visualization/visualization.tsx

Fixed import of scss.

663e093

Fixed imports.

cbffe77

Added required plugins.

389f933

Fixed import

90aa97a

Fixed types.

1d3a264

Changed expression names.

a78d45d

Fixed bugs, caused by the refactoring process.

35cab91

Merge branch 'main' into chart_expressions-xy

847b3c4

Fixed lens snapshots.

ed7f8ea

Removed new line.

b6daa5d

Merge branch 'chart_expressions-xy' of github.com:Kunzetsov/kibana in…

bda6524

…to chart_expressions-xy

Fixed xy_chart tests.

c8d40fe

Added lazy loading for xy chart.

5fed60c

Fixed xy chart test.

dc195b2

Fixed broken chart selectors.

d39681f

Fixed dashboard tests.

b901d68

dashboard test fixed.

d327dfe

Fixed heatmap vis.

b500961

Smokescreen test fixed.

7a25b74

more fixes.

0004794

async dashboard tests fixed.

fc8c0b3

Kuznietsov added 10 commits April 19, 2022 20:20

fixed types.

822bf73

Turned back layerIds.

acc63a9

Removed convertActiveData from Lens.

40ba7c0

Merge branch 'main' into chart_expressions-xy-extended_layers

cb25e61

# Conflicts: # x-pack/plugins/translations/translations/fr-FR.json # x-pack/plugins/translations/translations/ja-JP.json

Added test to the layerIds generator.

7cd49d0

Merge branch 'chart_expressions-xy-extended_layers' into chart_expres…

99e2a35

…sions-xy-show-tooltip # Conflicts: # src/plugins/chart_expressions/expression_xy/common/expression_functions/layered_xy_vis.ts # src/plugins/chart_expressions/expression_xy/common/expression_functions/xy_vis.ts

Merge branch 'main' into chart_expressions-xy-extended_layers

6cd5376

Fixed types.

128643d

Merge branch 'chart_expressions-xy-extended_layers' into chart_expres…

8fb27bf

…sions-xy-show-tooltip

Updated snapshots.

8ddc6c4

Kuznietsov added WIP Work in progress accessibility: design system Accessibility issues that can be updated with EUI and removed accessibility: design system Accessibility issues that can be updated with EUI labels May 6, 2022

Kuznietsov added 4 commits May 26, 2022 11:32

Reverted legacy parts of code.

87e69d3

Fixed snapshot.

c17cf37

Fixed types.

273d280

Kuznietsov removed the WIP Work in progress label May 26, 2022

Kuznietsov marked this pull request as ready for review May 26, 2022 08:58

Kuznietsov requested a review from a team as a code owner May 26, 2022 08:58

VladLasitsa approved these changes May 26, 2022

View reviewed changes

Merge branch 'main' into chart_expressions-xy-show-tooltip

27029b8

flash1293 approved these changes May 30, 2022

View reviewed changes

Kuznietsov merged commit 5bab21e into elastic:main May 30, 2022

kibanamachine mentioned this pull request Jun 15, 2022

[Lens] Fix axis title visibility bug #134082

Merged

9 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[XY] `showTooltip` argument. #130530

[XY] `showTooltip` argument. #130530

Kuznietsov commented Apr 19, 2022 •

edited

Loading

elasticmachine commented May 26, 2022

VladLasitsa left a comment

Kuznietsov commented May 27, 2022

Kuznietsov commented May 30, 2022

kibana-ci commented May 30, 2022

API count

flash1293 left a comment

[XY] showTooltip argument. #130530

[XY] showTooltip argument. #130530

Conversation

Kuznietsov commented Apr 19, 2022 • edited Loading

Summary

Screenshots

Testing notes

elasticmachine commented May 26, 2022

VladLasitsa left a comment

Choose a reason for hiding this comment

Kuznietsov commented May 27, 2022

Kuznietsov commented May 30, 2022

kibana-ci commented May 30, 2022

💚 Build Succeeded

Metrics [docs]

Public APIs missing comments

Async chunks

Page load bundle

API count

History

flash1293 left a comment

Choose a reason for hiding this comment

[XY] `showTooltip` argument. #130530

[XY] `showTooltip` argument. #130530

Kuznietsov commented Apr 19, 2022 •

edited

Loading