Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SIEM] Adds 'Configure connector' Cypress test #64807

Merged
merged 4 commits into from
May 5, 2020

Conversation

MadameSheema
Copy link
Member

Summary

In this PR we are adding a new test in order to check that a connector can be configured for a case.

cases_connectors spec ts

In order to test it:

  • We go to all cases
  • We go to edit external connection
  • We add a ServiceNow connector
  • We check that the API call done is correct
  • We check that the toaster displayed is correct
  • We select the created connector
  • We save the changes
  • We check that the API call done is correct
  • We check that the toaster displayed is correct

@MadameSheema MadameSheema added Team:SIEM v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.8.0 labels Apr 29, 2020
@MadameSheema MadameSheema requested review from a team as code owners April 29, 2020 17:17
@MadameSheema MadameSheema self-assigned this Apr 29, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/siem (Team:SIEM)

@MadameSheema
Copy link
Member Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@cnasikas
Copy link
Member

cnasikas commented May 5, 2020

LGTM! I really liked how clean is your code and the structure of it 🚀 🎸

Copy link
Member

@cnasikas cnasikas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Forgot to approve :)

@MadameSheema MadameSheema merged commit 5c2fb4c into elastic:master May 5, 2020
@MadameSheema MadameSheema deleted the configure-connector branch May 5, 2020 11:45
MadameSheema added a commit to MadameSheema/kibana that referenced this pull request May 5, 2020
* adds 'Configures a new connector' test

* refactor code

* updates configure_cases screen selectors

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
@tylersmalley
Copy link
Contributor

tylersmalley commented May 5, 2020

I need to revert this PR for now as it's resulting in instability in master on feature freeze day. An automated issue has been created here: #65278

tylersmalley added a commit that referenced this pull request May 5, 2020
tylersmalley pushed a commit that referenced this pull request May 5, 2020
gmmorris added a commit to gmmorris/kibana that referenced this pull request May 5, 2020
* master: (133 commits)
  Cleanup Typescript index pattern field editor / Expression functions for bucket agg (elastic#65254)
  Removes legacy infra plugin and moves saved objects registration to NP (elastic#64848)
  Added support for docLinks plugin in Connectors forms and missing save capabilities for modal dialog (elastic#64986)
  [SIEM] Removes prebuilt rules number dependency (elastic#65128)
  [Maps] add categorical palettes with 20 and 30 categories (elastic#64701)
  [CI] Slack alerts - Elasticsearch snapshot failures (elastic#64724)
  [Uptime] Console errors in case index missing (elastic#65115)
  [SIEM][CASE] Dynamic fields mapping based on connector (elastic#64412)
  [test/functional] Tsfy page objects (elastic#64887)
  [Maps] [Telemetry] Track geo_point and geo_shape index patterns separately (elastic#65195)
  [Maps] Add global fit to data (elastic#64702)
  Visualize: Reload on ui state change and fix ui state for tsvb (elastic#63699)
  [SIEM] [Cases] External service selection per case (elastic#64775)
  [Uptime] Set ML anomaly look-back to 2w (from 24h) / Add spinner (elastic#65055)
  [Metrics UI] Remove APM Hard Dependency (elastic#64952)
  [Ingest] Datastream list: add icons and dashboard links (elastic#65048)
  disable plugins. they could access ES via SO repository (elastic#65242)
  Feature fleet enrollment instructions (elastic#65176)
  [SIEM] Adds 'Configure connector' Cypress test (elastic#64807)
  [TSVB] Fix std deviation band mode (elastic#64413)
  ...
@MadameSheema MadameSheema restored the configure-connector branch May 6, 2020 14:10
@MindyRS MindyRS added the Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. label Sep 23, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release_note:skip Skip the PR/issue when compiling release notes reverted Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:SIEM v7.8.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants