[Metrics UI] Remove APM Hard Dependency #64952
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simianhacker
added
release_note:fix
Feature:Metrics UI
|
Pinging @elastic/logs-metrics-ui (Team:logs-metrics-ui) |
|
@elasticmachine merge upstream |
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
jasonrhodes
approved these changes
May 5, 2020
There was a problem hiding this comment.
LGTM -- @simianhacker remind me what we're doing instead of this now?
|
@jasonrhodes This work was originally for the APM section we tried to add to the node detail page. When we added the API endpoints or the APM section, we decided to hold off because they way we had to expose the methods was reliant on the old platform. |
simianhacker
added a commit
to simianhacker/kibana
that referenced
this pull request
May 5, 2020
* [Metrics UI] Remove APM Hard Dependency * removing unused variable Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
simianhacker
added a commit
to simianhacker/kibana
that referenced
this pull request
May 5, 2020
* [Metrics UI] Remove APM Hard Dependency * removing unused variable Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
|
@simianhacker right I remember why we added these — so we are using the exposed contract in NP instead 👍 |
simianhacker
added a commit
that referenced
this pull request
May 5, 2020
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
May 5, 2020
* master: (133 commits) Cleanup Typescript index pattern field editor / Expression functions for bucket agg (elastic#65254) Removes legacy infra plugin and moves saved objects registration to NP (elastic#64848) Added support for docLinks plugin in Connectors forms and missing save capabilities for modal dialog (elastic#64986) [SIEM] Removes prebuilt rules number dependency (elastic#65128) [Maps] add categorical palettes with 20 and 30 categories (elastic#64701) [CI] Slack alerts - Elasticsearch snapshot failures (elastic#64724) [Uptime] Console errors in case index missing (elastic#65115) [SIEM][CASE] Dynamic fields mapping based on connector (elastic#64412) [test/functional] Tsfy page objects (elastic#64887) [Maps] [Telemetry] Track geo_point and geo_shape index patterns separately (elastic#65195) [Maps] Add global fit to data (elastic#64702) Visualize: Reload on ui state change and fix ui state for tsvb (elastic#63699) [SIEM] [Cases] External service selection per case (elastic#64775) [Uptime] Set ML anomaly look-back to 2w (from 24h) / Add spinner (elastic#65055) [Metrics UI] Remove APM Hard Dependency (elastic#64952) [Ingest] Datastream list: add icons and dashboard links (elastic#65048) disable plugins. they could access ES via SO repository (elastic#65242) Feature fleet enrollment instructions (elastic#65176) [SIEM] Adds 'Configure connector' Cypress test (elastic#64807) [TSVB] Fix std deviation band mode (elastic#64413) ...
|
Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync. |
kibanamachine
added
the
backport missing
simianhacker
added a commit
that referenced
this pull request
May 7, 2020
* [Metrics UI] Remove APM Hard Dependency (#64952) * [Metrics UI] Remove APM Hard Dependency * removing unused variable Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> * Removing unused variables Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
kibanamachine
removed
the
backport missing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR closes #64345 by removing the hard dependency on APM and the code that required it.
Checklist
Delete any items that are not applicable to this PR.