Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature fleet enrollment instructions #65176

Merged

Conversation

nchaulet
Copy link
Member

@nchaulet nchaulet commented May 4, 2020

Summary

Resolve #55453 #61076

Display better enrollment instructions to the user in the enrollment flyout instead of just the elastic-agent enroll command

Done in this PR:

  • update the enrollment instructions to only display manual instructions and not by platform

After discussion with @ruflin We decided to really simplify this flyout for alpha, we are going to display only manual instruction

UI Change

Screen Shot 2020-05-04 at 5 28 31 PM

@nchaulet nchaulet added v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.8.0 Team:Fleet Team label for Observability Data Collection Fleet team labels May 4, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/ingest-management (Team:Ingest Management)

@nchaulet nchaulet self-assigned this May 4, 2020
@nchaulet nchaulet marked this pull request as ready for review May 4, 2020 20:44
@nchaulet nchaulet requested a review from a team May 4, 2020 20:44
@nchaulet nchaulet force-pushed the feature-fleet-enrollment-instructions branch from 909f8da to 18189c1 Compare May 4, 2020 21:23
./elastic-agent enroll ${kibanaUrl} ${apiKey.api_key}${
kibanaCASha256 ? ` --ca_sha256=${kibanaCASha256}` : ''
}
./elastic-agent run`;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does this need sudo or a note about running these commands as root?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you should not run these as root

Copy link
Contributor

@jen-huang jen-huang May 4, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think with recent agent changes @michalpristas said that it needs to be run as root because agent performs chown, chmod, etc actions

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh ok I was not aware of that, if @ph or @michalpristas can confirm the agent need to be runned as root I can add a sudo here

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

atm we made changes so it can run without sudo. these chown chmod operations were performed at /var/run level before. we changed that so you should not need root.
maybe a thing to point out is that user which runs the agent will be used to run beats as well.

x-pack/plugins/ingest_manager/server/plugin.ts Outdated Show resolved Hide resolved
@nchaulet nchaulet requested a review from jen-huang May 4, 2020 22:01
Copy link
Contributor

@jen-huang jen-huang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM, we can add sudo in a follow up PR if CI passes before we get an answer 🙂

@jen-huang jen-huang added the Feature:Fleet Fleet team's agent central management project label May 4, 2020
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@nchaulet nchaulet merged commit 03f4622 into elastic:master May 5, 2020
@nchaulet nchaulet deleted the feature-fleet-enrollment-instructions branch May 5, 2020 11:46
nchaulet added a commit to nchaulet/kibana that referenced this pull request May 5, 2020
gmmorris added a commit to gmmorris/kibana that referenced this pull request May 5, 2020
* master: (133 commits)
  Cleanup Typescript index pattern field editor / Expression functions for bucket agg (elastic#65254)
  Removes legacy infra plugin and moves saved objects registration to NP (elastic#64848)
  Added support for docLinks plugin in Connectors forms and missing save capabilities for modal dialog (elastic#64986)
  [SIEM] Removes prebuilt rules number dependency (elastic#65128)
  [Maps] add categorical palettes with 20 and 30 categories (elastic#64701)
  [CI] Slack alerts - Elasticsearch snapshot failures (elastic#64724)
  [Uptime] Console errors in case index missing (elastic#65115)
  [SIEM][CASE] Dynamic fields mapping based on connector (elastic#64412)
  [test/functional] Tsfy page objects (elastic#64887)
  [Maps] [Telemetry] Track geo_point and geo_shape index patterns separately (elastic#65195)
  [Maps] Add global fit to data (elastic#64702)
  Visualize: Reload on ui state change and fix ui state for tsvb (elastic#63699)
  [SIEM] [Cases] External service selection per case (elastic#64775)
  [Uptime] Set ML anomaly look-back to 2w (from 24h) / Add spinner (elastic#65055)
  [Metrics UI] Remove APM Hard Dependency (elastic#64952)
  [Ingest] Datastream list: add icons and dashboard links (elastic#65048)
  disable plugins. they could access ES via SO repository (elastic#65242)
  Feature fleet enrollment instructions (elastic#65176)
  [SIEM] Adds 'Configure connector' Cypress test (elastic#64807)
  [TSVB] Fix std deviation band mode (elastic#64413)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Fleet Fleet team's agent central management project release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team v7.8.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Fleet] Update the install Agent page
5 participants