Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Metrics UI] Saved views bugs #72518

Merged
merged 20 commits into from
Jul 28, 2020
Merged

[Metrics UI] Saved views bugs #72518

merged 20 commits into from
Jul 28, 2020

Conversation

phillipb
Copy link
Contributor

@phillipb phillipb commented Jul 20, 2020 •
edited
Loading

Summary

Hides the delete button for default view and addresses small UI tweak.

Fixes: #72489

@phillipb phillipb requested a review from a team as a code owner July 20, 2020 19:31
@phillipb phillipb added Feature:Metrics UI Metrics UI feature release_note:skip Skip the PR/issue when compiling release notes Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services v7.9.0 labels Jul 20, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/logs-metrics-ui (Team:logs-metrics-ui)

@phillipb
Fix bug with duplicate loads of data.
5edad20 
Because the load data function takes options.source and the source of options can change, we need to remove it from deps
@phillipb
Copy link
Contributor Author

@elasticmachine merge upstream

@phillipb phillipb changed the title Saved views bugs [Metrics UI] Saved views bugs Jul 21, 2020
@phillipb
Copy link
Contributor Author

@elasticmachine merge upstream

simianhacker
simianhacker reviewed Jul 21, 2020
View reviewed changes
Copy link
Member

@simianhacker simianhacker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It doesn't seem to be sending requests when you manually change the view (change metric, aggregation, grouping). This seems to also affect the refresh button.

@phillipb phillipb requested a review from simianhacker July 21, 2020 23:29
@phillipb
Copy link
Contributor Author

@elasticmachine merge upstream

@phillipb
Copy link
Contributor Author

@elasticmachine merge upstream

@simianhacker
Copy link
Member

I'm still seeing issues in Metrics Explorer, here are the steps to reproduce:

  1. Go to Metrics Explorer
  2. Change the Aggregation OR add a grouping OR add an expression to the search bar
  3. Notice there are no new requests in the dev console, the refresh button doesn't work either.

@phillipb
Copy link
Contributor Author

@elasticmachine merge upstream

simianhacker
simianhacker approved these changes Jul 23, 2020
View reviewed changes
Copy link
Member

@simianhacker simianhacker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@phillipb
Copy link
Contributor Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Build metrics

async chunks size

id value diff baseline
infra 3.6MB +256.0B 3.6MB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@phillipb phillipb merged commit cc84ee3 into elastic:master Jul 28, 2020
@phillipb phillipb mentioned this pull request Jul 28, 2020
Merged
phillipb added a commit to phillipb/kibana that referenced this pull request Jul 28, 2020
@phillipb @elasticmachine
[Metrics UI] Saved views bugs (elastic#72518)
e03225b 
* Add test for logs and metrics telemetry

* wait before you go

* Remove kubenetes

* Fix type check

* Add back kubernetes test

* Remove kubernetes

* Don't allow deleting default default view.

* Fix bug with duplicate loads of data.

Because the load data function takes options.source and the source of options can change, we need to remove it from deps

* Remove unused variable

* Reload when loadData function is changed

* Don't send the request immediately

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
@phillipb phillipb mentioned this pull request Jul 28, 2020
Merged
phillipb added a commit to phillipb/kibana that referenced this pull request Jul 28, 2020
@phillipb @elasticmachine
[Metrics UI] Saved views bugs (elastic#72518)
6b04614 
* Add test for logs and metrics telemetry

* wait before you go

* Remove kubenetes

* Fix type check

* Add back kubernetes test

* Remove kubernetes

* Don't allow deleting default default view.

* Fix bug with duplicate loads of data.

Because the load data function takes options.source and the source of options can change, we need to remove it from deps

* Remove unused variable

* Reload when loadData function is changed

* Don't send the request immediately

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
gmmorris added a commit to gmmorris/kibana that referenced this pull request Jul 28, 2020
@gmmorris
Merge branch 'master' into event-log/use-alerts-actions-clients
76c0b24 
* master: (44 commits)
  [Search] add server logs (elastic#72454)
  [SIEM][Timelines] Updates timeline template callout text (elastic#73334)
  Fix App status  flaky test (elastic#72853)
  [Functional Tests] Increase the timeout when locating the tableview] (elastic#73243)
  Use "Apply_filter_trigger" in dashboard drilldown (elastic#71468)
  fix dashboard index pattern race condition (elastic#72899)
  [Functional Tests] Increase waitTime for timelion to fetch the results (elastic#73255)
  [Functional Tests] Fix flakiness on TSVB chart on switching index patterns test (elastic#73238)
  updates cypress to v4.11.0 (elastic#73327)
  [Metrics UI] Saved views bugs (elastic#72518)
  [Ingest Manager] Convert select agent config step to use combo box (elastic#73172)
  Exclude `version` from package config attributes that are copied, add safeguard to package config bulk create (elastic#73128)
  [Security Solution][ML] Updates siem group name to security (elastic#73218)
  [Security Solution] Show proper icon for termination status of all processes (elastic#73235)
  [Security Solution][Resolver] Show origin node details in panel on load (elastic#73313)
  [Security solution] Threat hunting test coverage improvements (elastic#73276)
  [Security Solution][Exceptions] - Update exception item comments to include id (elastic#73129)
  [Enterprise Search] Error state UI tweaks to account for current Cloud SSO behavior (elastic#73324)
  [dev/build/docker_generator] convert to typescript (elastic#73339)
  [APM] Fix focus map link on service map (elastic#73338)
  ...
phillipb added a commit that referenced this pull request Jul 28, 2020
@phillipb @elasticmachine
[Metrics UI] Saved views bugs (#72518) (#73396)
6be73e6 
* Add test for logs and metrics telemetry

* wait before you go

* Remove kubenetes

* Fix type check

* Add back kubernetes test

* Remove kubernetes

* Don't allow deleting default default view.

* Fix bug with duplicate loads of data.

Because the load data function takes options.source and the source of options can change, we need to remove it from deps

* Remove unused variable

* Reload when loadData function is changed

* Don't send the request immediately

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
phillipb added a commit that referenced this pull request Jul 28, 2020
@phillipb @elasticmachine
[Metrics UI] Saved views bugs (#72518) (#73395)
be357d6 
* Add test for logs and metrics telemetry

* wait before you go

* Remove kubenetes

* Fix type check

* Add back kubernetes test

* Remove kubernetes

* Don't allow deleting default default view.

* Fix bug with duplicate loads of data.

Because the load data function takes options.source and the source of options can change, we need to remove it from deps

* Remove unused variable

* Reload when loadData function is changed

* Don't send the request immediately

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
@Zacqary Zacqary mentioned this pull request Aug 10, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simianhacker simianhacker simianhacker approved these changes

Assignees
No one assigned
Labels
Feature:Metrics UI Metrics UI feature release_note:skip Skip the PR/issue when compiling release notes Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services v7.9.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Metrics UI] Loading saved views in Metrics Explorer results in 2 requests
4 participants
@phillipb @elasticmachine @simianhacker @kibanamachine