[Ingest Manager] Convert select agent config step to use combo box #73172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jen-huang
added
v8.0.0
release_note:skip
|
Pinging @elastic/ingest-management (Team:Ingest Management) |
nchaulet
approved these changes
Jul 27, 2020
skh
reviewed
Jul 27, 2020
| `; | ||
|
|
||
| const AgentConfigNameColumn = styled(EuiFlexItem)` | ||
| max-width: ${(props) => `${((props.grow as number) / 9) * 100}%`}; |
There was a problem hiding this comment.
Why is this additional calculation needed? Would it make sense to add a comment about it?
There was a problem hiding this comment.
- the
max-widthproperty is added to prevent long config names/descriptions from overflowing the flex items - we build it from the
growproperty on the flex items because that property changes based on if Fleet is enabled/setup or not (when Fleet is not available, the "agents enrolled" column is not displayed)
There was a problem hiding this comment.
pushed up a change with comments added
skh
reviewed
Jul 27, 2020
| `; | ||
|
|
||
| const AgentConfigDescriptionColumn = styled(EuiFlexItem)` | ||
| max-width: ${(props) => `${((props.grow as number) / 9) * 100}%`}; |
|
I'm not sure I'm testing this correctly and if I'm seeing the correct behavior:
From the description in the inital comment, I would have expected that no agent configuration is selected at all. |
|
@skh Sorry, I didn't clarify this. "No config selected" is a case that only applies to integrations which are only allowed to be saved once on a config. Currently the only integration with this limitation is Endpoint. For all other integrations, default config should be preselected. |
|
@elasticmachine merge upstream |
💚 Build SucceededBuild metricsasync chunks size
History
To update your PR or re-run it, just comment with: |
jen-huang
added a commit
to jen-huang/kibana
that referenced
this pull request
Jul 28, 2020
…lastic#73172) * Initial pass at using combo box instead of selectable for agent configs * Hide agent count messaging if fleet isn't set up * Fix types * Fix i18n * Fix i18n again * Add comment explaining styling Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
jen-huang
added a commit
that referenced
this pull request
Jul 28, 2020
…73172) (#73394) * Initial pass at using combo box instead of selectable for agent configs * Hide agent count messaging if fleet isn't set up * Fix types * Fix i18n * Fix i18n again * Add comment explaining styling Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Jul 28, 2020
* master: (44 commits) [Search] add server logs (elastic#72454) [SIEM][Timelines] Updates timeline template callout text (elastic#73334) Fix App status flaky test (elastic#72853) [Functional Tests] Increase the timeout when locating the tableview] (elastic#73243) Use "Apply_filter_trigger" in dashboard drilldown (elastic#71468) fix dashboard index pattern race condition (elastic#72899) [Functional Tests] Increase waitTime for timelion to fetch the results (elastic#73255) [Functional Tests] Fix flakiness on TSVB chart on switching index patterns test (elastic#73238) updates cypress to v4.11.0 (elastic#73327) [Metrics UI] Saved views bugs (elastic#72518) [Ingest Manager] Convert select agent config step to use combo box (elastic#73172) Exclude `version` from package config attributes that are copied, add safeguard to package config bulk create (elastic#73128) [Security Solution][ML] Updates siem group name to security (elastic#73218) [Security Solution] Show proper icon for termination status of all processes (elastic#73235) [Security Solution][Resolver] Show origin node details in panel on load (elastic#73313) [Security solution] Threat hunting test coverage improvements (elastic#73276) [Security Solution][Exceptions] - Update exception item comments to include id (elastic#73129) [Enterprise Search] Error state UI tweaks to account for current Cloud SSO behavior (elastic#73324) [dev/build/docker_generator] convert to typescript (elastic#73339) [APM] Fix focus map link on service map (elastic#73338) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Resolves #72865. This PR implements changes to Add integration > Select agent config step based on design spec.
Screenshots
Fleet enabled, initial view (Default config selected already, step 2 loads automatically):
Fleet enabled, dropdown list view:
Fleet no enabled/setup, no agents enrolled messaging:
Default config already has Endpoint integration, no agent config selected by default:
