Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Search] Re-add support for aborting when a connection is closed #76470

Merged
merged 6 commits into from
Sep 13, 2020

Conversation

lukasolson
Copy link
Member

Summary

Re-adds support for aborting search requests to ES when the client disconnects.

When the search service switched over to the new ES client [1], it didn't have direct support for AbortController/AbortSignal. This is a temporary workaround to re-enable aborting discarded requests until there is direct support [2].

Checklist

Delete any items that are not applicable to this PR.

For maintainers

[1] #71276
[2] elastic/elasticsearch-js#1297

Copy link
Contributor

@lizozom lizozom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch

@lizozom
Copy link
Contributor

lizozom commented Sep 6, 2020

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Build metrics

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@lukasolson lukasolson marked this pull request as ready for review September 13, 2020 21:07
@lukasolson lukasolson requested a review from a team as a code owner September 13, 2020 21:07
@lukasolson lukasolson added Feature:Search Querying infrastructure in Kibana Team:AppArch v7.10.0 v8.0.0 labels Sep 13, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-arch (Team:AppArch)

@lukasolson lukasolson added the release_note:skip Skip the PR/issue when compiling release notes label Sep 13, 2020
@lukasolson lukasolson merged commit 49a0035 into elastic:master Sep 13, 2020
lukasolson added a commit to lukasolson/kibana that referenced this pull request Sep 13, 2020
…stic#76470)

* [Search] Re-add support for aborting when a connection is closed

* Fix types

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
lukasolson added a commit that referenced this pull request Sep 14, 2020
) (#77296)

* [Search] Re-add support for aborting when a connection is closed

* Fix types

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
jloleysens added a commit to jloleysens/kibana that referenced this pull request Sep 14, 2020
…s-for-710

* 'master' of github.com:elastic/kibana: (65 commits)
  Separate url forwarding logic and legacy services (elastic#76892)
  Bump yargs-parser to v13.1.2+ (elastic#77009)
  [Ingest Manager] Shared Fleet agent policy action (elastic#76013)
  [Search] Re-add support for aborting when a connection is closed (elastic#76470)
  [Search] Remove long-running query pop-up (elastic#75385)
  [Monitoring] Fix UI error when alerting is not available (elastic#77179)
  do not log plugin id format warning in dist mode (elastic#77134)
  [ML] Improving client side error handling (elastic#76743)
  [Alerting][Connectors] Refactor IBM Resilient: Generic Implementation (phase one) (elastic#74357)
  [Docs] some basic searchsource api docs (elastic#77038)
  add  cGroupOverrides to the legacy config (elastic#77180)
  Change saved object bulkUpdate to work across multiple namespaces (elastic#75478)
  [Security Solution][Resolver] Replace Selectable popover with badges (elastic#76997)
  Removing ml-state index from archive (elastic#77143)
  [Security Solution] Add unit tests for histograms (elastic#77081)
  [Lens] Filters aggregation  (elastic#75635)
  [Enterprise Search] Update WS Overview logic to use new config data (elastic#77122)
  Cleanup type output before building new types (elastic#77211)
  [Security Solution] Use safe type in resolver backend (elastic#76969)
  Use proper lodash syntax (elastic#77105)
  ...

# Conflicts:
#	x-pack/plugins/index_lifecycle_management/public/application/sections/edit_policy/components/node_allocation.tsx
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Search Querying infrastructure in Kibana release_note:skip Skip the PR/issue when compiling release notes v7.10.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants