Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump yargs-parser to v13.1.2+ #77009

Merged
merged 3 commits into from
Sep 14, 2020
Merged

Bump yargs-parser to v13.1.2+ #77009

merged 3 commits into from
Sep 14, 2020

Conversation

watson
Copy link
Contributor

@watson watson commented Sep 9, 2020

No description provided.

@watson watson added v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.10.0 v6.8.13 v7.9.2 labels Sep 9, 2020
@watson watson self-assigned this Sep 9, 2020
@watson watson marked this pull request as ready for review September 10, 2020 09:41
@watson watson requested review from a team as code owners September 10, 2020 09:41
@@ -9,7 +9,7 @@
"build-graphql-types": "node scripts/generate_types_from_graphql.js",
"cypress:open": "cypress open --config-file ./cypress/cypress.json",
"cypress:open-as-ci": "node ../../../scripts/functional_tests --config ../../test/security_solution_cypress/visual_config.ts",
"cypress:run": "cypress run --browser chrome --headless --spec ./cypress/integration/**/*.spec.ts --config-file ./cypress/cypress.json --reporter ../../node_modules/cypress-multi-reporters --reporter-options configFile=./cypress/reporter_config.json; status=$?; ../../node_modules/.bin/mochawesome-merge --reportDir ../../../target/kibana-security-solution/cypress/results > ../../../target/kibana-security-solution/cypress/results/output.json; ../../../node_modules/.bin/marge ../../../target/kibana-security-solution/cypress/results/output.json --reportDir ../../../target/kibana-security-solution/cypress/results; mkdir -p ../../../target/junit && cp ../../../target/kibana-security-solution/cypress/results/*.xml ../../../target/junit/ && exit $status;",
Copy link
Contributor Author

@watson watson Sep 10, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note to reviewers: I upgraded mochawesome-merge from v2.0.1 to v4.1.0. The new version has replaced the --reportDir command line flag with a glob syntax. Hence this change. See Antontelesh/mochawesome-merge#32 for details

@@ -17,12 +17,12 @@
* under the License.
*/

import { expectType } from 'tsd';
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note to reviewers: All the changes in these files from expectType to expectAssignable are because of this breaking change to tsd: tsdjs/tsd@e4c78c7

Copy link
Contributor

@mshustov mshustov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok config-schema changes

Copy link
Contributor

@patrykkopycinski patrykkopycinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @watson 💪

@legrego
Copy link
Member

legrego commented Sep 10, 2020

❤️

image

@watson
Copy link
Contributor Author

watson commented Sep 14, 2020

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Build metrics

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@watson watson merged commit d722ec6 into elastic:master Sep 14, 2020
@watson watson deleted the bump-yargs-parser branch September 14, 2020 08:49
watson added a commit to watson/kibana that referenced this pull request Sep 14, 2020
jloleysens added a commit to jloleysens/kibana that referenced this pull request Sep 14, 2020
…s-for-710

* 'master' of github.com:elastic/kibana: (65 commits)
  Separate url forwarding logic and legacy services (elastic#76892)
  Bump yargs-parser to v13.1.2+ (elastic#77009)
  [Ingest Manager] Shared Fleet agent policy action (elastic#76013)
  [Search] Re-add support for aborting when a connection is closed (elastic#76470)
  [Search] Remove long-running query pop-up (elastic#75385)
  [Monitoring] Fix UI error when alerting is not available (elastic#77179)
  do not log plugin id format warning in dist mode (elastic#77134)
  [ML] Improving client side error handling (elastic#76743)
  [Alerting][Connectors] Refactor IBM Resilient: Generic Implementation (phase one) (elastic#74357)
  [Docs] some basic searchsource api docs (elastic#77038)
  add  cGroupOverrides to the legacy config (elastic#77180)
  Change saved object bulkUpdate to work across multiple namespaces (elastic#75478)
  [Security Solution][Resolver] Replace Selectable popover with badges (elastic#76997)
  Removing ml-state index from archive (elastic#77143)
  [Security Solution] Add unit tests for histograms (elastic#77081)
  [Lens] Filters aggregation  (elastic#75635)
  [Enterprise Search] Update WS Overview logic to use new config data (elastic#77122)
  Cleanup type output before building new types (elastic#77211)
  [Security Solution] Use safe type in resolver backend (elastic#76969)
  Use proper lodash syntax (elastic#77105)
  ...

# Conflicts:
#	x-pack/plugins/index_lifecycle_management/public/application/sections/edit_policy/components/node_allocation.tsx
watson added a commit to watson/kibana that referenced this pull request Sep 14, 2020
# Conflicts:
#	packages/kbn-config-schema/package.json
#	x-pack/plugins/security_solution/package.json
#	yarn.lock
watson added a commit that referenced this pull request Sep 14, 2020
@watson watson removed the v6.8.13 label Sep 14, 2020
@watson watson removed the v7.9.2 label Sep 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release_note:skip Skip the PR/issue when compiling release notes v7.10.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants