Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security Solution][Resolver] Replace Selectable popover with badges #76997

Merged
merged 13 commits into from
Sep 10, 2020
Merged

[Security Solution][Resolver] Replace Selectable popover with badges #76997

merged 13 commits into from
Sep 10, 2020

Conversation

bkimmel
Copy link
Contributor

@bkimmel bkimmel commented Sep 8, 2020 •
edited
Loading

Summary

This PR replaces the EUISelectable/Popover combo with a set of "pills/badges" for displaying and interacting with related event categories. Making this change will allow us to achieve the "open all/close all" functionality we intend to implement next (it could not be done with popovers, because only one of those may be open at a given time).

Screenshots

resolver_pills

Checklist

Delete any items that are not applicable to this PR.

For maintainers

@bkimmel bkimmel added Feature:Resolver Security Solution Resolver feature Team:Endpoint Data Visibility Team managing the endpoint resolver v8.0.0 release_note:skip Skip the PR/issue when compiling release notes labels Sep 10, 2020
@bkimmel bkimmel marked this pull request as ready for review September 10, 2020 15:33
@bkimmel bkimmel requested review from a team as code owners September 10, 2020 15:33
@elasticmachine
Copy link
Contributor

Pinging @elastic/endpoint-app-team (Feature:Resolver)

@elasticmachine
Copy link
Contributor

Pinging @elastic/endpoint-data-visibility-team (Team:Endpoint Data Visibility)

michaelolo24
michaelolo24 reviewed Sep 10, 2020
View reviewed changes
x-pack/plugins/security_solution/public/resolver/view/submenu.tsx Outdated
</EuiPopover>
</div>
<>
<DetailHostButton
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So much cleaner 😄

@bkimmel
Copy link
Contributor Author

bkimmel commented Sep 10, 2020

@elasticmachine merge upstream

bkimmel
bkimmel commented Sep 10, 2020
View reviewed changes
x-pack/plugins/security_solution/public/resolver/view/process_event_dot.tsx
@@ -62,6 +62,11 @@ const StyledDescriptionText = styled.div<StyledDescriptionText>`
width: fit-content;
`;

const StyledOuterGroup = styled.g`
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A styled G 💯

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haha, love it 😂

@bkimmel bkimmel changed the title [Resolver] Replace Selectable popover with badges [Security Solution][Resolver] Replace Selectable popover with badges Sep 10, 2020
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Build metrics

async chunks size

id value diff baseline
securitySolution 10.0MB -3.1KB 10.0MB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@bkimmel bkimmel merged commit fcead4f into elastic:master Sep 10, 2020
@bkimmel bkimmel deleted the resolver/replace-euiselectable branch September 10, 2020 21:40
@bkimmel bkimmel mentioned this pull request Sep 10, 2020
Merged
bkimmel added a commit that referenced this pull request Sep 11, 2020
@bkimmel @elasticmachine
[Security Solution][Resolver] Replace Selectable popover with badges (#…
c9a5082 
…76997) (#77257)

* replace selectable/popover with badges

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
jloleysens added a commit to jloleysens/kibana that referenced this pull request Sep 14, 2020
@jloleysens
Merge branch 'master' of github.com:elastic/kibana into ilm/data-tier…
50d99be 
…s-for-710

* 'master' of github.com:elastic/kibana: (65 commits)
  Separate url forwarding logic and legacy services (elastic#76892)
  Bump yargs-parser to v13.1.2+ (elastic#77009)
  [Ingest Manager] Shared Fleet agent policy action (elastic#76013)
  [Search] Re-add support for aborting when a connection is closed (elastic#76470)
  [Search] Remove long-running query pop-up (elastic#75385)
  [Monitoring] Fix UI error when alerting is not available (elastic#77179)
  do not log plugin id format warning in dist mode (elastic#77134)
  [ML] Improving client side error handling (elastic#76743)
  [Alerting][Connectors] Refactor IBM Resilient: Generic Implementation (phase one) (elastic#74357)
  [Docs] some basic searchsource api docs (elastic#77038)
  add  cGroupOverrides to the legacy config (elastic#77180)
  Change saved object bulkUpdate to work across multiple namespaces (elastic#75478)
  [Security Solution][Resolver] Replace Selectable popover with badges (elastic#76997)
  Removing ml-state index from archive (elastic#77143)
  [Security Solution] Add unit tests for histograms (elastic#77081)
  [Lens] Filters aggregation  (elastic#75635)
  [Enterprise Search] Update WS Overview logic to use new config data (elastic#77122)
  Cleanup type output before building new types (elastic#77211)
  [Security Solution] Use safe type in resolver backend (elastic#76969)
  Use proper lodash syntax (elastic#77105)
  ...

# Conflicts:
#	x-pack/plugins/index_lifecycle_management/public/application/sections/edit_policy/components/node_allocation.tsx
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonathan-buttner jonathan-buttner jonathan-buttner approved these changes

@oatkiller oatkiller oatkiller left review comments

@monina-n monina-n monina-n approved these changes

@michaelolo24 michaelolo24 michaelolo24 approved these changes

Assignees
No one assigned
Labels
Feature:Resolver Security Solution Resolver feature release_note:skip Skip the PR/issue when compiling release notes Team:Endpoint Data Visibility Team managing the endpoint resolver v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@bkimmel @elasticmachine @kibanamachine @oatkiller @michaelolo24 @jonathan-buttner @monina-n