[Vega] Update vega version #78390

alexwizp · 2020-09-24T09:18:32Z

Summary

Update vega version:

vega: 5.13.0 ➡️ 5.16.1 Changelog: https://github.com/vega/vega/releases
vega-lite: 4.13.1 ➡️ 4.16.8 Changelog: https://github.com/vega/vega-lite/releases
vega-schema-url-parser: ^1.1.0 ➡️ ^2.1.0
vega-tooltip: ^0.12.0 ➡️ ^0.24.2

All sample visualizations have been tested. No regression found 🥳

Checklist

Delete any items that are not applicable to this PR.

Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
Documentation was added for features that require explanation or tutorials
Unit or functional tests were updated or added to match the most common scenarios
This was checked for keyboard-only and screenreader accessibility
This renders correctly on smaller devices using a responsive layout. (You can test this in your browser
This was checked for cross-browser compatibility

For maintainers

This was checked for breaking API changes and was labeled appropriately

alexwizp · 2020-09-24T11:41:44Z

src/plugins/vis_type_vega/public/__snapshots__/vega_visualization.test.js.snap

@@ -1,9 +1,9 @@
 // Jest Snapshot v1, https://goo.gl/fbAQLP

-exports[`VegaVisualizations VegaVisualization - basics should show vega blank rectangle on top of a map (vegamap) 1`] = `"<div class=\\"vgaVis__view leaflet-container leaflet-grab leaflet-touch-drag\\" style=\\"height: 100%; position: relative;\\" tabindex=\\"0\\"><div class=\\"leaflet-pane leaflet-map-pane\\" style=\\"left: 0px; top: 0px;\\"><div class=\\"leaflet-pane leaflet-tile-pane\\"></div><div class=\\"leaflet-pane leaflet-shadow-pane\\"></div><div class=\\"leaflet-pane leaflet-overlay-pane\\"><div class=\\"leaflet-vega-container\\" role=\\"graphics-document\\" aria-roledescription=\\"visualization\\" aria-label=\\"Vega visualization\\" style=\\"left: 0px; top: 0px; cursor: default;\\"><svg class=\\"marks\\" width=\\"0\\" height=\\"0\\" viewBox=\\"0 0 0 0\\" style=\\"background-color: transparent;\\"><g fill=\\"none\\" stroke-miterlimit=\\"10\\" transform=\\"translate(0,0)\\"><g class=\\"mark-group role-frame root\\" role=\\"graphics-object\\" aria-roledescription=\\"group mark container\\"><g transform=\\"translate(0,0)\\"><path class=\\"background\\" aria-hidden=\\"true\\" d=\\"M0,0h0v0h0Z\\"></path><g><g class=\\"mark-rect role-mark\\" role=\\"graphics-symbol\\" aria-roledescription=\\"rect mark container\\"><path d=\\"M0,0h0v0h0Z\\" fill=\\"#0f0\\"></path></g></g><path class=\\"foreground\\" aria-hidden=\\"true\\" d=\\"\\" display=\\"none\\"></path></g></g></g></svg></div></div><div class=\\"leaflet-pane leaflet-marker-pane\\"></div><div class=\\"leaflet-pane leaflet-tooltip-pane\\"></div><div class=\\"leaflet-pane leaflet-popup-pane\\"></div></div><div class=\\"leaflet-control-container\\"><div class=\\"leaflet-top leaflet-left\\"><div class=\\"leaflet-control-zoom leaflet-bar leaflet-control\\"><a class=\\"leaflet-control-zoom-in\\" href=\\"#\\" title=\\"Zoom in\\" role=\\"button\\" aria-label=\\"Zoom in\\">+</a><a class=\\"leaflet-control-zoom-out\\" href=\\"#\\" title=\\"Zoom out\\" role=\\"button\\" aria-label=\\"Zoom out\\">−</a></div></div><div class=\\"leaflet-top leaflet-right\\"></div><div class=\\"leaflet-bottom leaflet-left\\"></div><div class=\\"leaflet-bottom leaflet-right\\"><div class=\\"leaflet-control-attribution leaflet-control\\"></div></div></div></div><div class=\\"vgaVis__controls vgaVis__controls--column\\"></div>"`;
+exports[`VegaVisualizations VegaVisualization - basics should show vega blank rectangle on top of a map (vegamap) 1`] = `"<div class=\\"vgaVis__view leaflet-container leaflet-grab leaflet-touch-drag\\" style=\\"height: 100%; position: relative;\\" tabindex=\\"0\\"><div class=\\"leaflet-pane leaflet-map-pane\\" style=\\"left: 0px; top: 0px;\\"><div class=\\"leaflet-pane leaflet-tile-pane\\"></div><div class=\\"leaflet-pane leaflet-shadow-pane\\"></div><div class=\\"leaflet-pane leaflet-overlay-pane\\"><div class=\\"leaflet-vega-container\\" role=\\"graphics-document\\" aria-roledescription=\\"visualization\\" aria-label=\\"Vega visualization\\" style=\\"left: 0px; top: 0px; cursor: default;\\"><svg xmlns=\\"http://www.w3.org/2000/svg\\" xmlns:xlink=\\"http://www.w3.org/1999/xlink\\" version=\\"1.1\\" class=\\"marks\\" width=\\"0\\" height=\\"0\\" viewBox=\\"0 0 0 0\\" style=\\"background-color: transparent;\\"><g fill=\\"none\\" stroke-miterlimit=\\"10\\" transform=\\"translate(0,0)\\"><g class=\\"mark-group role-frame root\\" role=\\"graphics-object\\" aria-roledescription=\\"group mark container\\"><g transform=\\"translate(0,0)\\"><path class=\\"background\\" aria-hidden=\\"true\\" d=\\"M0,0h0v0h0Z\\"></path><g><g class=\\"mark-rect role-mark\\" role=\\"graphics-symbol\\" aria-roledescription=\\"rect mark container\\"><path d=\\"M0,0h0v0h0Z\\" fill=\\"#0f0\\"></path></g></g><path class=\\"foreground\\" aria-hidden=\\"true\\" d=\\"\\" display=\\"none\\"></path></g></g></g></svg></div></div><div class=\\"leaflet-pane leaflet-marker-pane\\"></div><div class=\\"leaflet-pane leaflet-tooltip-pane\\"></div><div class=\\"leaflet-pane leaflet-popup-pane\\"></div></div><div class=\\"leaflet-control-container\\"><div class=\\"leaflet-top leaflet-left\\"><div class=\\"leaflet-control-zoom leaflet-bar leaflet-control\\"><a class=\\"leaflet-control-zoom-in\\" href=\\"#\\" title=\\"Zoom in\\" role=\\"button\\" aria-label=\\"Zoom in\\">+</a><a class=\\"leaflet-control-zoom-out\\" href=\\"#\\" title=\\"Zoom out\\" role=\\"button\\" aria-label=\\"Zoom out\\">−</a></div></div><div class=\\"leaflet-top leaflet-right\\"></div><div class=\\"leaflet-bottom leaflet-left\\"></div><div class=\\"leaflet-bottom leaflet-right\\"><div class=\\"leaflet-control-attribution leaflet-control\\"></div></div></div></div><div class=\\"vgaVis__controls vgaVis__controls--column\\"></div>"`;


Differences are marked in bold green:

Valid for all updated snapshots!

sulemanof

LGTM, didn't test locally.
Any idea why visTypeVega chunk size increased significantly? (+977.1KB)
Did updated vega significantly increase its size or the diff calculation is wrong?

alexwizp · 2020-09-24T20:53:06Z

src/plugins/vis_type_vega/public/lib/vega.js

- * under the License.
- */
-
-import * as vegaLite from 'vega-lite/build-es5/vega-lite';


It was a hack for IE cause this browser doesn't support es6. Now we don't support IE and this ugly part can be removed

alexwizp · 2020-09-24T20:53:54Z

src/plugins/vis_type_vega/public/vega_visualization.test.js

-  vegaLite: jest.requireActual('vega-lite'),
-}));
-
-// FLAKY: https://github.com/elastic/kibana/issues/71713


#71713 issue was closed. The comment is not relevant

alexwizp · 2020-09-25T09:14:45Z

This PR blocked by vega/vega-lite#6900

alexwizp · 2020-09-28T08:47:03Z

@elasticmachine merge upstream

stratoula

LGTM! 🥳

alexwizp · 2020-09-30T09:18:04Z

We decided to temporarily continue using the es5 version of vega libs until the following issue will be resolved: vega/vega-lite#6912

kibanamachine · 2020-09-30T10:45:55Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: 398885d

Metrics [docs]

@kbn/optimizer bundle module count

id	value	diff	baseline
`apm`	1259	-1	1260
`visTypeVega`	79	+1	78
total		-0

async chunks size

id	value	diff	baseline
`apm`	4.1MB	-8.8KB	4.2MB
`visTypeVega`	1.4MB	+49.0KB	1.4MB
total		+40.2KB

History

💔 Build #77763 failed df8e5841cc7542ecf8df839f3270a4ad632e3794
💔 Build #77744 failed d0a9ba683a56dad044500c4077c1cfd3791d1543
💔 Build #77301 failed fa7623a388cf9b860d081ba75ee4769e6d3b6576
💔 Build #77193 failed 1e831ea5a359cec7dd194c5665e62727f0d14a1f
💔 Build #77087 failed ed53887e9d0b2a7ce3a7347314cd9a0f71b81fee

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

elasticmachine · 2020-09-30T11:52:39Z

Pinging @elastic/kibana-app (Team:KibanaApp)

# Conflicts: # yarn.lock

…aly-detection-partition-field * 'master' of github.com:elastic/kibana: (37 commits) [UiActions] Don't throw an error if there are no compatible actions to execute (elastic#78917) [Observability] Kibana nav when docked overlaps the content of the pages. (elastic#78593) Invalid `searchSourceJSON` causes saved object migration to fail (elastic#78535) update vega version (elastic#78390) Fix warning text doesn't get displayed on filters with custom filter name (elastic#78617) [ILM] Data tier notices should reflect tier preferences (elastic#78398) [APM] Service Map: `Not Defined` option doesn't work properly (elastic#77757) Improve invalid field error message at search.aggs.param_types.field (elastic#78587) Remove isDeprecated flag on visType (elastic#78820) Remove unused elasticsearch.preserverHost setting (elastic#78608) Fix condition and adjust tests (elastic#78898) [UX] Add percentile selector (elastic#78562) [ML] Replace use of rest_total_hits_as_int with track_total_hits (elastic#78423) expression service docs (elastic#78774) [Functional] Wait for the page to load and then click the new vis button (elastic#78725) [TSVB] No data in visualizations with annotations (elastic#78794) [kbn/ui-shared-deps] track asset sizes (elastic#78718) delete target before building (elastic#78665) Move indexPattern.popularizeField into discover (elastic#77668) [Security Solution][Resolver]Add backdrop to pills (elastic#78625) ...

alexwizp requested review from timroes, stratoula, sulemanof, DianaDerevyankina and VladLasitsa September 24, 2020 09:23

alexwizp self-assigned this Sep 24, 2020

alexwizp added Feature:Vega Vega visualizations v7.10.0 v8.0.0 Team:Visualizations Visualization editors, elastic-charts and infrastructure release_note:skip Skip the PR/issue when compiling release notes labels Sep 24, 2020

alexwizp commented Sep 24, 2020

View reviewed changes

sulemanof approved these changes Sep 24, 2020

View reviewed changes

alexwizp removed request for timroes and stratoula September 24, 2020 20:14

alexwizp commented Sep 24, 2020

View reviewed changes

stratoula approved these changes Sep 28, 2020

View reviewed changes

stratoula mentioned this pull request Sep 29, 2020

[Vega] Upgrade vega dependencies #78669

Closed

1 task

spalger mentioned this pull request Sep 29, 2020

[ts] enable "resolveJsonModule" and disable existing failures #78855

Merged

update vega version

398885d

alexwizp force-pushed the vega-lib branch from df8e584 to 398885d Compare September 30, 2020 09:14

alexwizp marked this pull request as ready for review September 30, 2020 11:52

alexwizp requested a review from a team September 30, 2020 11:52

alexwizp merged commit b6525cd into elastic:master Sep 30, 2020

alexwizp added a commit to alexwizp/kibana that referenced this pull request Sep 30, 2020

update vega version (elastic#78390)

f37e924

# Conflicts: # yarn.lock

alexwizp mentioned this pull request Sep 30, 2020

[7.x] update vega version (#78390) #78934

Merged

alexwizp added a commit that referenced this pull request Sep 30, 2020

update vega version (#78390) (#78934)

f266a44

# Conflicts: # yarn.lock

walterra mentioned this pull request Dec 10, 2020

[ML] Data Frame Analytics: Scatterplot Matrix #84420

Open

41 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Vega] Update vega version #78390

[Vega] Update vega version #78390

alexwizp commented Sep 24, 2020 •

edited

Loading

alexwizp Sep 24, 2020 •

edited

Loading

sulemanof left a comment

alexwizp Sep 24, 2020

alexwizp Sep 24, 2020

alexwizp commented Sep 25, 2020

alexwizp commented Sep 28, 2020

stratoula left a comment

alexwizp commented Sep 30, 2020

kibanamachine commented Sep 30, 2020

elasticmachine commented Sep 30, 2020

[Vega] Update vega version #78390

[Vega] Update vega version #78390

Conversation

alexwizp commented Sep 24, 2020 • edited Loading

Summary

Checklist

For maintainers

alexwizp Sep 24, 2020 • edited Loading

Choose a reason for hiding this comment

sulemanof left a comment

Choose a reason for hiding this comment

alexwizp Sep 24, 2020

Choose a reason for hiding this comment

alexwizp Sep 24, 2020

Choose a reason for hiding this comment

alexwizp commented Sep 25, 2020

alexwizp commented Sep 28, 2020

stratoula left a comment

Choose a reason for hiding this comment

alexwizp commented Sep 30, 2020

kibanamachine commented Sep 30, 2020

💚 Build Succeeded

Metrics [docs]

@kbn/optimizer bundle module count

async chunks size

History

elasticmachine commented Sep 30, 2020

alexwizp commented Sep 24, 2020 •

edited

Loading

alexwizp Sep 24, 2020 •

edited

Loading