Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

expression service docs #78774

Merged
merged 2 commits into from
Sep 30, 2020
Merged

expression service docs #78774

merged 2 commits into from
Sep 30, 2020

Conversation

ppisljar
Copy link
Member

@ppisljar ppisljar commented Sep 29, 2020 •
edited
Loading

Summary

Adds dev docs for expressions plugin

@ppisljar ppisljar requested review from a team as code owners September 29, 2020 14:05
@ppisljar ppisljar added docs Feature:ExpressionLanguage Interpreter expression language (aka canvas pipeline) Team:AppArch labels Sep 29, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-arch (Team:AppArch)

@ppisljar ppisljar added release_note:skip Skip the PR/issue when compiling release notes v7.11.0 v8.0.0 labels Sep 29, 2020
@ppisljar ppisljar force-pushed the expressions/docs branch 6 times, most recently from b037ffc to d07ccc7 Compare September 29, 2020 17:36
lukeelmers
lukeelmers approved these changes Sep 30, 2020
View reviewed changes
Copy link
Member

@lukeelmers lukeelmers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM, but I did notice that this inline comment seems to be rendering strangely. (I know you didn't touch that specifically here, but I noticed the generated markdown was jumbled).

src/plugins/expressions/public/index.ts
Comment on lines +125 to +127
ExpressionsService,
ExpressionsServiceSetup,
ExpressionsServiceStart,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do these need to be exported for the docs to work? Because otherwise I don't see a need for them as folks should use ExpressionsSetup and ExpressionsStart which extend from them

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, we need to, everything we extend should be exported as well.

src/plugins/expressions/README.asciidoc Outdated Show resolved Hide resolved
@ppisljar @lukeelmers
Update src/plugins/expressions/README.asciidoc
9b075c7 
Co-authored-by: Luke Elmers <lukeelmers@gmail.com>
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

distributable file count

id value diff baseline
default 45829 +1 45828
oss 26572 +1 26571

page load bundle size

id value diff baseline
expressions 204.3KB +123.0B 204.2KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@ppisljar ppisljar merged commit 8e523ed into elastic:master Sep 30, 2020
phillipb added a commit to phillipb/kibana that referenced this pull request Sep 30, 2020
@phillipb
Merge branch 'master' of github.com:elastic/kibana into override-anom…
a3da4bc 
…aly-detection-partition-field

* 'master' of github.com:elastic/kibana: (37 commits)
  [UiActions] Don't throw an error if there are no compatible actions to execute (elastic#78917)
  [Observability] Kibana nav when docked overlaps the content of the pages. (elastic#78593)
  Invalid `searchSourceJSON` causes saved object migration to fail (elastic#78535)
  update vega version (elastic#78390)
  Fix warning text doesn't get displayed on filters with custom filter name (elastic#78617)
  [ILM] Data tier notices should reflect tier preferences (elastic#78398)
  [APM] Service Map: `Not Defined` option doesn't work properly (elastic#77757)
  Improve invalid field error message at search.aggs.param_types.field (elastic#78587)
  Remove isDeprecated flag on visType (elastic#78820)
  Remove unused elasticsearch.preserverHost setting (elastic#78608)
  Fix condition and adjust tests (elastic#78898)
  [UX] Add percentile selector (elastic#78562)
  [ML] Replace use of rest_total_hits_as_int with track_total_hits (elastic#78423)
  expression service docs (elastic#78774)
  [Functional] Wait for the page to load and then click the new vis button (elastic#78725)
  [TSVB] No data in visualizations with annotations (elastic#78794)
  [kbn/ui-shared-deps] track asset sizes (elastic#78718)
  delete target before building (elastic#78665)
  Move indexPattern.popularizeField into discover (elastic#77668)
  [Security Solution][Resolver]Add backdrop to pills (elastic#78625)
  ...
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 78774 or prevent reminders by adding the backport:skip label.

@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Oct 1, 2020
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 78774 or prevent reminders by adding the backport:skip label.

2 similar comments
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 78774 or prevent reminders by adding the backport:skip label.

@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 78774 or prevent reminders by adding the backport:skip label.

@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 78774 or prevent reminders by adding the backport:skip label.

3 similar comments
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 78774 or prevent reminders by adding the backport:skip label.

@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 78774 or prevent reminders by adding the backport:skip label.

@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 78774 or prevent reminders by adding the backport:skip label.

@ppisljar ppisljar mentioned this pull request Oct 12, 2020
Merged
ppisljar added a commit to ppisljar/kibana that referenced this pull request Oct 12, 2020
@ppisljar
expression service docs (elastic#78774)
1c6758a
ppisljar added a commit to ppisljar/kibana that referenced this pull request Oct 12, 2020
@ppisljar
expression service docs (elastic#78774)
63d8cc3
@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Oct 12, 2020
ppisljar added a commit that referenced this pull request Oct 12, 2020
@ppisljar
[7.x] expression service docs (#78774) (#80184)
20147ea
@ppisljar ppisljar removed the v7.10.0 label Oct 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukeelmers lukeelmers lukeelmers approved these changes

@pgayvallet pgayvallet pgayvallet approved these changes

Assignees
No one assigned
Labels
docs Feature:ExpressionLanguage Interpreter expression language (aka canvas pipeline) release_note:skip Skip the PR/issue when compiling release notes v7.11.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ppisljar @elasticmachine @kibanamachine @pgayvallet @lukeelmers