Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Observability] Kibana nav when docked overlaps the content of the pages. #78593

Merged
merged 3 commits into from
Sep 30, 2020
Merged

[Observability] Kibana nav when docked overlaps the content of the pages. #78593

merged 3 commits into from
Sep 30, 2020

Conversation

cauemarcondes
Copy link
Contributor

@cauemarcondes cauemarcondes commented Sep 28, 2020 •
edited
Loading

closes #78386

Screenshot 2020-09-30 at 11 29 15

Screenshot 2020-09-30 at 11 29 28

Screenshot 2020-09-30 at 11 29 46

Screenshot 2020-09-30 at 11 30 01

Screenshot 2020-09-30 at 11 30 10

@cauemarcondes cauemarcondes added release_note:skip Skip the PR/issue when compiling release notes v7.10.0 Feature:Observability Landing labels Sep 28, 2020
@cauemarcondes
Copy link
Contributor Author

retest

@formgeist
Copy link
Contributor

@cauemarcondes Works, but I wonder if it's possible to set a breaking point where those columns goes into a single column? That improve the readability of the content on smaller viewports as well as when the nav is docked. Something like this?

screencapture-localhost-5601-dhe-app-observability-landing-2020-09-28-21_14_19

There's obviously more we can do, but that will fix most of the responsive issues with the page, I think.

@cauemarcondes
Copy link
Contributor Author

@formgeist I updated the description adding some images of the breakpoints.

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

@kbn/optimizer bundle module count

id value diff baseline
observability 96 +9 87

async chunks size

id value diff baseline
observability 163.4KB +6.0KB 157.4KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

formgeist
formgeist approved these changes Sep 30, 2020
View reviewed changes
Copy link
Contributor

@formgeist formgeist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for resolving this

@cauemarcondes cauemarcondes merged commit eebe4ad into elastic:master Sep 30, 2020
@cauemarcondes cauemarcondes deleted the obs-docked-nav branch September 30, 2020 12:16
cauemarcondes added a commit to cauemarcondes/kibana that referenced this pull request Sep 30, 2020
@cauemarcondes
[Observability] Kibana nav when docked overlaps the content of the pa…
80834d5 
…ges. (elastic#78593)

* adding padding left

* adding space left to appSection
@cauemarcondes cauemarcondes mentioned this pull request Sep 30, 2020
Merged
cauemarcondes added a commit that referenced this pull request Sep 30, 2020
@cauemarcondes
[Observability] Kibana nav when docked overlaps the content of the pa…
efb5c25 
…ges. (#78593) (#78937)

* adding padding left

* adding space left to appSection
phillipb added a commit to phillipb/kibana that referenced this pull request Sep 30, 2020
@phillipb
Merge branch 'master' of github.com:elastic/kibana into override-anom…
a3da4bc 
…aly-detection-partition-field

* 'master' of github.com:elastic/kibana: (37 commits)
  [UiActions] Don't throw an error if there are no compatible actions to execute (elastic#78917)
  [Observability] Kibana nav when docked overlaps the content of the pages. (elastic#78593)
  Invalid `searchSourceJSON` causes saved object migration to fail (elastic#78535)
  update vega version (elastic#78390)
  Fix warning text doesn't get displayed on filters with custom filter name (elastic#78617)
  [ILM] Data tier notices should reflect tier preferences (elastic#78398)
  [APM] Service Map: `Not Defined` option doesn't work properly (elastic#77757)
  Improve invalid field error message at search.aggs.param_types.field (elastic#78587)
  Remove isDeprecated flag on visType (elastic#78820)
  Remove unused elasticsearch.preserverHost setting (elastic#78608)
  Fix condition and adjust tests (elastic#78898)
  [UX] Add percentile selector (elastic#78562)
  [ML] Replace use of rest_total_hits_as_int with track_total_hits (elastic#78423)
  expression service docs (elastic#78774)
  [Functional] Wait for the page to load and then click the new vis button (elastic#78725)
  [TSVB] No data in visualizations with annotations (elastic#78794)
  [kbn/ui-shared-deps] track asset sizes (elastic#78718)
  delete target before building (elastic#78665)
  Move indexPattern.popularizeField into discover (elastic#77668)
  [Security Solution][Resolver]Add backdrop to pills (elastic#78625)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@formgeist formgeist formgeist approved these changes

@sorenlouv sorenlouv sorenlouv approved these changes

Assignees
No one assigned
Labels
Feature:Observability Landing release_note:skip Skip the PR/issue when compiling release notes v7.10.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Observability] Kibana nav when docked overlaps the content of the pages.
4 participants
@cauemarcondes @formgeist @kibanamachine @sorenlouv