Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Read receipt avatars look a tiny bit off #26059

Closed
robintown opened this issue Aug 26, 2023 · 0 comments · Fixed by matrix-org/matrix-react-sdk#11483
Closed

Read receipt avatars look a tiny bit off #26059

robintown opened this issue Aug 26, 2023 · 0 comments · Fixed by matrix-org/matrix-react-sdk#11483
Assignees
Labels
A-Avatar A-Read-Receipts O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Tolerable Low/no impact on users T-Defect X-Regression

Comments

@robintown
Copy link
Member

Steps to reproduce

  1. Zoom way in on a read receipt to really see it with clarity

Outcome

What did you expect?

I expect read receipts to look the same as they did prior to matrix-org/matrix-react-sdk#11448

What happened instead?

They have become smaller due to the above update, but the images displayed inside them remain the same size, which means that the images are now too large for their containers. This is best exemplified by looking at an avatar that has a centered icon:

Screenshot 2023-08-26 at 15-07-17 Element 15 kaıkaı

Compare that to the avatar as seen next to a message:

Screenshot 2023-08-26 at 15-08-42 Element 15 Discord bridge

Operating system

NixOS unstable

Browser information

Firefox 115.0.2

URL for webapp

develop.element.io

Application version

Element version: fcd8052-react-64f762d7b0f3-js-5788d9744b76 Olm version: 3.2.14

Homeserver

Not relevant

Will you send logs?

No

@robintown robintown added T-Defect X-Regression S-Tolerable Low/no impact on users A-Read-Receipts A-Avatar O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience labels Aug 26, 2023
@germain-gg germain-gg self-assigned this Aug 29, 2023
germain-gg pushed a commit to matrix-org/matrix-react-sdk that referenced this issue Aug 29, 2023
github-merge-queue bot pushed a commit to matrix-org/matrix-react-sdk that referenced this issue Aug 30, 2023
* Fixes read receipt avatar offset

Fixes element-hq/element-web#26059

* Fix avatar collapsing in thread list

Fixes element-hq/element-web#26064

* Make composer pills use new avatar design

Fixes element-hq/element-web#26067

* Update snapshots

* Update UserInfo snapshot

* Update HTMLExport snapshot

* Fixes avatar placeholder font

Fixes element-hq/element-web#26061
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Avatar A-Read-Receipts O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Tolerable Low/no impact on users T-Defect X-Regression
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants