Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Room pills in edit and send message composer use old default avatars #26067

Closed
turt2live opened this issue Aug 29, 2023 · 1 comment · Fixed by matrix-org/matrix-react-sdk#11483
Closed

Room pills in edit and send message composer use old default avatars #26067

turt2live opened this issue Aug 29, 2023 · 1 comment · Fixed by matrix-org/matrix-react-sdk#11483
Assignees
@germain-gg
Labels
A-Avatar O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Tolerable Low/no impact on users T-Defect

Comments

@turt2live
Copy link
Member

Steps to reproduce

  1. Mention a room without an avatar
  2. Observe the composer state
  3. Send that message
  4. Observe the new avatar style
  5. Edit that message
  6. Observe the same legacy avatar you saw in Step 2

Outcome

What did you expect?

Consistency with the new avatar style.

What happened instead?

image
image

Operating system

Windows 11

Application version

Element Nightly version: 0.0.1-nightly.2023082801 Olm version: 3.2.14

How did you install the app?

The Internet

Homeserver

t2l.io

Will you send logs?

No
@germain-gg germain-gg self-assigned this Aug 29, 2023
@germain-gg germain-gg added A-Avatar S-Tolerable Low/no impact on users O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience labels Aug 29, 2023
@germain-gg
Copy link
Contributor

Fixing this will also fix the issue with the OS notification that @pixlwave just made me aware of

Screenshot 2023-08-29 at 12 45 34 pm

germain-gg pushed a commit to matrix-org/matrix-react-sdk that referenced this issue Aug 29, 2023
Make composer pills use new avatar design
0b7d123 
Fixes element-hq/element-web#26067
@germain-gg germain-gg mentioned this issue Aug 29, 2023
Merged
3 tasks
github-merge-queue bot pushed a commit to matrix-org/matrix-react-sdk that referenced this issue Aug 30, 2023
Fixes read receipt avatar offset (#11483)
6aa86a8 
* Fixes read receipt avatar offset

Fixes element-hq/element-web#26059

* Fix avatar collapsing in thread list

Fixes element-hq/element-web#26064

* Make composer pills use new avatar design

Fixes element-hq/element-web#26067

* Update snapshots

* Update UserInfo snapshot

* Update HTMLExport snapshot

* Fixes avatar placeholder font

Fixes element-hq/element-web#26061
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@germain-gg germain-gg

Labels
A-Avatar O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Tolerable Low/no impact on users T-Defect
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes read receipt avatar offset matrix-org/matrix-react-sdk
2 participants
@germain-gg @turt2live