Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Thread list avatars are inconsistent #26064

Closed
HarHarLinks opened this issue Aug 28, 2023 · 0 comments · Fixed by matrix-org/matrix-react-sdk#11483
Closed

Thread list avatars are inconsistent #26064

HarHarLinks opened this issue Aug 28, 2023 · 0 comments · Fixed by matrix-org/matrix-react-sdk#11483
Assignees
@germain-gg
Labels
A-Avatar O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect X-Regression

Comments

@HarHarLinks
Copy link
Contributor

Steps to reproduce

  1. look at thread list

Outcome

What did you expect?

consistent avatars:

  • same size
  • always
  • same alignment for avatars & placeholders

What happened instead?

image

Operating system

arch

Browser information

firefox

URL for webapp

develop.element.io

Application version

Element version: fcd8052-react-64f762d7b0f3-js-5788d9744b76 Olm version: 3.2.14

Homeserver

matrix.org

Will you send logs?

No
@weeman1337 weeman1337 added S-Minor Impairs non-critical functionality or suitable workarounds exist O-Occasional Affects or can be seen by some users regularly or most users rarely A-Threads A-Avatar X-Regression and removed A-Threads labels Aug 28, 2023
@germain-gg germain-gg self-assigned this Aug 29, 2023
germain-gg pushed a commit to matrix-org/matrix-react-sdk that referenced this issue Aug 29, 2023
Fix avatar collapsing in thread list
2df6d87 
Fixes element-hq/element-web#26064
@germain-gg germain-gg mentioned this issue Aug 29, 2023
Merged
3 tasks
github-merge-queue bot pushed a commit to matrix-org/matrix-react-sdk that referenced this issue Aug 30, 2023
Fixes read receipt avatar offset (#11483)
6aa86a8 
* Fixes read receipt avatar offset

Fixes element-hq/element-web#26059

* Fix avatar collapsing in thread list

Fixes element-hq/element-web#26064

* Make composer pills use new avatar design

Fixes element-hq/element-web#26067

* Update snapshots

* Update UserInfo snapshot

* Update HTMLExport snapshot

* Fixes avatar placeholder font

Fixes element-hq/element-web#26061
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@germain-gg germain-gg

Labels
A-Avatar O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect X-Regression
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes read receipt avatar offset matrix-org/matrix-react-sdk
3 participants
@germain-gg @HarHarLinks @weeman1337