Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ember to 5.5, drop Nodes below 18, drop Mocha support #1125

Merged
merged 18 commits into from
Dec 29, 2023
Merged

Update ember to 5.5, drop Nodes below 18, drop Mocha support #1125

merged 18 commits into from
Dec 29, 2023

Commits on Dec 27, 2023

  1. v3.28.6...v5.5.0

    # Conflicts:
    #	.eslintignore
    #	.eslintrc.js
    #	.github/workflows/ci.yml
    #	.gitignore
    #	.npmignore
    #	.prettierignore
    #	CONTRIBUTING.md
    #	README.md
    #	ember-cli-build.js
    #	tests/dummy/app/index.html
    #	tests/dummy/app/styles/app.css
    #	tests/dummy/config/addon-docs.js
    #	tests/dummy/config/deploy.js
    #	tests/dummy/config/ember-try.js
    #	tests/index.html
    andreyfel committed Dec 27, 2023
    Configuration menu
    Copy the full SHA
    ac53792 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    6b6621f View commit details
    Browse the repository at this point in the history
  3. Bump several dependencies

    - ember-data was using @ember/string which is deprecated to use, so it
    had to be bumped to the latest v5.3.0
    - ember-cli-addon-docs is using ember-data and need to be bumped to the
    latest version v7.0.0 in order to make it work with the latest ember-data.
    - ember-cli-clipboard (a dependency of ember-cli-addon-docs) depends on
    @ember/string and doesn't specify it as dependency. So, we need to specify
    it as our dependency here.
    - Bump @embroider/macros to the latest version to let it properly detect
    presence of the ember-qunit/ember-mocha.
    andreyfel committed Dec 27, 2023
    Configuration menu
    Copy the full SHA
    2d6150c View commit details
    Browse the repository at this point in the history

Commits on Dec 28, 2023

  1. Remove traces of linting tests

    Long time ago linters were run as tests. And ember-exam was splitting
    tests into partitions in lint aware style because linting tests are much
    faster than regular tests.
    
    Nowadays we don't run linters as tests and this feature is no longer
    necessary. Remove it from the code to avoid the confusion of the future
    generations.
    
    The initial driver for this change was a failing test which was
    complaining on something related to jshint and potentially it was caused
    by removal of jshint support from ember-cli.
    andreyfel committed Dec 28, 2023
    Configuration menu
    Copy the full SHA
    35cd64c View commit details
    Browse the repository at this point in the history
  2. Autofix linter errors

    `yarn lint:js --fix`
    andreyfel committed Dec 28, 2023
    Configuration menu
    Copy the full SHA
    88c0a27 View commit details
    Browse the repository at this point in the history
  3. Update node -> n in eslint disable directives

    eslint-plugin-node was replaced by eslint-plugin-n
    andreyfel committed Dec 28, 2023
    Configuration menu
    Copy the full SHA
    4c152d8 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    a460d77 View commit details
    Browse the repository at this point in the history
  5. Remove traces of bower

    It is no longer supported by ember-cli
    andreyfel committed Dec 28, 2023
    Configuration menu
    Copy the full SHA
    9818859 View commit details
    Browse the repository at this point in the history

Commits on Dec 29, 2023

  1. Update dependencies

    Update all dependencies to the latest
    
    `execa` and `chalk` are ESM now, thus we need to import them asynchronously.
    
    `rimraf` offers different imports now
    
    `istanbul` is not needed as a dependency as `nyc` is used instead.
    
    `release-it-lerna-changelog` was renamed to `@release-it-plugins/lerna-changelog`
    
    `testdouble` wasn't used anywhere
    
    `yarn upgrade`
    andreyfel committed Dec 29, 2023
    Configuration menu
    Copy the full SHA
    15538f9 View commit details
    Browse the repository at this point in the history
  2. Drop ember-qunit support below v5

    The scenario wasn't working with ember-cli@5 and ember-qunit has been out
    for a while.
    andreyfel committed Dec 29, 2023
    Configuration menu
    Copy the full SHA
    b760205 View commit details
    Browse the repository at this point in the history
  3. Drop ember 3.28 scenarios

    They are no longer working with ember-cli@5.5.0
    andreyfel committed Dec 29, 2023
    Configuration menu
    Copy the full SHA
    0bb2da6 View commit details
    Browse the repository at this point in the history
  4. Fix bower error

    By some reason ember-try is checking for bower looking at
    scenario.bower, scenario.dependencies and scenario.devDependencies:
    https://github.com/ember-cli/ember-try/blob/8fca8fc3aad863c5902a965287d728415a4a4663/lib/utils/dependency-manager-adapter-factory.js#L20
    
    Fix the error by moving devDependencies into npm object which is correct
    anyway, not sure how it worked before. Seems that peerDependencies also
    should be nullified as otherwise there is an error:
    ```
    ember-exam tried to import "ember-qunit" in "ember-exam/test-support/-private/ember-exam-qunit-test-loader.js" but the package was not resolvable from <path>/ember-exam
    ```
    andreyfel committed Dec 29, 2023
    Configuration menu
    Copy the full SHA
    c249df5 View commit details
    Browse the repository at this point in the history
  5. Fix @ember/polyfills deprecation

    We can use Object.assign instead
    andreyfel committed Dec 29, 2023
    Configuration menu
    Copy the full SHA
    955d71d View commit details
    Browse the repository at this point in the history
  6. Drop mocha support

    ember-mocha is not compatible with ember@5 and its support is dropped,
    so, we can remove mocha support from ember-exam now.
    
    @embroider/macros is not needed anymore as we can use static imports now
    everywhere.
    
    qunit and ember-qunit are required peer dependencies now.
    
    Normalize test modules to use the same syntax: tests are defined in the
    scope of module, use non-arrow functions in modules and tests definitions.
    
    Normalize `ember-qunit` name everywhere in the docs.
    andreyfel committed Dec 29, 2023
    Configuration menu
    Copy the full SHA
    fdbff8c View commit details
    Browse the repository at this point in the history
  7. Move the tests one level up

    `qunit` in path is now redundant as it is the only supported testing
    framework now,
    andreyfel committed Dec 29, 2023
    Configuration menu
    Copy the full SHA
    e12964e View commit details
    Browse the repository at this point in the history
  8. Don't run eslint as mocha tests

    We run eslint as a standalone check
    andreyfel committed Dec 29, 2023
    Configuration menu
    Copy the full SHA
    1f2db28 View commit details
    Browse the repository at this point in the history
  9. Fix getBrowserId tests

    The behavior was changed here but the tests were not updated accordingly:
    #750
    andreyfel committed Dec 29, 2023
    Configuration menu
    Copy the full SHA
    32fce8d View commit details
    Browse the repository at this point in the history
  10. Fix exam command acceptance tests

    Actualise number of tests.
    Remove `ember-test` from the list of tests which doesn't actually exist.
    andreyfel committed Dec 29, 2023
    Configuration menu
    Copy the full SHA
    c954188 View commit details
    Browse the repository at this point in the history