-
-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update ember to 5.5, drop Nodes below 18, drop Mocha support #1125
Merged
Commits on Dec 27, 2023
-
# Conflicts: # .eslintignore # .eslintrc.js # .github/workflows/ci.yml # .gitignore # .npmignore # .prettierignore # CONTRIBUTING.md # README.md # ember-cli-build.js # tests/dummy/app/index.html # tests/dummy/app/styles/app.css # tests/dummy/config/addon-docs.js # tests/dummy/config/deploy.js # tests/dummy/config/ember-try.js # tests/index.html
Configuration menu - View commit details
-
Copy full SHA for ac53792 - Browse repository at this point
Copy the full SHA ac53792View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6b6621f - Browse repository at this point
Copy the full SHA 6b6621fView commit details -
- ember-data was using @ember/string which is deprecated to use, so it had to be bumped to the latest v5.3.0 - ember-cli-addon-docs is using ember-data and need to be bumped to the latest version v7.0.0 in order to make it work with the latest ember-data. - ember-cli-clipboard (a dependency of ember-cli-addon-docs) depends on @ember/string and doesn't specify it as dependency. So, we need to specify it as our dependency here. - Bump @embroider/macros to the latest version to let it properly detect presence of the ember-qunit/ember-mocha.
Configuration menu - View commit details
-
Copy full SHA for 2d6150c - Browse repository at this point
Copy the full SHA 2d6150cView commit details
Commits on Dec 28, 2023
-
Remove traces of linting tests
Long time ago linters were run as tests. And ember-exam was splitting tests into partitions in lint aware style because linting tests are much faster than regular tests. Nowadays we don't run linters as tests and this feature is no longer necessary. Remove it from the code to avoid the confusion of the future generations. The initial driver for this change was a failing test which was complaining on something related to jshint and potentially it was caused by removal of jshint support from ember-cli.
Configuration menu - View commit details
-
Copy full SHA for 35cd64c - Browse repository at this point
Copy the full SHA 35cd64cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 88c0a27 - Browse repository at this point
Copy the full SHA 88c0a27View commit details -
Update node -> n in eslint disable directives
eslint-plugin-node was replaced by eslint-plugin-n
Configuration menu - View commit details
-
Copy full SHA for 4c152d8 - Browse repository at this point
Copy the full SHA 4c152d8View commit details -
Configuration menu - View commit details
-
Copy full SHA for a460d77 - Browse repository at this point
Copy the full SHA a460d77View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9818859 - Browse repository at this point
Copy the full SHA 9818859View commit details
Commits on Dec 29, 2023
-
Update all dependencies to the latest `execa` and `chalk` are ESM now, thus we need to import them asynchronously. `rimraf` offers different imports now `istanbul` is not needed as a dependency as `nyc` is used instead. `release-it-lerna-changelog` was renamed to `@release-it-plugins/lerna-changelog` `testdouble` wasn't used anywhere `yarn upgrade`
Configuration menu - View commit details
-
Copy full SHA for 15538f9 - Browse repository at this point
Copy the full SHA 15538f9View commit details -
Drop ember-qunit support below v5
The scenario wasn't working with ember-cli@5 and ember-qunit has been out for a while.
Configuration menu - View commit details
-
Copy full SHA for b760205 - Browse repository at this point
Copy the full SHA b760205View commit details -
They are no longer working with ember-cli@5.5.0
Configuration menu - View commit details
-
Copy full SHA for 0bb2da6 - Browse repository at this point
Copy the full SHA 0bb2da6View commit details -
By some reason ember-try is checking for bower looking at scenario.bower, scenario.dependencies and scenario.devDependencies: https://github.com/ember-cli/ember-try/blob/8fca8fc3aad863c5902a965287d728415a4a4663/lib/utils/dependency-manager-adapter-factory.js#L20 Fix the error by moving devDependencies into npm object which is correct anyway, not sure how it worked before. Seems that peerDependencies also should be nullified as otherwise there is an error: ``` ember-exam tried to import "ember-qunit" in "ember-exam/test-support/-private/ember-exam-qunit-test-loader.js" but the package was not resolvable from <path>/ember-exam ```
Configuration menu - View commit details
-
Copy full SHA for c249df5 - Browse repository at this point
Copy the full SHA c249df5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 955d71d - Browse repository at this point
Copy the full SHA 955d71dView commit details -
ember-mocha is not compatible with ember@5 and its support is dropped, so, we can remove mocha support from ember-exam now. @embroider/macros is not needed anymore as we can use static imports now everywhere. qunit and ember-qunit are required peer dependencies now. Normalize test modules to use the same syntax: tests are defined in the scope of module, use non-arrow functions in modules and tests definitions. Normalize `ember-qunit` name everywhere in the docs.
Configuration menu - View commit details
-
Copy full SHA for fdbff8c - Browse repository at this point
Copy the full SHA fdbff8cView commit details -
`qunit` in path is now redundant as it is the only supported testing framework now,
Configuration menu - View commit details
-
Copy full SHA for e12964e - Browse repository at this point
Copy the full SHA e12964eView commit details -
Don't run eslint as mocha tests
We run eslint as a standalone check
Configuration menu - View commit details
-
Copy full SHA for 1f2db28 - Browse repository at this point
Copy the full SHA 1f2db28View commit details -
The behavior was changed here but the tests were not updated accordingly: #750
Configuration menu - View commit details
-
Copy full SHA for 32fce8d - Browse repository at this point
Copy the full SHA 32fce8dView commit details -
Fix exam command acceptance tests
Actualise number of tests. Remove `ember-test` from the list of tests which doesn't actually exist.
Configuration menu - View commit details
-
Copy full SHA for c954188 - Browse repository at this point
Copy the full SHA c954188View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.