Update ember to 5.5, drop Nodes below 18, drop Mocha support #1125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # .eslintignore # .eslintrc.js # .github/workflows/ci.yml # .gitignore # .npmignore # .prettierignore # CONTRIBUTING.md # README.md # ember-cli-build.js # tests/dummy/app/index.html # tests/dummy/app/styles/app.css # tests/dummy/config/addon-docs.js # tests/dummy/config/deploy.js # tests/dummy/config/ember-try.js # tests/index.html
- ember-data was using @ember/string which is deprecated to use, so it had to be bumped to the latest v5.3.0 - ember-cli-addon-docs is using ember-data and need to be bumped to the latest version v7.0.0 in order to make it work with the latest ember-data. - ember-cli-clipboard (a dependency of ember-cli-addon-docs) depends on @ember/string and doesn't specify it as dependency. So, we need to specify it as our dependency here. - Bump @embroider/macros to the latest version to let it properly detect presence of the ember-qunit/ember-mocha.
Long time ago linters were run as tests. And ember-exam was splitting tests into partitions in lint aware style because linting tests are much faster than regular tests. Nowadays we don't run linters as tests and this feature is no longer necessary. Remove it from the code to avoid the confusion of the future generations. The initial driver for this change was a failing test which was complaining on something related to jshint and potentially it was caused by removal of jshint support from ember-cli.
`yarn lint:js --fix`
eslint-plugin-node was replaced by eslint-plugin-n
It is no longer supported by ember-cli
Update all dependencies to the latest `execa` and `chalk` are ESM now, thus we need to import them asynchronously. `rimraf` offers different imports now `istanbul` is not needed as a dependency as `nyc` is used instead. `release-it-lerna-changelog` was renamed to `@release-it-plugins/lerna-changelog` `testdouble` wasn't used anywhere `yarn upgrade`
The scenario wasn't working with ember-cli@5 and ember-qunit has been out for a while.
They are no longer working with ember-cli@5.5.0
By some reason ember-try is checking for bower looking at scenario.bower, scenario.dependencies and scenario.devDependencies: https://github.com/ember-cli/ember-try/blob/8fca8fc3aad863c5902a965287d728415a4a4663/lib/utils/dependency-manager-adapter-factory.js#L20 Fix the error by moving devDependencies into npm object which is correct anyway, not sure how it worked before. Seems that peerDependencies also should be nullified as otherwise there is an error: ``` ember-exam tried to import "ember-qunit" in "ember-exam/test-support/-private/ember-exam-qunit-test-loader.js" but the package was not resolvable from <path>/ember-exam ```
We can use Object.assign instead
andreyfel
changed the title
ember-mocha is not compatible with ember@5 and its support is dropped, so, we can remove mocha support from ember-exam now. @embroider/macros is not needed anymore as we can use static imports now everywhere. qunit and ember-qunit are required peer dependencies now. Normalize test modules to use the same syntax: tests are defined in the scope of module, use non-arrow functions in modules and tests definitions. Normalize `ember-qunit` name everywhere in the docs.
`qunit` in path is now redundant as it is the only supported testing framework now,
We run eslint as a standalone check
The behavior was changed here but the tests were not updated accordingly: #750
Actualise number of tests. Remove `ember-test` from the list of tests which doesn't actually exist.
kategengler
reviewed
Dec 29, 2023
| const { execa: originalExeca } = await import('execa'); | ||
| return originalExeca(command, args); | ||
| } | ||
|
|
||
| describe('Acceptance | Exam Iterate Command', function () { | ||
| this.timeout(300000); | ||
|
|
||
| it('should build the app, test it a number of times, and clean it up', function () { |
There was a problem hiding this comment.
Alternatively, here, you could pass an async function as the second arg to it and use await
kategengler
reviewed
Dec 29, 2023
tests/dummy/config/ember-try.js
Outdated
| 'ember-cli-chai': '*', | ||
| 'ember-mocha': '*', | ||
| 'ember-qunit': null, | ||
| npm: { |
There was a problem hiding this comment.
It probably wasn't working before 😬
kategengler
approved these changes
Dec 29, 2023
|
Thank you for doing this, and thank you for the focused commits; made it so much easier to review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.