Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ember to 5.5, drop Nodes below 18, drop Mocha support #1125

Merged
merged 18 commits into from
Dec 29, 2023
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 10 additions & 5 deletions tests/dummy/config/ember-try.js
Original file line number Diff line number Diff line change
Expand Up @@ -6,11 +6,16 @@ const mergeWith = require('lodash.mergewith');

function mochaScenario(scenario = {}) {
return mergeWith({}, scenario, {
devDependencies: {
'chai-dom': '*',
'ember-cli-chai': '*',
'ember-mocha': '*',
'ember-qunit': null,
npm: {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It probably wasn't working before 😬

devDependencies: {
'chai-dom': '*',
'ember-cli-chai': '*',
'ember-mocha': '*',
'ember-qunit': null,
},
peerDependencies: {
'ember-qunit': null,
}
},
});
}
Expand Down