Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: Dragging an image onto the same line crashes #5720

Closed
FinlayBP opened this issue Mar 15, 2024 · 0 comments · May be fixed by Opetushallitus/kouta-ui#574
Closed

Bug: Dragging an image onto the same line crashes #5720

FinlayBP opened this issue Mar 15, 2024 · 0 comments · May be fixed by Opetushallitus/kouta-ui#574
Assignees
@Sahejkm

Comments

@FinlayBP
Copy link

Lexical version: 0.13.1

Steps To Reproduce

  1. Browse to https://playground.lexical.dev/ and insert an image after another element (text, bulleted text, another image etc)
  2. Attempt to drag the image onto the the same line.

image bug

The current behavior

The image overwrites the current line and crashes the editor.

The expected behavior

No change should occur given the image isn't being moved to a different line.
Sahejkm added a commit that referenced this issue Mar 31, 2024
@Sahejkm
Fix #5720 wrong __size value cause the reconcile child event to crash…
c365b3d 
… on image drag
@Sahejkm Sahejkm self-assigned this Mar 31, 2024
Sahejkm added a commit that referenced this issue Apr 1, 2024
@Sahejkm
Fix #5720 wrong __size value cause the reconcile child event to crash…
a82a7f4 
… on image drag
Sahejkm added a commit that referenced this issue Apr 1, 2024
@Sahejkm
Fix #5720 wrong __size value cause the reconcile child event to crash…
8031bb2 
… on image drag
@ivailop7 ivailop7 mentioned this issue Apr 1, 2024
Merged
@Sahejkm Sahejkm closed this as completed in bde1c84 Apr 1, 2024
thegreatercurve added a commit that referenced this issue Apr 24, 2024
@thegreatercurve
Revert "Fix #5720 update the resolvedOffset correctly on image select…
608d71a 
…ion and …"

This reverts commit bde1c84.
thegreatercurve added a commit that referenced this issue Apr 24, 2024
@thegreatercurve
Revert "Fix #5720 update the resolvedOffset correctly on image select…
a7b7c72 
…ion and drag" (#5952)
zurfyx added a commit that referenced this issue Apr 24, 2024
@zurfyx
Revert "Revert "Fix #5720 update the resolvedOffset correctly on imag…
d34cf0c 
…e selection and drag" (#5952)"

This reverts commit a7b7c72.
zurfyx added a commit that referenced this issue Apr 24, 2024
@zurfyx
Revert "Revert "Fix #5720 update the resolvedOffset correctly on imag…
da0964b 
…e selection and drag" (#5952)"

This reverts commit a7b7c72.
zurfyx added a commit that referenced this issue Apr 24, 2024
@zurfyx
Revert "Revert "Fix #5720 update the resolvedOffset correctly on imag…
1f9352b 
…… …e selection and drag" (#5952)" (#5955)
@dmitrymarokhonov dmitrymarokhonov mentioned this issue May 19, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Sahejkm Sahejkm

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Snyk] Upgrade @lexical/react from 0.10.0 to 0.14.5 Opetushallitus/kouta-ui
2 participants
@FinlayBP @Sahejkm