Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Fix #5720 update the resolvedOffset correctly on image selection and drag" #5952

Merged
merged 1 commit into from
Apr 24, 2024
Merged

Revert "Fix #5720 update the resolvedOffset correctly on image selection and drag" #5952

merged 1 commit into from
Apr 24, 2024

Conversation

thegreatercurve
Copy link
Contributor

@thegreatercurve thegreatercurve commented Apr 24, 2024 •
edited
Loading

Reverts #5795

This fixes #5950 which seems like the more serious issue.

Test plan

Validated that mentions can be split in half correctly.

image

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 24, 2024
@vercel Vercel
Copy link

vercel bot commented Apr 24, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
lexical ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 24, 2024 1:11pm
lexical-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 24, 2024 1:11pm

@thegreatercurve thegreatercurve marked this pull request as ready for review April 24, 2024 13:10
@github-actions GitHub Actions
Copy link

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
packages/lexical/dist/Lexical.js 23.64 KB (0%) 473 ms (0%) 306 ms (+440.91% 🔺) 779 ms
packages/lexical-rich-text/dist/LexicalRichText.js 33.83 KB (+0.21% 🔺) 677 ms (+0.21% 🔺) 198 ms (+47.74% 🔺) 875 ms
packages/lexical-plain-text/dist/LexicalPlainText.js 33.76 KB (-0.13% 🔽) 676 ms (-0.13% 🔽) 295 ms (+122.79% 🔺) 970 ms

@thegreatercurve thegreatercurve merged commit a7b7c72 into main Apr 24, 2024
45 checks passed
@thegreatercurve thegreatercurve deleted the revert-5795-5720 branch April 24, 2024 13:53
zurfyx added a commit that referenced this pull request Apr 24, 2024
@zurfyx
Revert "Revert "Fix #5720 update the resolvedOffset correctly on imag…
d34cf0c 
…e selection and drag" (#5952)"

This reverts commit a7b7c72.
zurfyx added a commit that referenced this pull request Apr 24, 2024
@zurfyx
Revert "Revert "Fix #5720 update the resolvedOffset correctly on imag…
da0964b 
…e selection and drag" (#5952)"

This reverts commit a7b7c72.
zurfyx added a commit that referenced this pull request Apr 24, 2024
@zurfyx
Revert "Revert "Fix #5720 update the resolvedOffset correctly on imag…
1f9352b 
…… …e selection and drag" (#5952)" (#5955)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sahejkm Sahejkm Sahejkm approved these changes

@zurfyx zurfyx Awaiting requested review from zurfyx zurfyx is a code owner

@fantactuka fantactuka Awaiting requested review from fantactuka fantactuka is a code owner

@acywatson acywatson Awaiting requested review from acywatson acywatson is a code owner

@Fetz Fetz Awaiting requested review from Fetz Fetz is a code owner

@ivailop7 ivailop7 Awaiting requested review from ivailop7 ivailop7 is a code owner

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: LexicalClipboard pasting over mention crashes Chrome
3 participants
@thegreatercurve @Sahejkm @facebook-github-bot