Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #5720 update the resolvedOffset correctly on image selection and drag #5795

Merged
merged 7 commits into from
Apr 1, 2024
Merged

Fix #5720 update the resolvedOffset correctly on image selection and drag #5795

merged 7 commits into from
Apr 1, 2024

Conversation

Sahejkm
Copy link
Contributor

@Sahejkm Sahejkm commented Apr 1, 2024 •
edited by ivailop7
Loading

Fix for #5720

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 1, 2024
@vercel Vercel
Copy link

vercel bot commented Apr 1, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
lexical ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 1, 2024 8:57am
lexical-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 1, 2024 8:57am

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 1, 2024 •
edited
Loading

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
packages/lexical/dist/Lexical.js 26.77 KB (+0.06% 🔺) 536 ms (+0.06% 🔺) 622 ms (+262.94% 🔺) 1.2 s
packages/lexical-rich-text/dist/LexicalRichText.js 39.01 KB (+0.04% 🔺) 781 ms (+0.04% 🔺) 916 ms (+104.43% 🔺) 1.7 s
packages/lexical-plain-text/dist/LexicalPlainText.js 38.98 KB (+0.04% 🔺) 780 ms (+0.04% 🔺) 684 ms (+48.63% 🔺) 1.5 s

ivailop7
ivailop7 approved these changes Apr 1, 2024
View reviewed changes
Copy link
Collaborator

@ivailop7 ivailop7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Sahejkm Sahejkm merged commit bde1c84 into main Apr 1, 2024
45 checks passed
@thegreatercurve thegreatercurve deleted the 5720 branch April 24, 2024 12:47
@thegreatercurve thegreatercurve mentioned this pull request Apr 24, 2024
Merged
@dmitrymarokhonov dmitrymarokhonov mentioned this pull request May 19, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivailop7 ivailop7 ivailop7 approved these changes

@zurfyx zurfyx Awaiting requested review from zurfyx zurfyx is a code owner

@fantactuka fantactuka Awaiting requested review from fantactuka fantactuka is a code owner

@acywatson acywatson Awaiting requested review from acywatson acywatson is a code owner

@Fetz Fetz Awaiting requested review from Fetz Fetz is a code owner

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Sahejkm @ivailop7 @facebook-github-bot