Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix mount-or-update check in rerenderOptimistic #27277

Merged
merged 1 commit into from
Aug 28, 2023
Merged

Fix mount-or-update check in rerenderOptimistic #27277

merged 1 commit into from
Aug 28, 2023

Conversation

acdlite
Copy link
Collaborator

@acdlite acdlite commented Aug 24, 2023

I noticed this was wrong because it should call updateWorkInProgressHook before it checks if currentHook is null.

@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Aug 24, 2023
@react-sizebot
Copy link

react-sizebot commented Aug 24, 2023 •
edited
Loading

Comparing: b798223...1d2e2e3

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js = 165.61 kB 165.61 kB = 51.88 kB 51.87 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js +0.02% 173.44 kB 173.49 kB +0.02% 54.25 kB 54.26 kB
facebook-www/ReactDOM-prod.classic.js +0.03% 569.80 kB 569.96 kB = 100.39 kB 100.39 kB
facebook-www/ReactDOM-prod.modern.js +0.03% 553.60 kB 553.76 kB = 97.54 kB 97.55 kB

Significant size changes

Includes any change greater than 0.2%:

(No significant changes)

Generated by 🚫 dangerJS against 1d2e2e3

@acdlite
Fix mount-or-update check in rerenderOptimistic
1d2e2e3 
I noticed this was wrong because it should call updateWorkInProgressHook before
it checks if currentHook is null.
@acdlite acdlite force-pushed the fix-useOptimistic-rerender branch from f3fe596 to 1d2e2e3 Compare August 28, 2023 15:04
@acdlite acdlite merged commit 9a01c8b into facebook:main Aug 28, 2023
github-actions bot pushed a commit that referenced this pull request Aug 28, 2023
@acdlite
Fix mount-or-update check in rerenderOptimistic (#27277)
a7a6a73 
I noticed this was wrong because it should call updateWorkInProgressHook
before it checks if currentHook is null.

DiffTrain build for [9a01c8b](9a01c8b)
@acdlite acdlite mentioned this pull request Sep 14, 2023
Merged
acdlite added a commit to acdlite/next.js that referenced this pull request Sep 14, 2023
@acdlite
Update React from dd480ef92 to d6dcad6a8.
49dcc74 
React upstream changes:

- facebook/react#27374
- facebook/react#27369
- facebook/react#27372
- facebook/react#27371
- facebook/react#27370
- facebook/react#27321
- facebook/react#27368
- facebook/react#27367
- facebook/react#27366
- facebook/react#27360
- facebook/react#27361
- facebook/react#27357
- facebook/react#27359
- facebook/react#27358
- facebook/react#27330
- facebook/react#27347
- facebook/react#27307
- facebook/react#27346
- facebook/react#27342
- facebook/react#27340
- facebook/react#27328
- facebook/react#27327
- facebook/react#27325
- facebook/react#27337
- facebook/react#27336
- facebook/react#27323
- facebook/react#27320
- facebook/react#27317
- facebook/react#27318
- facebook/react#27316
- facebook/react#27313
- facebook/react#27309
- facebook/react#27302
- facebook/react#27297
- facebook/react#27295
- facebook/react#27305
- facebook/react#27215
- facebook/react#27304
- facebook/react#27067
- facebook/react#27179
- facebook/react#27278
- facebook/react#27277
- facebook/react#27282
- facebook/react#27230
- facebook/react#27260
- facebook/react#27270
- facebook/react#27273
- facebook/react#27268
- facebook/react#27269
acdlite added a commit to acdlite/next.js that referenced this pull request Sep 14, 2023
@acdlite
Update React from dd480ef92 to d6dcad6a8.
2361578 
React upstream changes:

- facebook/react#27374
- facebook/react#27369
- facebook/react#27372
- facebook/react#27371
- facebook/react#27370
- facebook/react#27321
- facebook/react#27368
- facebook/react#27367
- facebook/react#27366
- facebook/react#27360
- facebook/react#27361
- facebook/react#27357
- facebook/react#27359
- facebook/react#27358
- facebook/react#27330
- facebook/react#27347
- facebook/react#27307
- facebook/react#27346
- facebook/react#27342
- facebook/react#27340
- facebook/react#27328
- facebook/react#27327
- facebook/react#27325
- facebook/react#27337
- facebook/react#27336
- facebook/react#27323
- facebook/react#27320
- facebook/react#27317
- facebook/react#27318
- facebook/react#27316
- facebook/react#27313
- facebook/react#27309
- facebook/react#27302
- facebook/react#27297
- facebook/react#27295
- facebook/react#27305
- facebook/react#27215
- facebook/react#27304
- facebook/react#27067
- facebook/react#27179
- facebook/react#27278
- facebook/react#27277
- facebook/react#27282
- facebook/react#27230
- facebook/react#27260
- facebook/react#27270
- facebook/react#27273
- facebook/react#27268
- facebook/react#27269
acdlite added a commit to acdlite/next.js that referenced this pull request Sep 14, 2023
@acdlite
Update React from dd480ef92 to d6dcad6a8.
7e8e320 
React upstream changes:

- facebook/react#27374
- facebook/react#27369
- facebook/react#27372
- facebook/react#27371
- facebook/react#27370
- facebook/react#27321
- facebook/react#27368
- facebook/react#27367
- facebook/react#27366
- facebook/react#27360
- facebook/react#27361
- facebook/react#27357
- facebook/react#27359
- facebook/react#27358
- facebook/react#27330
- facebook/react#27347
- facebook/react#27307
- facebook/react#27346
- facebook/react#27342
- facebook/react#27340
- facebook/react#27328
- facebook/react#27327
- facebook/react#27325
- facebook/react#27337
- facebook/react#27336
- facebook/react#27323
- facebook/react#27320
- facebook/react#27317
- facebook/react#27318
- facebook/react#27316
- facebook/react#27313
- facebook/react#27309
- facebook/react#27302
- facebook/react#27297
- facebook/react#27295
- facebook/react#27305
- facebook/react#27215
- facebook/react#27304
- facebook/react#27067
- facebook/react#27179
- facebook/react#27278
- facebook/react#27277
- facebook/react#27282
- facebook/react#27230
- facebook/react#27260
- facebook/react#27270
- facebook/react#27273
- facebook/react#27268
- facebook/react#27269
kodiakhq bot pushed a commit to vercel/next.js that referenced this pull request Sep 14, 2023
@acdlite
Update React from dd480ef92 to d6dcad6a8. (#55399)
6f2e9ae 
### React upstream changes:

- facebook/react#27374
- facebook/react#27369
- facebook/react#27372
- facebook/react#27371
- facebook/react#27370
- facebook/react#27321
- facebook/react#27368
- facebook/react#27367
- facebook/react#27366
- facebook/react#27360
- facebook/react#27361
- facebook/react#27357
- facebook/react#27359
- facebook/react#27358
- facebook/react#27330
- facebook/react#27347
- facebook/react#27307
- facebook/react#27346
- facebook/react#27342
- facebook/react#27340
- facebook/react#27328
- facebook/react#27327
- facebook/react#27325
- facebook/react#27337
- facebook/react#27336
- facebook/react#27323
- facebook/react#27320
- facebook/react#27317
- facebook/react#27318
- facebook/react#27316
- facebook/react#27313
- facebook/react#27309
- facebook/react#27302
- facebook/react#27297
- facebook/react#27295
- facebook/react#27305
- facebook/react#27215
- facebook/react#27304
- facebook/react#27067
- facebook/react#27179
- facebook/react#27278
- facebook/react#27277
- facebook/react#27282
- facebook/react#27230
- facebook/react#27260
- facebook/react#27270
- facebook/react#27273
- facebook/react#27268
- facebook/react#27269
EdisonVan pushed a commit to EdisonVan/react that referenced this pull request Apr 15, 2024
@acdlite @AndyPengc12
Fix mount-or-update check in rerenderOptimistic (facebook#27277)
961c048 
I noticed this was wrong because it should call updateWorkInProgressHook
before it checks if currentHook is null.
bigfootjon pushed a commit that referenced this pull request Apr 18, 2024
@acdlite
Fix mount-or-update check in rerenderOptimistic (#27277)
e059d6a 
I noticed this was wrong because it should call updateWorkInProgressHook
before it checks if currentHook is null.

DiffTrain build for commit 9a01c8b.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@acdlite @react-sizebot @facebook-github-bot