Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Float][Fizz] include preloadModule and preinitModule on react-dom/server-rendering-stub #27347

Merged
merged 1 commit into from
Sep 7, 2023

Conversation

gnoff
Copy link
Collaborator

@gnoff gnoff commented Sep 7, 2023

When implementing preloadModule and preinitModule these methods were not exposed on the server rendering stub when they should have been. This PR corrects that omission.

@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Sep 7, 2023
@gnoff gnoff changed the title [Float][Fizz] include preloadModule and preinitModule on the [Float][Fizz] include preloadModule and preinitModule on react-dom/server-rendering-stub Sep 7, 2023
@gnoff gnoff requested a review from sebmarkbage September 7, 2023 20:21
@react-sizebot
Copy link

Comparing: 3566de5...fec6fcc

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js = 165.63 kB 165.63 kB = 51.88 kB 51.88 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js = 174.70 kB 174.70 kB = 54.61 kB 54.61 kB
facebook-www/ReactDOM-prod.classic.js = 570.44 kB 570.44 kB = 100.45 kB 100.45 kB
facebook-www/ReactDOM-prod.modern.js = 554.21 kB 554.21 kB = 97.61 kB 97.61 kB
oss-stable-semver/react-dom/cjs/react-dom-server-rendering-stub.development.js +21.15% 4.19 kB 5.08 kB +2.70% 1.41 kB 1.44 kB
oss-stable/react-dom/cjs/react-dom-server-rendering-stub.development.js +21.02% 4.22 kB 5.10 kB +2.44% 1.44 kB 1.47 kB
oss-stable-semver/react-dom/umd/react-dom-server-rendering-stub.development.js +19.87% 4.64 kB 5.56 kB +2.83% 1.52 kB 1.56 kB
oss-stable/react-dom/umd/react-dom-server-rendering-stub.development.js +19.76% 4.67 kB 5.59 kB +2.58% 1.55 kB 1.59 kB
oss-experimental/react-dom/cjs/react-dom-server-rendering-stub.development.js +12.93% 6.85 kB 7.74 kB +1.72% 2.49 kB 2.54 kB
oss-experimental/react-dom/umd/react-dom-server-rendering-stub.development.js +12.44% 7.41 kB 8.33 kB +1.60% 2.62 kB 2.67 kB
oss-stable-semver/react-dom/cjs/react-dom-server-rendering-stub.production.min.js +11.48% 1.34 kB 1.50 kB +2.81% 0.71 kB 0.73 kB
oss-stable/react-dom/cjs/react-dom-server-rendering-stub.production.min.js +11.26% 1.37 kB 1.52 kB +2.85% 0.74 kB 0.76 kB
oss-experimental/react-dom/cjs/react-dom-server-rendering-stub.production.min.js +10.17% 1.51 kB 1.67 kB +2.53% 0.79 kB 0.81 kB
oss-stable-semver/react-dom/umd/react-dom-server-rendering-stub.production.min.js +9.17% 1.55 kB 1.69 kB +2.38% 0.84 kB 0.86 kB
oss-stable/react-dom/umd/react-dom-server-rendering-stub.production.min.js +9.02% 1.58 kB 1.72 kB +2.08% 0.86 kB 0.88 kB
oss-experimental/react-dom/umd/react-dom-server-rendering-stub.production.min.js +8.20% 1.73 kB 1.87 kB +1.97% 0.91 kB 0.93 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable-semver/react-dom/cjs/react-dom-server-rendering-stub.development.js +21.15% 4.19 kB 5.08 kB +2.70% 1.41 kB 1.44 kB
oss-stable/react-dom/cjs/react-dom-server-rendering-stub.development.js +21.02% 4.22 kB 5.10 kB +2.44% 1.44 kB 1.47 kB
oss-stable-semver/react-dom/umd/react-dom-server-rendering-stub.development.js +19.87% 4.64 kB 5.56 kB +2.83% 1.52 kB 1.56 kB
oss-stable/react-dom/umd/react-dom-server-rendering-stub.development.js +19.76% 4.67 kB 5.59 kB +2.58% 1.55 kB 1.59 kB
oss-experimental/react-dom/cjs/react-dom-server-rendering-stub.development.js +12.93% 6.85 kB 7.74 kB +1.72% 2.49 kB 2.54 kB
oss-experimental/react-dom/umd/react-dom-server-rendering-stub.development.js +12.44% 7.41 kB 8.33 kB +1.60% 2.62 kB 2.67 kB
oss-stable-semver/react-dom/cjs/react-dom-server-rendering-stub.production.min.js +11.48% 1.34 kB 1.50 kB +2.81% 0.71 kB 0.73 kB
oss-stable/react-dom/cjs/react-dom-server-rendering-stub.production.min.js +11.26% 1.37 kB 1.52 kB +2.85% 0.74 kB 0.76 kB
oss-experimental/react-dom/cjs/react-dom-server-rendering-stub.production.min.js +10.17% 1.51 kB 1.67 kB +2.53% 0.79 kB 0.81 kB
oss-stable-semver/react-dom/umd/react-dom-server-rendering-stub.production.min.js +9.17% 1.55 kB 1.69 kB +2.38% 0.84 kB 0.86 kB
oss-stable/react-dom/umd/react-dom-server-rendering-stub.production.min.js +9.02% 1.58 kB 1.72 kB +2.08% 0.86 kB 0.88 kB
oss-experimental/react-dom/umd/react-dom-server-rendering-stub.production.min.js +8.20% 1.73 kB 1.87 kB +1.97% 0.91 kB 0.93 kB

Generated by 🚫 dangerJS against fec6fcc

@gnoff gnoff merged commit 41f0e9d into facebook:main Sep 7, 2023
@gnoff gnoff deleted the expose-methods-on-stub branch September 7, 2023 21:48
EdisonVan pushed a commit to EdisonVan/react that referenced this pull request Apr 15, 2024
…om/server-rendering-stub` (facebook#27347)

When implementing `preloadModule` and `preinitModule` these methods were
not exposed on the server rendering stub when they should have been.
This PR corrects that omission.
bigfootjon pushed a commit that referenced this pull request Apr 18, 2024
…om/server-rendering-stub` (#27347)

When implementing `preloadModule` and `preinitModule` these methods were
not exposed on the server rendering stub when they should have been.
This PR corrects that omission.

DiffTrain build for commit 41f0e9d.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants