Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix[devtools/extension]: fixed duplicating panels in firefox #27320

Merged
merged 1 commit into from
Aug 31, 2023
Merged

fix[devtools/extension]: fixed duplicating panels in firefox #27320

merged 1 commit into from
Aug 31, 2023

Conversation

hoxyq
Copy link
Contributor

@hoxyq hoxyq commented Aug 31, 2023 •
edited
Loading

Multiple chrome.panels.create calls result into having duplicate panels created in Firefox, these changes fix that.

Now calling chrome.panels.create only if there are no panels created yet.

@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Aug 31, 2023
@hoxyq hoxyq requested a review from gsathya August 31, 2023 16:37
@hoxyq hoxyq merged commit 7022e8d into facebook:main Aug 31, 2023
@hoxyq hoxyq deleted the devtools/fix-duplicating-panels-in-firefox branch August 31, 2023 17:24
@hoxyq hoxyq mentioned this pull request Sep 5, 2023
Merged
hoxyq added a commit that referenced this pull request Sep 5, 2023
@hoxyq
React DevTools 4.28.2 -> 4.28.3 (#27337)
a374287 
This is a patch version to fix some bugs in a previous internal release.
I am expecting this one also to be internal-only, need to make sure that
extension is stable in Chrome. Some changes and improvements are
expected for Firefox, though, before going public.

* refactor[devtools/extension]: handle ports disconnection, instead of
frequent reconnection ([hoxyq](https://github.com/hoxyq) in
[#27336](#27336))
* refactor[devtools/extension]: migrate from using setInterval for
polling if react is loaded ([hoxyq](https://github.com/hoxyq) in
[#27323](#27323))
* fix[devtools/extension]: fixed duplicating panels in firefox
([hoxyq](https://github.com/hoxyq) in
[#27320](#27320))
@acdlite acdlite mentioned this pull request Sep 14, 2023
Merged
acdlite added a commit to acdlite/next.js that referenced this pull request Sep 14, 2023
@acdlite
Update React from dd480ef92 to d6dcad6a8.
49dcc74 
React upstream changes:

- facebook/react#27374
- facebook/react#27369
- facebook/react#27372
- facebook/react#27371
- facebook/react#27370
- facebook/react#27321
- facebook/react#27368
- facebook/react#27367
- facebook/react#27366
- facebook/react#27360
- facebook/react#27361
- facebook/react#27357
- facebook/react#27359
- facebook/react#27358
- facebook/react#27330
- facebook/react#27347
- facebook/react#27307
- facebook/react#27346
- facebook/react#27342
- facebook/react#27340
- facebook/react#27328
- facebook/react#27327
- facebook/react#27325
- facebook/react#27337
- facebook/react#27336
- facebook/react#27323
- facebook/react#27320
- facebook/react#27317
- facebook/react#27318
- facebook/react#27316
- facebook/react#27313
- facebook/react#27309
- facebook/react#27302
- facebook/react#27297
- facebook/react#27295
- facebook/react#27305
- facebook/react#27215
- facebook/react#27304
- facebook/react#27067
- facebook/react#27179
- facebook/react#27278
- facebook/react#27277
- facebook/react#27282
- facebook/react#27230
- facebook/react#27260
- facebook/react#27270
- facebook/react#27273
- facebook/react#27268
- facebook/react#27269
acdlite added a commit to acdlite/next.js that referenced this pull request Sep 14, 2023
@acdlite
Update React from dd480ef92 to d6dcad6a8.
2361578 
React upstream changes:

- facebook/react#27374
- facebook/react#27369
- facebook/react#27372
- facebook/react#27371
- facebook/react#27370
- facebook/react#27321
- facebook/react#27368
- facebook/react#27367
- facebook/react#27366
- facebook/react#27360
- facebook/react#27361
- facebook/react#27357
- facebook/react#27359
- facebook/react#27358
- facebook/react#27330
- facebook/react#27347
- facebook/react#27307
- facebook/react#27346
- facebook/react#27342
- facebook/react#27340
- facebook/react#27328
- facebook/react#27327
- facebook/react#27325
- facebook/react#27337
- facebook/react#27336
- facebook/react#27323
- facebook/react#27320
- facebook/react#27317
- facebook/react#27318
- facebook/react#27316
- facebook/react#27313
- facebook/react#27309
- facebook/react#27302
- facebook/react#27297
- facebook/react#27295
- facebook/react#27305
- facebook/react#27215
- facebook/react#27304
- facebook/react#27067
- facebook/react#27179
- facebook/react#27278
- facebook/react#27277
- facebook/react#27282
- facebook/react#27230
- facebook/react#27260
- facebook/react#27270
- facebook/react#27273
- facebook/react#27268
- facebook/react#27269
acdlite added a commit to acdlite/next.js that referenced this pull request Sep 14, 2023
@acdlite
Update React from dd480ef92 to d6dcad6a8.
7e8e320 
React upstream changes:

- facebook/react#27374
- facebook/react#27369
- facebook/react#27372
- facebook/react#27371
- facebook/react#27370
- facebook/react#27321
- facebook/react#27368
- facebook/react#27367
- facebook/react#27366
- facebook/react#27360
- facebook/react#27361
- facebook/react#27357
- facebook/react#27359
- facebook/react#27358
- facebook/react#27330
- facebook/react#27347
- facebook/react#27307
- facebook/react#27346
- facebook/react#27342
- facebook/react#27340
- facebook/react#27328
- facebook/react#27327
- facebook/react#27325
- facebook/react#27337
- facebook/react#27336
- facebook/react#27323
- facebook/react#27320
- facebook/react#27317
- facebook/react#27318
- facebook/react#27316
- facebook/react#27313
- facebook/react#27309
- facebook/react#27302
- facebook/react#27297
- facebook/react#27295
- facebook/react#27305
- facebook/react#27215
- facebook/react#27304
- facebook/react#27067
- facebook/react#27179
- facebook/react#27278
- facebook/react#27277
- facebook/react#27282
- facebook/react#27230
- facebook/react#27260
- facebook/react#27270
- facebook/react#27273
- facebook/react#27268
- facebook/react#27269
kodiakhq bot pushed a commit to vercel/next.js that referenced this pull request Sep 14, 2023
@acdlite
Update React from dd480ef92 to d6dcad6a8. (#55399)
6f2e9ae 
### React upstream changes:

- facebook/react#27374
- facebook/react#27369
- facebook/react#27372
- facebook/react#27371
- facebook/react#27370
- facebook/react#27321
- facebook/react#27368
- facebook/react#27367
- facebook/react#27366
- facebook/react#27360
- facebook/react#27361
- facebook/react#27357
- facebook/react#27359
- facebook/react#27358
- facebook/react#27330
- facebook/react#27347
- facebook/react#27307
- facebook/react#27346
- facebook/react#27342
- facebook/react#27340
- facebook/react#27328
- facebook/react#27327
- facebook/react#27325
- facebook/react#27337
- facebook/react#27336
- facebook/react#27323
- facebook/react#27320
- facebook/react#27317
- facebook/react#27318
- facebook/react#27316
- facebook/react#27313
- facebook/react#27309
- facebook/react#27302
- facebook/react#27297
- facebook/react#27295
- facebook/react#27305
- facebook/react#27215
- facebook/react#27304
- facebook/react#27067
- facebook/react#27179
- facebook/react#27278
- facebook/react#27277
- facebook/react#27282
- facebook/react#27230
- facebook/react#27260
- facebook/react#27270
- facebook/react#27273
- facebook/react#27268
- facebook/react#27269
EdisonVan pushed a commit to EdisonVan/react that referenced this pull request Apr 15, 2024
@hoxyq @AndyPengc12
fix[devtools/extension]: fixed duplicating panels in firefox (faceboo…
b149d22 
…k#27320)

Multiple `chrome.panels.create` calls result into having duplicate
panels created in Firefox, these changes fix that.

Now calling `chrome.panels.create` only if there are no panels created
yet.
EdisonVan pushed a commit to EdisonVan/react that referenced this pull request Apr 15, 2024
@hoxyq @AndyPengc12
React DevTools 4.28.2 -> 4.28.3 (facebook#27337)
786ced6 
This is a patch version to fix some bugs in a previous internal release.
I am expecting this one also to be internal-only, need to make sure that
extension is stable in Chrome. Some changes and improvements are
expected for Firefox, though, before going public.

* refactor[devtools/extension]: handle ports disconnection, instead of
frequent reconnection ([hoxyq](https://github.com/hoxyq) in
[facebook#27336](facebook#27336))
* refactor[devtools/extension]: migrate from using setInterval for
polling if react is loaded ([hoxyq](https://github.com/hoxyq) in
[facebook#27323](facebook#27323))
* fix[devtools/extension]: fixed duplicating panels in firefox
([hoxyq](https://github.com/hoxyq) in
[facebook#27320](facebook#27320))
bigfootjon pushed a commit that referenced this pull request Apr 18, 2024
@hoxyq
fix[devtools/extension]: fixed duplicating panels in firefox (#27320)
ae2f6ca 
Multiple `chrome.panels.create` calls result into having duplicate
panels created in Firefox, these changes fix that.

Now calling `chrome.panels.create` only if there are no panels created
yet.

DiffTrain build for commit 7022e8d.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gsathya gsathya gsathya approved these changes

Assignees
No one assigned
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hoxyq @gsathya @facebook-github-bot