Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename "shared subset" to "server" #27939

Merged
merged 1 commit into from
Jan 17, 2024
Merged

Rename "shared subset" to "server" #27939

merged 1 commit into from
Jan 17, 2024

Conversation

acdlite
Copy link
Collaborator

@acdlite acdlite commented Jan 15, 2024

The internal file ReactSharedSubset is what the react module resolves to when imported from a Server Component environment. We gave it this name because, originally, the idea was that Server Components can access a subset of the APIs available on the client.

However, since then, we've also added APIs that can only by accessed on the server and not the client. In other words, it's no longer a subset, it's a slightly different overlapping set.

So this commit renames ReactSharedSubet to ReactServer and updates all the references. This does not affect the public API, only our internal implementation.

@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Jan 15, 2024
@react-sizebot
Copy link

react-sizebot commented Jan 15, 2024 •
edited
Loading

Comparing: 60a927d...ef6b2f2

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js = 176.19 kB 176.19 kB = 54.88 kB 54.88 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js = 178.29 kB 178.29 kB = 55.53 kB 55.53 kB
facebook-www/ReactDOM-prod.classic.js = 571.89 kB 571.89 kB = 100.56 kB 100.56 kB
facebook-www/ReactDOM-prod.modern.js = 555.65 kB 555.65 kB = 97.63 kB 97.63 kB
facebook-www/ReactServer-dev.modern.js +∞% 0.00 kB 116.83 kB +∞% 0.00 kB 26.58 kB
facebook-www/ReactServer-prod.modern.js +∞% 0.00 kB 15.53 kB +∞% 0.00 kB 4.13 kB
oss-experimental/react-dom/cjs/react-dom.react-server.development.js +∞% 0.00 kB 14.59 kB +∞% 0.00 kB 3.06 kB
oss-experimental/react-dom/cjs/react-dom.react-server.production.js +∞% 0.00 kB 6.26 kB +∞% 0.00 kB 1.23 kB
oss-experimental/react-dom/cjs/react-dom.react-server.production.min.js +∞% 0.00 kB 2.58 kB +∞% 0.00 kB 0.83 kB
oss-experimental/react-dom/react-dom.react-server.js +∞% 0.00 kB 0.22 kB +∞% 0.00 kB 0.16 kB
oss-experimental/react/cjs/react.react-server.development.js +∞% 0.00 kB 94.13 kB +∞% 0.00 kB 26.14 kB
oss-experimental/react/cjs/react.react-server.production.js +∞% 0.00 kB 42.04 kB +∞% 0.00 kB 12.11 kB
oss-experimental/react/cjs/react.react-server.production.min.js +∞% 0.00 kB 9.99 kB +∞% 0.00 kB 3.98 kB
oss-experimental/react/react.react-server.js +∞% 0.00 kB 0.22 kB +∞% 0.00 kB 0.15 kB
oss-stable-semver/react-dom/cjs/react-dom.react-server.development.js +∞% 0.00 kB 14.59 kB +∞% 0.00 kB 3.06 kB
oss-stable-semver/react-dom/cjs/react-dom.react-server.production.js +∞% 0.00 kB 6.26 kB +∞% 0.00 kB 1.23 kB
oss-stable-semver/react-dom/cjs/react-dom.react-server.production.min.js +∞% 0.00 kB 2.58 kB +∞% 0.00 kB 0.83 kB
oss-stable-semver/react-dom/react-dom.react-server.js +∞% 0.00 kB 0.22 kB +∞% 0.00 kB 0.16 kB
oss-stable-semver/react/cjs/react.react-server.development.js +∞% 0.00 kB 85.00 kB +∞% 0.00 kB 23.58 kB
oss-stable-semver/react/cjs/react.react-server.production.js +∞% 0.00 kB 33.99 kB +∞% 0.00 kB 9.91 kB
oss-stable-semver/react/cjs/react.react-server.production.min.js +∞% 0.00 kB 7.41 kB +∞% 0.00 kB 3.11 kB
oss-stable-semver/react/react.react-server.js +∞% 0.00 kB 0.22 kB +∞% 0.00 kB 0.15 kB
oss-stable/react-dom/cjs/react-dom.react-server.development.js +∞% 0.00 kB 14.59 kB +∞% 0.00 kB 3.06 kB
oss-stable/react-dom/cjs/react-dom.react-server.production.js +∞% 0.00 kB 6.26 kB +∞% 0.00 kB 1.23 kB
oss-stable/react-dom/cjs/react-dom.react-server.production.min.js +∞% 0.00 kB 2.58 kB +∞% 0.00 kB 0.83 kB
oss-stable/react-dom/react-dom.react-server.js +∞% 0.00 kB 0.22 kB +∞% 0.00 kB 0.16 kB
oss-stable/react/cjs/react.react-server.development.js +∞% 0.00 kB 85.03 kB +∞% 0.00 kB 23.61 kB
oss-stable/react/cjs/react.react-server.production.js +∞% 0.00 kB 34.01 kB +∞% 0.00 kB 9.94 kB
oss-stable/react/cjs/react.react-server.production.min.js +∞% 0.00 kB 7.44 kB +∞% 0.00 kB 3.14 kB
oss-stable/react/react.react-server.js +∞% 0.00 kB 0.22 kB +∞% 0.00 kB 0.15 kB
test_utils/ReactAllWarnings.js Deleted 67.55 kB 0.00 kB Deleted 16.54 kB 0.00 kB
facebook-www/ReactSharedSubset-dev.modern.js Deleted 116.83 kB 0.00 kB Deleted 26.58 kB 0.00 kB
facebook-www/ReactSharedSubset-prod.modern.js Deleted 15.53 kB 0.00 kB Deleted 4.13 kB 0.00 kB
oss-experimental/react-dom/cjs/react-dom.shared-subset.development.js Deleted 14.60 kB 0.00 kB Deleted 3.06 kB 0.00 kB
oss-experimental/react-dom/cjs/react-dom.shared-subset.production.js Deleted 6.26 kB 0.00 kB Deleted 1.24 kB 0.00 kB
oss-experimental/react-dom/cjs/react-dom.shared-subset.production.min.js Deleted 2.59 kB 0.00 kB Deleted 0.84 kB 0.00 kB
oss-experimental/react-dom/react-dom.shared-subset.js Deleted 0.23 kB 0.00 kB Deleted 0.16 kB 0.00 kB
oss-experimental/react/cjs/react.shared-subset.development.js Deleted 94.13 kB 0.00 kB Deleted 26.14 kB 0.00 kB
oss-experimental/react/cjs/react.shared-subset.production.js Deleted 42.04 kB 0.00 kB Deleted 12.11 kB 0.00 kB
oss-experimental/react/cjs/react.shared-subset.production.min.js Deleted 9.99 kB 0.00 kB Deleted 3.99 kB 0.00 kB
oss-experimental/react/react.shared-subset.js Deleted 0.22 kB 0.00 kB Deleted 0.16 kB 0.00 kB
oss-stable-semver/react-dom/cjs/react-dom.shared-subset.development.js Deleted 14.60 kB 0.00 kB Deleted 3.06 kB 0.00 kB
oss-stable-semver/react-dom/cjs/react-dom.shared-subset.production.js Deleted 6.26 kB 0.00 kB Deleted 1.24 kB 0.00 kB
oss-stable-semver/react-dom/cjs/react-dom.shared-subset.production.min.js Deleted 2.59 kB 0.00 kB Deleted 0.84 kB 0.00 kB
oss-stable-semver/react-dom/react-dom.shared-subset.js Deleted 0.23 kB 0.00 kB Deleted 0.16 kB 0.00 kB
oss-stable-semver/react/cjs/react.shared-subset.development.js Deleted 85.00 kB 0.00 kB Deleted 23.58 kB 0.00 kB
oss-stable-semver/react/cjs/react.shared-subset.production.js Deleted 33.99 kB 0.00 kB Deleted 9.92 kB 0.00 kB
oss-stable-semver/react/cjs/react.shared-subset.production.min.js Deleted 7.42 kB 0.00 kB Deleted 3.12 kB 0.00 kB
oss-stable-semver/react/react.shared-subset.js Deleted 0.22 kB 0.00 kB Deleted 0.16 kB 0.00 kB
oss-stable/react-dom/cjs/react-dom.shared-subset.development.js Deleted 14.60 kB 0.00 kB Deleted 3.06 kB 0.00 kB
oss-stable/react-dom/cjs/react-dom.shared-subset.production.js Deleted 6.26 kB 0.00 kB Deleted 1.24 kB 0.00 kB
oss-stable/react-dom/cjs/react-dom.shared-subset.production.min.js Deleted 2.59 kB 0.00 kB Deleted 0.84 kB 0.00 kB
oss-stable/react-dom/react-dom.shared-subset.js Deleted 0.23 kB 0.00 kB Deleted 0.16 kB 0.00 kB
oss-stable/react/cjs/react.shared-subset.development.js Deleted 85.03 kB 0.00 kB Deleted 23.61 kB 0.00 kB
oss-stable/react/cjs/react.shared-subset.production.js Deleted 34.02 kB 0.00 kB Deleted 9.95 kB 0.00 kB
oss-stable/react/cjs/react.shared-subset.production.min.js Deleted 7.44 kB 0.00 kB Deleted 3.14 kB 0.00 kB
oss-stable/react/react.shared-subset.js Deleted 0.22 kB 0.00 kB Deleted 0.16 kB 0.00 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
facebook-www/ReactServer-dev.modern.js +∞% 0.00 kB 116.83 kB +∞% 0.00 kB 26.58 kB
facebook-www/ReactServer-prod.modern.js +∞% 0.00 kB 15.53 kB +∞% 0.00 kB 4.13 kB
oss-experimental/react-dom/cjs/react-dom.react-server.development.js +∞% 0.00 kB 14.59 kB +∞% 0.00 kB 3.06 kB
oss-experimental/react-dom/cjs/react-dom.react-server.production.js +∞% 0.00 kB 6.26 kB +∞% 0.00 kB 1.23 kB
oss-experimental/react-dom/cjs/react-dom.react-server.production.min.js +∞% 0.00 kB 2.58 kB +∞% 0.00 kB 0.83 kB
oss-experimental/react-dom/react-dom.react-server.js +∞% 0.00 kB 0.22 kB +∞% 0.00 kB 0.16 kB
oss-experimental/react/cjs/react.react-server.development.js +∞% 0.00 kB 94.13 kB +∞% 0.00 kB 26.14 kB
oss-experimental/react/cjs/react.react-server.production.js +∞% 0.00 kB 42.04 kB +∞% 0.00 kB 12.11 kB
oss-experimental/react/cjs/react.react-server.production.min.js +∞% 0.00 kB 9.99 kB +∞% 0.00 kB 3.98 kB
oss-experimental/react/react.react-server.js +∞% 0.00 kB 0.22 kB +∞% 0.00 kB 0.15 kB
oss-stable-semver/react-dom/cjs/react-dom.react-server.development.js +∞% 0.00 kB 14.59 kB +∞% 0.00 kB 3.06 kB
oss-stable-semver/react-dom/cjs/react-dom.react-server.production.js +∞% 0.00 kB 6.26 kB +∞% 0.00 kB 1.23 kB
oss-stable-semver/react-dom/cjs/react-dom.react-server.production.min.js +∞% 0.00 kB 2.58 kB +∞% 0.00 kB 0.83 kB
oss-stable-semver/react-dom/react-dom.react-server.js +∞% 0.00 kB 0.22 kB +∞% 0.00 kB 0.16 kB
oss-stable-semver/react/cjs/react.react-server.development.js +∞% 0.00 kB 85.00 kB +∞% 0.00 kB 23.58 kB
oss-stable-semver/react/cjs/react.react-server.production.js +∞% 0.00 kB 33.99 kB +∞% 0.00 kB 9.91 kB
oss-stable-semver/react/cjs/react.react-server.production.min.js +∞% 0.00 kB 7.41 kB +∞% 0.00 kB 3.11 kB
oss-stable-semver/react/react.react-server.js +∞% 0.00 kB 0.22 kB +∞% 0.00 kB 0.15 kB
oss-stable/react-dom/cjs/react-dom.react-server.development.js +∞% 0.00 kB 14.59 kB +∞% 0.00 kB 3.06 kB
oss-stable/react-dom/cjs/react-dom.react-server.production.js +∞% 0.00 kB 6.26 kB +∞% 0.00 kB 1.23 kB
oss-stable/react-dom/cjs/react-dom.react-server.production.min.js +∞% 0.00 kB 2.58 kB +∞% 0.00 kB 0.83 kB
oss-stable/react-dom/react-dom.react-server.js +∞% 0.00 kB 0.22 kB +∞% 0.00 kB 0.16 kB
oss-stable/react/cjs/react.react-server.development.js +∞% 0.00 kB 85.03 kB +∞% 0.00 kB 23.61 kB
oss-stable/react/cjs/react.react-server.production.js +∞% 0.00 kB 34.01 kB +∞% 0.00 kB 9.94 kB
oss-stable/react/cjs/react.react-server.production.min.js +∞% 0.00 kB 7.44 kB +∞% 0.00 kB 3.14 kB
oss-stable/react/react.react-server.js +∞% 0.00 kB 0.22 kB +∞% 0.00 kB 0.15 kB
test_utils/ReactAllWarnings.js Deleted 67.55 kB 0.00 kB Deleted 16.54 kB 0.00 kB
facebook-www/ReactSharedSubset-dev.modern.js Deleted 116.83 kB 0.00 kB Deleted 26.58 kB 0.00 kB
facebook-www/ReactSharedSubset-prod.modern.js Deleted 15.53 kB 0.00 kB Deleted 4.13 kB 0.00 kB
oss-experimental/react-dom/cjs/react-dom.shared-subset.development.js Deleted 14.60 kB 0.00 kB Deleted 3.06 kB 0.00 kB
oss-experimental/react-dom/cjs/react-dom.shared-subset.production.js Deleted 6.26 kB 0.00 kB Deleted 1.24 kB 0.00 kB
oss-experimental/react-dom/cjs/react-dom.shared-subset.production.min.js Deleted 2.59 kB 0.00 kB Deleted 0.84 kB 0.00 kB
oss-experimental/react-dom/react-dom.shared-subset.js Deleted 0.23 kB 0.00 kB Deleted 0.16 kB 0.00 kB
oss-experimental/react/cjs/react.shared-subset.development.js Deleted 94.13 kB 0.00 kB Deleted 26.14 kB 0.00 kB
oss-experimental/react/cjs/react.shared-subset.production.js Deleted 42.04 kB 0.00 kB Deleted 12.11 kB 0.00 kB
oss-experimental/react/cjs/react.shared-subset.production.min.js Deleted 9.99 kB 0.00 kB Deleted 3.99 kB 0.00 kB
oss-experimental/react/react.shared-subset.js Deleted 0.22 kB 0.00 kB Deleted 0.16 kB 0.00 kB
oss-stable-semver/react-dom/cjs/react-dom.shared-subset.development.js Deleted 14.60 kB 0.00 kB Deleted 3.06 kB 0.00 kB
oss-stable-semver/react-dom/cjs/react-dom.shared-subset.production.js Deleted 6.26 kB 0.00 kB Deleted 1.24 kB 0.00 kB
oss-stable-semver/react-dom/cjs/react-dom.shared-subset.production.min.js Deleted 2.59 kB 0.00 kB Deleted 0.84 kB 0.00 kB
oss-stable-semver/react-dom/react-dom.shared-subset.js Deleted 0.23 kB 0.00 kB Deleted 0.16 kB 0.00 kB
oss-stable-semver/react/cjs/react.shared-subset.development.js Deleted 85.00 kB 0.00 kB Deleted 23.58 kB 0.00 kB
oss-stable-semver/react/cjs/react.shared-subset.production.js Deleted 33.99 kB 0.00 kB Deleted 9.92 kB 0.00 kB
oss-stable-semver/react/cjs/react.shared-subset.production.min.js Deleted 7.42 kB 0.00 kB Deleted 3.12 kB 0.00 kB
oss-stable-semver/react/react.shared-subset.js Deleted 0.22 kB 0.00 kB Deleted 0.16 kB 0.00 kB
oss-stable/react-dom/cjs/react-dom.shared-subset.development.js Deleted 14.60 kB 0.00 kB Deleted 3.06 kB 0.00 kB
oss-stable/react-dom/cjs/react-dom.shared-subset.production.js Deleted 6.26 kB 0.00 kB Deleted 1.24 kB 0.00 kB
oss-stable/react-dom/cjs/react-dom.shared-subset.production.min.js Deleted 2.59 kB 0.00 kB Deleted 0.84 kB 0.00 kB
oss-stable/react-dom/react-dom.shared-subset.js Deleted 0.23 kB 0.00 kB Deleted 0.16 kB 0.00 kB
oss-stable/react/cjs/react.shared-subset.development.js Deleted 85.03 kB 0.00 kB Deleted 23.61 kB 0.00 kB
oss-stable/react/cjs/react.shared-subset.production.js Deleted 34.02 kB 0.00 kB Deleted 9.95 kB 0.00 kB
oss-stable/react/cjs/react.shared-subset.production.min.js Deleted 7.44 kB 0.00 kB Deleted 3.14 kB 0.00 kB
oss-stable/react/react.shared-subset.js Deleted 0.22 kB 0.00 kB Deleted 0.16 kB 0.00 kB

Generated by 🚫 dangerJS against ef6b2f2

@acdlite acdlite marked this pull request as ready for review January 15, 2024 16:20
This was referenced Jan 15, 2024
Merged
Merged
gnoff
gnoff reviewed Jan 16, 2024
View reviewed changes
Copy link
Collaborator

@gnoff gnoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@acdlite When Seb and I discussed this in the past we thought the suffix should be react-server rather than server because it aligns with the condition. If we use just server it is a bit ambiguous since it isn't meant to be used for SSR. I'm still partial to react.react-server.js but lmk if you feel strongly to keep react.server.js

@acdlite
Copy link
Collaborator Author

acdlite commented Jan 16, 2024

@gnoff That's fine with me though I'm not sure react.react-server is much less confusing than react.server in that regard.

How about react.rsc? Or is the idea to align it with the react-server exports condition?

@acdlite
Copy link
Collaborator Author

acdlite commented Jan 16, 2024

I'll switch to react-server for now though we should probably clean up the naming. server-only is another place where the same concept exists but has a different name.

@acdlite acdlite force-pushed the rename-shared-subset-to-server branch from 86a0e60 to 660ba92 Compare January 16, 2024 21:09
@acdlite
Rename "shared subset" to "server"
ef6b2f2 
The internal file ReactSharedSubset is what the `react` module resolves
to when imported from a Server Component environment. We gave it this
name because, originally, the idea was that Server Components can access
a subset of the APIs available on the client.

However, since then, we've also added APIs that can _only_ by accessed
on the server and not the client. In other words, it's no longer a
subset, it's a slightly different overlapping set.

So this commit renames ReactSharedSubet to ReactServer and updates all
the references. This does not affect the public API, only our
internal implementation.
@acdlite acdlite force-pushed the rename-shared-subset-to-server branch from 660ba92 to ef6b2f2 Compare January 16, 2024 21:10
gnoff
gnoff approved these changes Jan 16, 2024
View reviewed changes
Copy link
Collaborator

@gnoff gnoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah the idea was to align it with the condition so it was unambiguous that this file would be used if you used the react-server condition

@acdlite acdlite merged commit 5d1b15a into facebook:main Jan 17, 2024
36 checks passed
github-actions bot pushed a commit that referenced this pull request Jan 17, 2024
@acdlite
Rename "shared subset" to "server" (#27939)
5832ad0 
The internal file ReactSharedSubset is what the `react` module resolves
to when imported from a Server Component environment. We gave it this
name because, originally, the idea was that Server Components can access
a subset of the APIs available on the client.

However, since then, we've also added APIs that can _only_ by accessed
on the server and not the client. In other words, it's no longer a
subset, it's a slightly different overlapping set.

So this commit renames ReactSharedSubet to ReactServer and updates all
the references. This does not affect the public API, only our internal
implementation.

DiffTrain build for [5d1b15a](5d1b15a)
gnoff added a commit to gnoff/next.js that referenced this pull request Feb 1, 2024
@gnoff
Successfully updated React from 60a927d04 to 1219d57fc.
509d4ea 
- facebook/react#28183
- facebook/react#28125
- facebook/react#28157
- facebook/react#28115
- facebook/react#28124
- facebook/react#28163
- facebook/react#28164
- facebook/react#28150
- facebook/react#28159
- facebook/react#28069
- facebook/react#28110
- facebook/react#28148
- facebook/react#28116
- facebook/react#28099
- facebook/react#28100
- facebook/react#28147
- facebook/react#28128
- facebook/react#28126
- facebook/react#28139
- facebook/react#28140
- facebook/react#28141
- facebook/react#28142
- facebook/react#28113
- facebook/react#28129
- facebook/react#28114
- facebook/react#28053
- facebook/react#28091
- facebook/react#28087
- facebook/react#28112
- facebook/react#28086
- facebook/react#28101
- facebook/react#28106
- facebook/react#28117
- facebook/react#28118
- facebook/react#28105
- facebook/react#27883
- facebook/react#28111
- facebook/react#28095
- facebook/react#28108
- facebook/react#28090
- facebook/react#28089
- facebook/react#28076
- facebook/react#28074
- facebook/react#28103
- facebook/react#28098
- facebook/react#28097
- facebook/react#28068
- facebook/react#28093
- facebook/react#28094
- facebook/react#28073
- facebook/react#28084
- facebook/react#28063
- facebook/react#28085
- facebook/react#28083
- facebook/react#28065
- facebook/react#28061
- facebook/react#28077
- facebook/react#28075
- facebook/react#28078
- facebook/react#28050
- facebook/react#28011
- facebook/react#28055
- facebook/react#28066
- facebook/react#28067
- facebook/react#28010
- facebook/react#27993
- facebook/react#28052
- facebook/react#28060
- facebook/react#28059
- facebook/react#28034
- facebook/react#28033
- facebook/react#28004
- facebook/react#28051
- facebook/react#28012
- facebook/react#28001
- facebook/react#28002
- facebook/react#27995
- facebook/react#28006
- facebook/react#28005
- facebook/react#28007
- facebook/react#28008
- facebook/react#28009
- facebook/react#28000
- facebook/react#28003
- facebook/react#27997
- facebook/react#27240
- facebook/react#27977
- facebook/react#27940
- facebook/react#27939
- facebook/react#28090
- facebook/react#28089
- facebook/react#28076
- facebook/react#28074
- facebook/react#28103
- facebook/react#28098
- facebook/react#28097
- facebook/react#28068
- facebook/react#28093
- facebook/react#28094
- facebook/react#28073
- facebook/react#28084
- facebook/react#28063
- facebook/react#28085
- facebook/react#28083
- facebook/react#28065
- facebook/react#28061
- facebook/react#28077
- facebook/react#28075
- facebook/react#28078
- facebook/react#28050
- facebook/react#28011
- facebook/react#28055
- facebook/react#28066
- facebook/react#28067
- facebook/react#28010
- facebook/react#27993
- facebook/react#28052
- facebook/react#28060
- facebook/react#28059
- facebook/react#28034
- facebook/react#28033
- facebook/react#28004
- facebook/react#28051
- facebook/react#28012
- facebook/react#28001
- facebook/react#28002
- facebook/react#27995
- facebook/react#28006
- facebook/react#28005
- facebook/react#28007
- facebook/react#28008
- facebook/react#28009
- facebook/react#28000
- facebook/react#28003
- facebook/react#27997
- facebook/react#27240
- facebook/react#27977
- facebook/react#27940
- facebook/react#27939
@gnoff gnoff mentioned this pull request Feb 1, 2024
Merged
gnoff added a commit to gnoff/next.js that referenced this pull request Feb 5, 2024
@gnoff
Successfully updated React from 60a927d04 to 1219d57fc.
357370d 
- facebook/react#28183
- facebook/react#28125
- facebook/react#28157
- facebook/react#28115
- facebook/react#28124
- facebook/react#28163
- facebook/react#28164
- facebook/react#28150
- facebook/react#28159
- facebook/react#28069
- facebook/react#28110
- facebook/react#28148
- facebook/react#28116
- facebook/react#28099
- facebook/react#28100
- facebook/react#28147
- facebook/react#28128
- facebook/react#28126
- facebook/react#28139
- facebook/react#28140
- facebook/react#28141
- facebook/react#28142
- facebook/react#28113
- facebook/react#28129
- facebook/react#28114
- facebook/react#28053
- facebook/react#28091
- facebook/react#28087
- facebook/react#28112
- facebook/react#28086
- facebook/react#28101
- facebook/react#28106
- facebook/react#28117
- facebook/react#28118
- facebook/react#28105
- facebook/react#27883
- facebook/react#28111
- facebook/react#28095
- facebook/react#28108
- facebook/react#28090
- facebook/react#28089
- facebook/react#28076
- facebook/react#28074
- facebook/react#28103
- facebook/react#28098
- facebook/react#28097
- facebook/react#28068
- facebook/react#28093
- facebook/react#28094
- facebook/react#28073
- facebook/react#28084
- facebook/react#28063
- facebook/react#28085
- facebook/react#28083
- facebook/react#28065
- facebook/react#28061
- facebook/react#28077
- facebook/react#28075
- facebook/react#28078
- facebook/react#28050
- facebook/react#28011
- facebook/react#28055
- facebook/react#28066
- facebook/react#28067
- facebook/react#28010
- facebook/react#27993
- facebook/react#28052
- facebook/react#28060
- facebook/react#28059
- facebook/react#28034
- facebook/react#28033
- facebook/react#28004
- facebook/react#28051
- facebook/react#28012
- facebook/react#28001
- facebook/react#28002
- facebook/react#27995
- facebook/react#28006
- facebook/react#28005
- facebook/react#28007
- facebook/react#28008
- facebook/react#28009
- facebook/react#28000
- facebook/react#28003
- facebook/react#27997
- facebook/react#27240
- facebook/react#27977
- facebook/react#27940
- facebook/react#27939
- facebook/react#28090
- facebook/react#28089
- facebook/react#28076
- facebook/react#28074
- facebook/react#28103
- facebook/react#28098
- facebook/react#28097
- facebook/react#28068
- facebook/react#28093
- facebook/react#28094
- facebook/react#28073
- facebook/react#28084
- facebook/react#28063
- facebook/react#28085
- facebook/react#28083
- facebook/react#28065
- facebook/react#28061
- facebook/react#28077
- facebook/react#28075
- facebook/react#28078
- facebook/react#28050
- facebook/react#28011
- facebook/react#28055
- facebook/react#28066
- facebook/react#28067
- facebook/react#28010
- facebook/react#27993
- facebook/react#28052
- facebook/react#28060
- facebook/react#28059
- facebook/react#28034
- facebook/react#28033
- facebook/react#28004
- facebook/react#28051
- facebook/react#28012
- facebook/react#28001
- facebook/react#28002
- facebook/react#27995
- facebook/react#28006
- facebook/react#28005
- facebook/react#28007
- facebook/react#28008
- facebook/react#28009
- facebook/react#28000
- facebook/react#28003
- facebook/react#27997
- facebook/react#27240
- facebook/react#27977
- facebook/react#27940
- facebook/react#27939
gnoff added a commit to gnoff/next.js that referenced this pull request Feb 6, 2024
@gnoff
updated React from 60a927d04 to 2bc7d336a.
2c56d72 
- facebook/react#28250
- facebook/react#28225
- facebook/react#28123
- facebook/react#28240
- facebook/react#28239
- facebook/react#28245
- facebook/react#28244
- facebook/react#28238
- facebook/react#28235
- facebook/react#28221
- facebook/react#28215
- facebook/react#28214
- facebook/react#28213
- facebook/react#28212
- facebook/react#28211
- facebook/react#28247
- facebook/react#28210
- facebook/react#28186
- facebook/react#28232
- facebook/react#28169
- facebook/react#28177
- facebook/react#28170
- facebook/react#28168
- facebook/react#28122
- facebook/react#27982
- facebook/react#28217
- facebook/react#28223
- facebook/react#28208
- facebook/react#28209
- facebook/react#28200
- facebook/react#28199
- facebook/react#28198
- facebook/react#28197
- facebook/react#28196
- facebook/react#28194
- facebook/react#28192
- facebook/react#28191
- facebook/react#28182
- facebook/react#28181
- facebook/react#28180
- facebook/react#28178
- facebook/react#28201
- facebook/react#28176
- facebook/react#28162
- facebook/react#28131
- facebook/react#28190
- facebook/react#28172
- facebook/react#28171
- facebook/react#28173
- facebook/react#28174
- facebook/react#28175
- facebook/react#28136
- facebook/react#28135
- facebook/react#28134
- facebook/react#28133
- facebook/react#28132
- facebook/react#28130
- facebook/react#28202
- facebook/react#28102
- facebook/react#28161
- facebook/react#28193
- facebook/react#28195
- facebook/react#28189
- facebook/react#28160
- facebook/react#28096
- facebook/react#28183
- facebook/react#28125
- facebook/react#28157
- facebook/react#28115
- facebook/react#28124
- facebook/react#28163
- facebook/react#28164
- facebook/react#28150
- facebook/react#28159
- facebook/react#28069
- facebook/react#28110
- facebook/react#28148
- facebook/react#28116
- facebook/react#28099
- facebook/react#28100
- facebook/react#28147
- facebook/react#28128
- facebook/react#28126
- facebook/react#28139
- facebook/react#28140
- facebook/react#28141
- facebook/react#28142
- facebook/react#28113
- facebook/react#28129
- facebook/react#28114
- facebook/react#28053
- facebook/react#28091
- facebook/react#28087
- facebook/react#28112
- facebook/react#28086
- facebook/react#28101
- facebook/react#28106
- facebook/react#28117
- facebook/react#28118
- facebook/react#28105
- facebook/react#27883
- facebook/react#28111
- facebook/react#28095
- facebook/react#28108
- facebook/react#28090
- facebook/react#28089
- facebook/react#28076
- facebook/react#28074
- facebook/react#28103
- facebook/react#28098
- facebook/react#28097
- facebook/react#28068
- facebook/react#28093
- facebook/react#28094
- facebook/react#28073
- facebook/react#28084
- facebook/react#28063
- facebook/react#28085
- facebook/react#28083
- facebook/react#28065
- facebook/react#28061
- facebook/react#28077
- facebook/react#28075
- facebook/react#28078
- facebook/react#28050
- facebook/react#28011
- facebook/react#28055
- facebook/react#28066
- facebook/react#28067
- facebook/react#28010
- facebook/react#27993
- facebook/react#28052
- facebook/react#28060
- facebook/react#28059
- facebook/react#28034
- facebook/react#28033
- facebook/react#28004
- facebook/react#28051
- facebook/react#28012
- facebook/react#28001
- facebook/react#28002
- facebook/react#27995
- facebook/react#28006
- facebook/react#28005
- facebook/react#28007
- facebook/react#28008
- facebook/react#28009
- facebook/react#28000
- facebook/react#28003
- facebook/react#27997
- facebook/react#27240
- facebook/react#27977
- facebook/react#27940
- facebook/react#27939
- facebook/react#28090
- facebook/react#28089
- facebook/react#28076
- facebook/react#28074
- facebook/react#28103
- facebook/react#28098
- facebook/react#28097
- facebook/react#28068
- facebook/react#28093
- facebook/react#28094
- facebook/react#28073
- facebook/react#28084
- facebook/react#28063
- facebook/react#28085
- facebook/react#28083
- facebook/react#28065
- facebook/react#28061
- facebook/react#28077
- facebook/react#28075
- facebook/react#28078
- facebook/react#28050
- facebook/react#28011
- facebook/react#28055
- facebook/react#28066
- facebook/react#28067
- facebook/react#28010
- facebook/react#27993
- facebook/react#28052
- facebook/react#28060
- facebook/react#28059
- facebook/react#28034
- facebook/react#28033
- facebook/react#28004
- facebook/react#28051
- facebook/react#28012
- facebook/react#28001
- facebook/react#28002
- facebook/react#27995
- facebook/react#28006
- facebook/react#28005
- facebook/react#28007
- facebook/react#28008
- facebook/react#28009
- facebook/react#28000
- facebook/react#28003
- facebook/react#27997
- facebook/react#27240
- facebook/react#27977
- facebook/react#27940
- facebook/react#27939
gnoff added a commit to gnoff/next.js that referenced this pull request Feb 6, 2024
@gnoff
updated React from 60a927d04 to 2bc7d336a.
6290768 
- facebook/react#28250
- facebook/react#28225
- facebook/react#28123
- facebook/react#28240
- facebook/react#28239
- facebook/react#28245
- facebook/react#28244
- facebook/react#28238
- facebook/react#28235
- facebook/react#28221
- facebook/react#28215
- facebook/react#28214
- facebook/react#28213
- facebook/react#28212
- facebook/react#28211
- facebook/react#28247
- facebook/react#28210
- facebook/react#28186
- facebook/react#28232
- facebook/react#28169
- facebook/react#28177
- facebook/react#28170
- facebook/react#28168
- facebook/react#28122
- facebook/react#27982
- facebook/react#28217
- facebook/react#28223
- facebook/react#28208
- facebook/react#28209
- facebook/react#28200
- facebook/react#28199
- facebook/react#28198
- facebook/react#28197
- facebook/react#28196
- facebook/react#28194
- facebook/react#28192
- facebook/react#28191
- facebook/react#28182
- facebook/react#28181
- facebook/react#28180
- facebook/react#28178
- facebook/react#28201
- facebook/react#28176
- facebook/react#28162
- facebook/react#28131
- facebook/react#28190
- facebook/react#28172
- facebook/react#28171
- facebook/react#28173
- facebook/react#28174
- facebook/react#28175
- facebook/react#28136
- facebook/react#28135
- facebook/react#28134
- facebook/react#28133
- facebook/react#28132
- facebook/react#28130
- facebook/react#28202
- facebook/react#28102
- facebook/react#28161
- facebook/react#28193
- facebook/react#28195
- facebook/react#28189
- facebook/react#28160
- facebook/react#28096
- facebook/react#28183
- facebook/react#28125
- facebook/react#28157
- facebook/react#28115
- facebook/react#28124
- facebook/react#28163
- facebook/react#28164
- facebook/react#28150
- facebook/react#28159
- facebook/react#28069
- facebook/react#28110
- facebook/react#28148
- facebook/react#28116
- facebook/react#28099
- facebook/react#28100
- facebook/react#28147
- facebook/react#28128
- facebook/react#28126
- facebook/react#28139
- facebook/react#28140
- facebook/react#28141
- facebook/react#28142
- facebook/react#28113
- facebook/react#28129
- facebook/react#28114
- facebook/react#28053
- facebook/react#28091
- facebook/react#28087
- facebook/react#28112
- facebook/react#28086
- facebook/react#28101
- facebook/react#28106
- facebook/react#28117
- facebook/react#28118
- facebook/react#28105
- facebook/react#27883
- facebook/react#28111
- facebook/react#28095
- facebook/react#28108
- facebook/react#28090
- facebook/react#28089
- facebook/react#28076
- facebook/react#28074
- facebook/react#28103
- facebook/react#28098
- facebook/react#28097
- facebook/react#28068
- facebook/react#28093
- facebook/react#28094
- facebook/react#28073
- facebook/react#28084
- facebook/react#28063
- facebook/react#28085
- facebook/react#28083
- facebook/react#28065
- facebook/react#28061
- facebook/react#28077
- facebook/react#28075
- facebook/react#28078
- facebook/react#28050
- facebook/react#28011
- facebook/react#28055
- facebook/react#28066
- facebook/react#28067
- facebook/react#28010
- facebook/react#27993
- facebook/react#28052
- facebook/react#28060
- facebook/react#28059
- facebook/react#28034
- facebook/react#28033
- facebook/react#28004
- facebook/react#28051
- facebook/react#28012
- facebook/react#28001
- facebook/react#28002
- facebook/react#27995
- facebook/react#28006
- facebook/react#28005
- facebook/react#28007
- facebook/react#28008
- facebook/react#28009
- facebook/react#28000
- facebook/react#28003
- facebook/react#27997
- facebook/react#27240
- facebook/react#27977
- facebook/react#27940
- facebook/react#27939
- facebook/react#28090
- facebook/react#28089
- facebook/react#28076
- facebook/react#28074
- facebook/react#28103
- facebook/react#28098
- facebook/react#28097
- facebook/react#28068
- facebook/react#28093
- facebook/react#28094
- facebook/react#28073
- facebook/react#28084
- facebook/react#28063
- facebook/react#28085
- facebook/react#28083
- facebook/react#28065
- facebook/react#28061
- facebook/react#28077
- facebook/react#28075
- facebook/react#28078
- facebook/react#28050
- facebook/react#28011
- facebook/react#28055
- facebook/react#28066
- facebook/react#28067
- facebook/react#28010
- facebook/react#27993
- facebook/react#28052
- facebook/react#28060
- facebook/react#28059
- facebook/react#28034
- facebook/react#28033
- facebook/react#28004
- facebook/react#28051
- facebook/react#28012
- facebook/react#28001
- facebook/react#28002
- facebook/react#27995
- facebook/react#28006
- facebook/react#28005
- facebook/react#28007
- facebook/react#28008
- facebook/react#28009
- facebook/react#28000
- facebook/react#28003
- facebook/react#27997
- facebook/react#27240
- facebook/react#27977
- facebook/react#27940
- facebook/react#27939
gnoff added a commit to vercel/next.js that referenced this pull request Feb 6, 2024
@gnoff
Update React from 60a927d04 to 2bc7d336a (#61522)
2395557 
Updates React from 60a927d04 to 2bc7d336a

Also updates aliases for `react.shared-subset` to `react.react-server`

### React upstream changes

- facebook/react#28250
- facebook/react#28225
- facebook/react#28123
- facebook/react#28240
- facebook/react#28239
- facebook/react#28245
- facebook/react#28244
- facebook/react#28238
- facebook/react#28235
- facebook/react#28221
- facebook/react#28215
- facebook/react#28214
- facebook/react#28213
- facebook/react#28212
- facebook/react#28211
- facebook/react#28247
- facebook/react#28210
- facebook/react#28186
- facebook/react#28232
- facebook/react#28169
- facebook/react#28177
- facebook/react#28170
- facebook/react#28168
- facebook/react#28122
- facebook/react#27982
- facebook/react#28217
- facebook/react#28223
- facebook/react#28208
- facebook/react#28209
- facebook/react#28200
- facebook/react#28199
- facebook/react#28198
- facebook/react#28197
- facebook/react#28196
- facebook/react#28194
- facebook/react#28192
- facebook/react#28191
- facebook/react#28182
- facebook/react#28181
- facebook/react#28180
- facebook/react#28178
- facebook/react#28201
- facebook/react#28176
- facebook/react#28162
- facebook/react#28131
- facebook/react#28190
- facebook/react#28172
- facebook/react#28171
- facebook/react#28173
- facebook/react#28174
- facebook/react#28175
- facebook/react#28136
- facebook/react#28135
- facebook/react#28134
- facebook/react#28133
- facebook/react#28132
- facebook/react#28130
- facebook/react#28202
- facebook/react#28102
- facebook/react#28161
- facebook/react#28193
- facebook/react#28195
- facebook/react#28189
- facebook/react#28160
- facebook/react#28096
- facebook/react#28183
- facebook/react#28125
- facebook/react#28157
- facebook/react#28115
- facebook/react#28124
- facebook/react#28163
- facebook/react#28164
- facebook/react#28150
- facebook/react#28159
- facebook/react#28069
- facebook/react#28110
- facebook/react#28148
- facebook/react#28116
- facebook/react#28099
- facebook/react#28100
- facebook/react#28147
- facebook/react#28128
- facebook/react#28126
- facebook/react#28139
- facebook/react#28140
- facebook/react#28141
- facebook/react#28142
- facebook/react#28113
- facebook/react#28129
- facebook/react#28114
- facebook/react#28053
- facebook/react#28091
- facebook/react#28087
- facebook/react#28112
- facebook/react#28086
- facebook/react#28101
- facebook/react#28106
- facebook/react#28117
- facebook/react#28118
- facebook/react#28105
- facebook/react#27883
- facebook/react#28111
- facebook/react#28095
- facebook/react#28108
- facebook/react#28090
- facebook/react#28089
- facebook/react#28076
- facebook/react#28074
- facebook/react#28103
- facebook/react#28098
- facebook/react#28097
- facebook/react#28068
- facebook/react#28093
- facebook/react#28094
- facebook/react#28073
- facebook/react#28084
- facebook/react#28063
- facebook/react#28085
- facebook/react#28083
- facebook/react#28065
- facebook/react#28061
- facebook/react#28077
- facebook/react#28075
- facebook/react#28078
- facebook/react#28050
- facebook/react#28011
- facebook/react#28055
- facebook/react#28066
- facebook/react#28067
- facebook/react#28010
- facebook/react#27993
- facebook/react#28052
- facebook/react#28060
- facebook/react#28059
- facebook/react#28034
- facebook/react#28033
- facebook/react#28004
- facebook/react#28051
- facebook/react#28012
- facebook/react#28001
- facebook/react#28002
- facebook/react#27995
- facebook/react#28006
- facebook/react#28005
- facebook/react#28007
- facebook/react#28008
- facebook/react#28009
- facebook/react#28000
- facebook/react#28003
- facebook/react#27997
- facebook/react#27240
- facebook/react#27977
- facebook/react#27940
- facebook/react#27939
- facebook/react#28090
- facebook/react#28089
- facebook/react#28076
- facebook/react#28074
- facebook/react#28103
- facebook/react#28098
- facebook/react#28097
- facebook/react#28068
- facebook/react#28093
- facebook/react#28094
- facebook/react#28073
- facebook/react#28084
- facebook/react#28063
- facebook/react#28085
- facebook/react#28083
- facebook/react#28065
- facebook/react#28061
- facebook/react#28077
- facebook/react#28075
- facebook/react#28078
- facebook/react#28050
- facebook/react#28011
- facebook/react#28055
- facebook/react#28066
- facebook/react#28067
- facebook/react#28010
- facebook/react#27993
- facebook/react#28052
- facebook/react#28060
- facebook/react#28059
- facebook/react#28034
- facebook/react#28033
- facebook/react#28004
- facebook/react#28051
- facebook/react#28012
- facebook/react#28001
- facebook/react#28002
- facebook/react#27995
- facebook/react#28006
- facebook/react#28005
- facebook/react#28007
- facebook/react#28008
- facebook/react#28009
- facebook/react#28000
- facebook/react#28003
- facebook/react#27997
- facebook/react#27240
- facebook/react#27977
- facebook/react#27940
- facebook/react#27939

Closes NEXT-2331
@ztanner ztanner mentioned this pull request Mar 19, 2024
Closed
EdisonVan pushed a commit to EdisonVan/react that referenced this pull request Apr 15, 2024
@acdlite @AndyPengc12
Rename "shared subset" to "server" (facebook#27939)
128e936 
The internal file ReactSharedSubset is what the `react` module resolves
to when imported from a Server Component environment. We gave it this
name because, originally, the idea was that Server Components can access
a subset of the APIs available on the client.

However, since then, we've also added APIs that can _only_ by accessed
on the server and not the client. In other words, it's no longer a
subset, it's a slightly different overlapping set.

So this commit renames ReactSharedSubet to ReactServer and updates all
the references. This does not affect the public API, only our internal
implementation.
bigfootjon pushed a commit that referenced this pull request Apr 18, 2024
@acdlite
Rename "shared subset" to "server" (#27939)
e16614f 
The internal file ReactSharedSubset is what the `react` module resolves
to when imported from a Server Component environment. We gave it this
name because, originally, the idea was that Server Components can access
a subset of the APIs available on the client.

However, since then, we've also added APIs that can _only_ by accessed
on the server and not the client. In other words, it's no longer a
subset, it's a slightly different overlapping set.

So this commit renames ReactSharedSubet to ReactServer and updates all
the references. This does not affect the public API, only our internal
implementation.

DiffTrain build for commit 5d1b15a.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gnoff gnoff gnoff approved these changes

@sebmarkbage sebmarkbage Awaiting requested review from sebmarkbage

Assignees
No one assigned
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@acdlite @react-sizebot @gnoff @facebook-github-bot