Capture React.startTransition errors and pass to reportError #28111

acdlite · 2024-01-26T16:18:33Z

To make React.startTransition more consistent with the hook form of startTransition, we capture errors thrown by the scope function and pass them to the global reportError function. (This is also what we do as a default for onRecoverableError.)

This is a breaking change because it means that errors inside of startTransition will no longer bubble up to the caller. You can still catch the error by putting a try/catch block inside of the scope function itself.

We do the same for async actions to prevent "unhandled promise rejection" warnings.

The motivation is to avoid a refactor hazard when changing from a sync to an async action, or from useTransition to startTransition.

acdlite · 2024-01-26T16:19:07Z

packages/react-reconciler/src/ReactFiberTransition.js

-    returnValue !== null &&
-    typeof returnValue === 'object' &&
-    typeof returnValue.then === 'function'
-  ) {


I hoisted this type check into startTransition

react-sizebot · 2024-01-26T16:22:29Z

Comparing: 6c64428...039a599

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name	+/-	Base	Current	+/- gzip	Base gzip	Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js	=	176.64 kB	176.58 kB	=	55.01 kB	55.01 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js	=	178.74 kB	178.69 kB	=	55.64 kB	55.64 kB
facebook-www/ReactDOM-prod.classic.js	=	573.66 kB	573.52 kB	=	101.02 kB	100.99 kB
facebook-www/ReactDOM-prod.modern.js	=	557.42 kB	557.28 kB	=	98.10 kB	98.07 kB
facebook-www/ReactServer-prod.modern.js	+4.40%	14.46 kB	15.10 kB	+3.30%	3.88 kB	4.01 kB
facebook-www/React-prod.modern.js	+3.57%	17.78 kB	18.42 kB	+3.03%	4.58 kB	4.72 kB
facebook-www/React-prod.classic.js	+3.51%	18.08 kB	18.71 kB	+2.94%	4.66 kB	4.80 kB
facebook-www/React-profiling.modern.js	+3.48%	18.22 kB	18.85 kB	+3.07%	4.66 kB	4.80 kB
facebook-www/React-profiling.classic.js	+3.43%	18.51 kB	19.14 kB	+2.86%	4.75 kB	4.88 kB
oss-stable-semver/react/cjs/react.react-server.production.min.js	+2.62%	6.94 kB	7.12 kB	+1.90%	2.95 kB	3.00 kB
oss-stable/react/cjs/react.react-server.production.min.js	+2.61%	6.96 kB	7.15 kB	+1.88%	2.97 kB	3.03 kB
oss-stable-semver/react/cjs/react.react-server.production.js	+2.48%	29.07 kB	29.79 kB	+2.49%	8.72 kB	8.94 kB
oss-stable/react/cjs/react.react-server.production.js	+2.48%	29.09 kB	29.81 kB	+2.48%	8.75 kB	8.97 kB
oss-stable-semver/react/cjs/react.production.min.js	+2.48%	7.34 kB	7.52 kB	+2.30%	2.83 kB	2.89 kB
oss-stable/react/cjs/react.production.min.js	+2.47%	7.37 kB	7.55 kB	+2.24%	2.85 kB	2.92 kB
oss-stable-semver/react/cjs/react.production.js	+2.27%	31.77 kB	32.49 kB	+2.63%	9.05 kB	9.29 kB
oss-stable/react/cjs/react.production.js	+2.27%	31.80 kB	32.52 kB	+2.62%	9.08 kB	9.32 kB
oss-experimental/react/cjs/react.production.min.js	+2.09%	8.84 kB	9.02 kB	+2.03%	3.30 kB	3.37 kB
test_utils/ReactAllWarnings.js	Deleted	67.55 kB	0.00 kB	Deleted	16.54 kB	0.00 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show

Name	+/-	Base	Current	+/- gzip	Base gzip	Current gzip
facebook-www/ReactServer-prod.modern.js	+4.40%	14.46 kB	15.10 kB	+3.30%	3.88 kB	4.01 kB
facebook-www/React-prod.modern.js	+3.57%	17.78 kB	18.42 kB	+3.03%	4.58 kB	4.72 kB
facebook-www/React-prod.classic.js	+3.51%	18.08 kB	18.71 kB	+2.94%	4.66 kB	4.80 kB
facebook-www/React-profiling.modern.js	+3.48%	18.22 kB	18.85 kB	+3.07%	4.66 kB	4.80 kB
facebook-www/React-profiling.classic.js	+3.43%	18.51 kB	19.14 kB	+2.86%	4.75 kB	4.88 kB
oss-stable-semver/react/cjs/react.react-server.production.min.js	+2.62%	6.94 kB	7.12 kB	+1.90%	2.95 kB	3.00 kB
oss-stable/react/cjs/react.react-server.production.min.js	+2.61%	6.96 kB	7.15 kB	+1.88%	2.97 kB	3.03 kB
oss-stable-semver/react/cjs/react.react-server.production.js	+2.48%	29.07 kB	29.79 kB	+2.49%	8.72 kB	8.94 kB
oss-stable/react/cjs/react.react-server.production.js	+2.48%	29.09 kB	29.81 kB	+2.48%	8.75 kB	8.97 kB
oss-stable-semver/react/cjs/react.production.min.js	+2.48%	7.34 kB	7.52 kB	+2.30%	2.83 kB	2.89 kB
oss-stable/react/cjs/react.production.min.js	+2.47%	7.37 kB	7.55 kB	+2.24%	2.85 kB	2.92 kB
oss-stable-semver/react/cjs/react.production.js	+2.27%	31.77 kB	32.49 kB	+2.63%	9.05 kB	9.29 kB
oss-stable/react/cjs/react.production.js	+2.27%	31.80 kB	32.52 kB	+2.62%	9.08 kB	9.32 kB
oss-experimental/react/cjs/react.production.min.js	+2.09%	8.84 kB	9.02 kB	+2.03%	3.30 kB	3.37 kB
oss-experimental/react/cjs/react.production.js	+1.98%	36.41 kB	37.14 kB	+2.39%	10.06 kB	10.30 kB
oss-experimental/react/cjs/react.react-server.production.min.js	+1.97%	9.46 kB	9.65 kB	+1.44%	3.81 kB	3.87 kB
oss-experimental/react/cjs/react.react-server.production.js	+1.95%	37.07 kB	37.79 kB	+2.01%	10.90 kB	11.12 kB
oss-stable-semver/react/umd/react.profiling.min.js	+1.67%	11.13 kB	11.31 kB	+1.42%	4.37 kB	4.43 kB
oss-stable-semver/react/umd/react.production.min.js	+1.67%	11.13 kB	11.31 kB	+1.44%	4.37 kB	4.43 kB
oss-stable/react/umd/react.profiling.min.js	+1.67%	11.15 kB	11.34 kB	+1.41%	4.39 kB	4.45 kB
oss-stable/react/umd/react.production.min.js	+1.67%	11.15 kB	11.34 kB	+1.44%	4.39 kB	4.45 kB
oss-experimental/react/umd/react.profiling.min.js	+1.48%	12.57 kB	12.75 kB	+1.18%	4.83 kB	4.89 kB
oss-experimental/react/umd/react.production.min.js	+1.48%	12.57 kB	12.75 kB	+1.18%	4.83 kB	4.89 kB
facebook-www/ReactServer-dev.modern.js	+1.35%	108.32 kB	109.78 kB	+1.33%	26.34 kB	26.69 kB
oss-stable-semver/react/cjs/react.react-server.development.js	+1.13%	77.56 kB	78.44 kB	+1.18%	21.44 kB	21.70 kB
oss-stable/react/cjs/react.react-server.development.js	+1.13%	77.59 kB	78.46 kB	+1.18%	21.47 kB	21.73 kB
facebook-www/React-dev.modern.js	+1.05%	139.55 kB	141.02 kB	+0.94%	34.05 kB	34.37 kB
facebook-www/React-dev.classic.js	+1.04%	140.77 kB	142.24 kB	+0.94%	34.29 kB	34.62 kB
oss-experimental/react/cjs/react.react-server.development.js	+1.01%	86.71 kB	87.58 kB	+1.00%	24.09 kB	24.33 kB
oss-stable-semver/react/cjs/react.development.js	+0.88%	99.00 kB	99.87 kB	+0.88%	26.67 kB	26.90 kB
oss-stable/react/cjs/react.development.js	+0.88%	99.03 kB	99.90 kB	+0.89%	26.70 kB	26.93 kB
oss-experimental/react/cjs/react.development.js	+0.84%	104.41 kB	105.29 kB	+0.79%	27.90 kB	28.12 kB
oss-stable-semver/react/umd/react.development.js	+0.75%	121.90 kB	122.81 kB	+0.76%	31.33 kB	31.57 kB
oss-stable/react/umd/react.development.js	+0.75%	121.93 kB	122.84 kB	+0.76%	31.36 kB	31.60 kB
oss-experimental/react/umd/react.development.js	+0.71%	127.65 kB	128.56 kB	+0.68%	32.63 kB	32.85 kB
facebook-react-native/react/cjs/React-dev.js	+0.46%	128.36 kB	128.96 kB	+0.57%	31.10 kB	31.28 kB
facebook-react-native/react/cjs/React-profiling.js	=	17.95 kB	17.87 kB	+0.02%	4.63 kB	4.63 kB
facebook-react-native/react/cjs/React-prod.js	=	17.81 kB	17.73 kB	=	4.63 kB	4.63 kB
test_utils/ReactAllWarnings.js	Deleted	67.55 kB	0.00 kB	Deleted	16.54 kB	0.00 kB

Generated by 🚫 dangerJS against 039a599

To make React.startTransition more consistent with the hook form of startTransition, we capture errors thrown by the scope function and pass them to the global reportError function. (This is also what we do as a default for onRecoverableError.) This is a breaking change because it means that errors inside of startTransition will no longer bubble up to the caller. You can still catch the error by putting a try/catch block inside of the scope function itself. We do the same for async actions to prevent "unhandled promise rejection" warnings. The motivation is to avoid a refactor hazard when changing from a sync to an async action, or from useTransition to startTransition.

To make React.startTransition more consistent with the hook form of startTransition, we capture errors thrown by the scope function and pass them to the global reportError function. (This is also what we do as a default for onRecoverableError.) This is a breaking change because it means that errors inside of startTransition will no longer bubble up to the caller. You can still catch the error by putting a try/catch block inside of the scope function itself. We do the same for async actions to prevent "unhandled promise rejection" warnings. The motivation is to avoid a refactor hazard when changing from a sync to an async action, or from useTransition to startTransition. DiffTrain build for [60f190a](60f190a)

…k#28111) To make React.startTransition more consistent with the hook form of startTransition, we capture errors thrown by the scope function and pass them to the global reportError function. (This is also what we do as a default for onRecoverableError.) This is a breaking change because it means that errors inside of startTransition will no longer bubble up to the caller. You can still catch the error by putting a try/catch block inside of the scope function itself. We do the same for async actions to prevent "unhandled promise rejection" warnings. The motivation is to avoid a refactor hazard when changing from a sync to an async action, or from useTransition to startTransition.

To make React.startTransition more consistent with the hook form of startTransition, we capture errors thrown by the scope function and pass them to the global reportError function. (This is also what we do as a default for onRecoverableError.) This is a breaking change because it means that errors inside of startTransition will no longer bubble up to the caller. You can still catch the error by putting a try/catch block inside of the scope function itself. We do the same for async actions to prevent "unhandled promise rejection" warnings. The motivation is to avoid a refactor hazard when changing from a sync to an async action, or from useTransition to startTransition. DiffTrain build for commit 60f190a.

facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Jan 26, 2024

acdlite commented Jan 26, 2024

View reviewed changes

acdlite force-pushed the startTransition-error-handling branch 2 times, most recently from 63f6dec to 3a5e7fc Compare January 26, 2024 16:29

acdlite force-pushed the startTransition-error-handling branch from 3a5e7fc to 039a599 Compare January 26, 2024 16:30

acdlite marked this pull request as ready for review January 26, 2024 16:36

sebmarkbage approved these changes Jan 26, 2024

View reviewed changes

unstubbable mentioned this pull request Jan 26, 2024

Try useOptimistic with useFormState and progressive enhancement unstubbable/mfng#38

Closed

acdlite merged commit 60f190a into facebook:main Jan 26, 2024
36 checks passed

gnoff mentioned this pull request Feb 1, 2024

Update React from 60a927d04 to 2bc7d336a vercel/next.js#61522

Merged

ztanner mentioned this pull request Mar 19, 2024

(backport) Update React from 60a927d04 to 14898b6a9 vercel/next.js#63442

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Capture React.startTransition errors and pass to reportError #28111

Capture React.startTransition errors and pass to reportError #28111

acdlite commented Jan 26, 2024

acdlite Jan 26, 2024

react-sizebot commented Jan 26, 2024 •

edited

Loading

Capture React.startTransition errors and pass to reportError #28111

Capture React.startTransition errors and pass to reportError #28111

Conversation

acdlite commented Jan 26, 2024

acdlite Jan 26, 2024

Choose a reason for hiding this comment

react-sizebot commented Jan 26, 2024 • edited Loading

Critical size changes

Significant size changes

react-sizebot commented Jan 26, 2024 •

edited

Loading