Always warn if client component suspends with an uncached promise #28159

acdlite · 2024-01-30T18:01:30Z

Previously we only warned during a synchronous update, because we eventually want to support async client components in controlled scenarios, like during navigations. However, we're going to warn in all cases for now until we figure out how that should work.

We do not yet support async/await on the client. You can only unwrap a promise that was passed from a Server Component, or a Suspense-compatible framework like Relay.

react-sizebot · 2024-01-30T18:06:14Z

Comparing: 2477384...54b1617

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name	+/-	Base	Current	+/- gzip	Base gzip	Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js	=	176.59 kB	176.59 kB	=	55.01 kB	55.01 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js	=	178.69 kB	178.69 kB	=	55.64 kB	55.64 kB
facebook-www/ReactDOM-prod.classic.js	=	573.52 kB	573.52 kB	=	100.99 kB	100.99 kB
facebook-www/ReactDOM-prod.modern.js	=	557.29 kB	557.29 kB	=	98.07 kB	98.07 kB
test_utils/ReactAllWarnings.js	Deleted	67.55 kB	0.00 kB	Deleted	16.54 kB	0.00 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show

Name	+/-	Base	Current	+/- gzip	Base gzip	Current gzip
test_utils/ReactAllWarnings.js	Deleted	67.55 kB	0.00 kB	Deleted	16.54 kB	0.00 kB

Generated by 🚫 dangerJS against 54b1617

…8159) Previously we only warned during a synchronous update, because we eventually want to support async client components in controlled scenarios, like during navigations. However, we're going to warn in all cases for now until we figure out how that should work. DiffTrain build for [178f435](178f435)

…8159) Previously we only warned during a synchronous update, because we eventually want to support async client components in controlled scenarios, like during navigations. However, we're going to warn in all cases for now until we figure out how that should work.

…cebook#28159) Previously we only warned during a synchronous update, because we eventually want to support async client components in controlled scenarios, like during navigations. However, we're going to warn in all cases for now until we figure out how that should work.

…8159) Previously we only warned during a synchronous update, because we eventually want to support async client components in controlled scenarios, like during navigations. However, we're going to warn in all cases for now until we figure out how that should work. DiffTrain build for commit 178f435.

acdlite added 2 commits January 30, 2024 13:00

Warn if uncached promise suspends during render

54b1617

We do not yet support async/await on the client. You can only unwrap a promise that was passed from a Server Component, or a Suspense-compatible framework like Relay.

facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Jan 30, 2024

gsathya approved these changes Jan 30, 2024

View reviewed changes

acdlite merged commit 178f435 into facebook:main Jan 30, 2024
36 checks passed

gnoff mentioned this pull request Feb 1, 2024

Update React from 60a927d04 to 2bc7d336a vercel/next.js#61522

Merged

ztanner mentioned this pull request Mar 19, 2024

(backport) Update React from 60a927d04 to 14898b6a9 vercel/next.js#63442

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Always warn if client component suspends with an uncached promise #28159

Always warn if client component suspends with an uncached promise #28159

acdlite commented Jan 30, 2024

react-sizebot commented Jan 30, 2024

Always warn if client component suspends with an uncached promise #28159

Always warn if client component suspends with an uncached promise #28159

Conversation

acdlite commented Jan 30, 2024

react-sizebot commented Jan 30, 2024

Critical size changes

Significant size changes