Fix PHPUnit 11 compatibility #230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ok it seems that if I run the PR, the auth for the forks work. Still, no PHPUnit 11. I'll try to add an additional CI job to forcibly test for it. |
Closed
This was referenced Feb 4, 2024
Closed
Jean85
force-pushed
the
allow-phpunit-11-bis
branch
from
fda815c
to
d1eab15
Compare
Jean85
force-pushed
the
allow-phpunit-11-bis
branch
2 times, most recently
from
6e70707
to
e0be898
Compare
2 tasks
Jean85
force-pushed
the
allow-phpunit-11-bis
branch
2 times, most recently
from
34452d5
to
eda6ca0
Compare
Jean85
force-pushed
the
allow-phpunit-11-bis
branch
from
eda6ca0
to
2c48e55
Compare
Jean85
force-pushed
the
allow-phpunit-11-bis
branch
from
2c48e55
to
d1302ed
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR started from #229 because we need additional permissions to have a secret PAT to download forks with Composer.
This fix is needed because #228 didn't actually execute with PHPUnit 11 since there were conflicting requirements, Prophecy in particular.