Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: revert k256 bump (again) #6969

Merged
merged 1 commit into from
Jan 31, 2024
Merged

chore: revert k256 bump (again) #6969

merged 1 commit into from
Jan 31, 2024

Conversation

DaniPopes
Copy link
Member

@DaniPopes DaniPopes commented Jan 31, 2024 •
edited
Loading

Related #6358
Closes #6966

Nice

@DaniPopes DaniPopes marked this pull request as draft January 31, 2024 17:28
@DaniPopes DaniPopes marked this pull request as ready for review January 31, 2024 17:59
gakonst
gakonst approved these changes Jan 31, 2024
View reviewed changes
Copy link
Member

@gakonst gakonst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is a low-s value right?

@DaniPopes
Copy link
Member Author

Yes

@DaniPopes DaniPopes merged commit b8b234d into master Jan 31, 2024
20 checks passed
@DaniPopes DaniPopes deleted the dani/k256 branch January 31, 2024 18:25
This was referenced Apr 26, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gakonst gakonst gakonst approved these changes

@Evalir Evalir Awaiting requested review from Evalir

@mattsse mattsse Awaiting requested review from mattsse mattsse is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Discrepancy in ecrecover
2 participants
@DaniPopes @gakonst