Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: remove pandas dependency #27047

Closed
3 tasks done
ankush opened this issue Aug 19, 2021 · 0 comments · Fixed by #30598
Closed
3 tasks done

refactor: remove pandas dependency #27047

ankush opened this issue Aug 19, 2021 · 0 comments · Fixed by #30598
Assignees
@ankush
Labels
valid
Milestone
v14.0

Comments

@ankush
Copy link
Member

ankush commented Aug 19, 2021 •
edited
Loading

Currently, only 2 functionalities in ERPNext use pandas:

  • Sales funnel (which does JUST 1 transformation using pandas, this usage is seriously a crutch)
  • German tax reports (DATEV)

I am proposing to refactor and remove this dependency because:

  • It's a huge library (35+ MB) and comes with a lot of transitive dependencies.
  • It has caused many installation failures in past and most newbies can't figure out why. This has improved a lot in recent years as NumPy and Pandas packaging has improved, but still, this will always cause some mess IMO.

Cons:

  • It's actually quite expressive and useful in reports. It's just that not many seem to be using it.

TODO:
@ankush ankush added to-validate Old issues pending validation valid and removed to-validate Old issues pending validation labels Dec 10, 2021
@ankush ankush mentioned this issue Jan 10, 2022
Merged
@ankush ankush removed the discussion label Jan 24, 2022
@ankush ankush added this to the v14.0 milestone Jan 24, 2022
@ankush ankush self-assigned this Apr 6, 2022
This was referenced Apr 6, 2022
Merged
Merged
@mergify mergify bot closed this as completed in #30598 Apr 13, 2022
mergify bot pushed a commit that referenced this issue Apr 13, 2022
@ankush
chore(deps)!: Drop pandas as dependency (#30598)
0f09042 
depends on #30597
depends on #30584 


Closes #27047 (read for more details)
@sagarvora sagarvora mentioned this issue Jul 17, 2022
Merged
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@ankush ankush

Labels
valid
Projects
None yet
Milestone
v14.0
Development

Successfully merging a pull request may close this issue.

chore(deps)!: Drop pandas as dependency ankush/erpnext
1 participant
@ankush