Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps)!: Drop pandas as dependency #30598

Merged
merged 3 commits into from
Apr 13, 2022
Merged

Conversation

ankush
Copy link
Member

@ankush ankush commented Apr 6, 2022

depends on #30597
depends on #30584

Closes #27047 (read for more details)

@ankush ankush requested a review from gavindsouza as a code owner April 6, 2022 09:52
@ankush ankush marked this pull request as draft April 6, 2022 09:52
@ankush ankush added this to the v14.0 milestone Apr 6, 2022
@sagarvora
Copy link
Collaborator

sagarvora commented Apr 7, 2022

Pandas took 500M * number of Gunicorn workers (I've seen 17 on sites) in RAM, so great job removing it! Have been thinking about it for a while now. Another one on my list is openpyxl (this takes ~400M RAM per worker). I'm planning to replace it with pylightxl and xlsxwriter (both of these have no dependencies - they use the standard library)

@ankush ankush mentioned this pull request Apr 8, 2022
3 tasks
ankush added a commit to ankush/erpnext_datev that referenced this pull request Apr 13, 2022
ERPNext will drop this dependency in next release

frappe/erpnext#30598
barredterra pushed a commit to alyf-de/erpnext_datev that referenced this pull request Apr 13, 2022
ERPNext will drop this dependency in next release

frappe/erpnext#30598
@ankush ankush marked this pull request as ready for review April 13, 2022 09:33
@ankush ankush added the squash Meant to tell reviewers that this PR should be squashed into a single commit while merging. label Apr 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
squash Meant to tell reviewers that this PR should be squashed into a single commit while merging.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

refactor: remove pandas dependency
3 participants