Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: don't use pandas for basic reports #30597

Merged
merged 1 commit into from
Apr 6, 2022
Merged

refactor: don't use pandas for basic reports #30597

merged 1 commit into from
Apr 6, 2022

Conversation

ankush
Copy link
Member

@ankush ankush commented Apr 6, 2022 •
edited
Loading

related: #27047

This PR removes all pandas usage from core ERPNext... will drop pandas in separate PR after datev is moved to a separate app.

@github-actions github-actions bot added the needs-tests This PR needs automated unit-tests. label Apr 6, 2022
@ankush ankush removed the needs-tests This PR needs automated unit-tests. label Apr 6, 2022
This was referenced Apr 6, 2022
Closed
Merged
@ankush ankush merged commit ba42c87 into frappe:develop Apr 6, 2022
@ankush ankush deleted the pandas_begone branch April 6, 2022 10:10
mergify bot pushed a commit that referenced this pull request Apr 13, 2022
@ankush
chore(deps)!: Drop pandas as dependency (#30598)
0f09042 
depends on #30597
depends on #30584 


Closes #27047 (read for more details)
@deepeshgarg007 deepeshgarg007 mentioned this pull request Jul 18, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ruchamahabal ruchamahabal Awaiting requested review from ruchamahabal

@pateljannat pateljannat Awaiting requested review from pateljannat

@nextchamp-saqib nextchamp-saqib Awaiting requested review from nextchamp-saqib

@deepeshgarg007 deepeshgarg007 Awaiting requested review from deepeshgarg007 deepeshgarg007 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ankush