-
Notifications
You must be signed in to change notification settings - Fork 7.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: enqueue_after_commit
wherever it makes sense
#35588
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ankush
requested review from
rohitwaghchaure,
s-aga-r,
deepeshgarg007 and
ruthra-kumar
as code owners
June 7, 2023 05:43
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #35588 +/- ##
===========================================
- Coverage 63.92% 63.92% -0.01%
===========================================
Files 812 812
Lines 61792 61810 +18
===========================================
+ Hits 39501 39511 +10
- Misses 22291 22299 +8
|
mergify bot
pushed a commit
that referenced
this pull request
Jun 7, 2023
(cherry picked from commit 4507cb3)
frappe-pr-bot
pushed a commit
that referenced
this pull request
Jun 14, 2023
## [14.27.2](v14.27.1...v14.27.2) (2023-06-14) ### Bug Fixes * `enqueue_after_commit` wherever it makes sense (backport [#35588](#35588)) ([#35590](#35590)) ([e505516](e505516)) * `TypeError` in Closing Stock Balance ([32e5bbb](32e5bbb)) * **accounts:** validate payment entry references with latest data. ([#31166](#31166)) ([4add1b4](4add1b4)) * added process loss in job card ([6a21d61](6a21d61)) * allow user to set rounding loss allowance for accounts balance ([cf14858](cf14858)) * attribute error on payment reconciliation tool ([25b3c77](25b3c77)) * based on status_update.py update opportunity status to converted… ([#35145](#35145)) ([dee8275](dee8275)) * calculate wdv depr schedule properly for existing assets [v14] ([#35613](#35613)) ([feb5d00](feb5d00)) * conflicts ([2060a00](2060a00)) * CSS not applied to product title ([#35630](#35630)) ([2cf871c](2cf871c)) * don't set default payment amount in case of invoice return ([#35645](#35645)) ([79483cc](79483cc)) * Lower deduction certificate not getting applied ([#35667](#35667)) ([6f59fa9](6f59fa9)) * Make difference entry button not working ([#35622](#35622)) ([043815e](043815e)) * make showing taxes as table in print configurable (backport [#35672](#35672)) ([#35678](#35678)) ([f39ae9d](f39ae9d)) * Payment against credit notes will be considered as payment against parent invoice in Accounts Receivable/Payable report ([#35642](#35642)) ([81ef2ba](81ef2ba)) * Project in item-wise sales register ([#35596](#35596)) ([7737b90](7737b90)) * Stock Reconciliation document update while reposting ([8b617fb](8b617fb)) * test case ([7af0380](7af0380)) * Update de.csv ([#35278](#35278)) ([2077f6e](2077f6e)) * Validation for delivery date in Sales Order ([#35597](#35597)) ([4a8ce22](4a8ce22))
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Immediately enqueueing the background jobs doesn't make sense if change gets rolled-back, hence prefer enqueueing after committing.