Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Validation for delivery date in Sales Order #35597

Merged
merged 6 commits into from
Jun 13, 2023

Conversation

deepeshgarg007
Copy link
Member

No description provided.

@github-actions github-actions bot added the needs-tests This PR needs automated unit-tests. label Jun 7, 2023
@deepeshgarg007 deepeshgarg007 added the backport version-14-hotfix backport to version 14 label Jun 11, 2023
@codecov
Copy link

codecov bot commented Jun 13, 2023

Codecov Report

Merging #35597 (799c432) into develop (a3ea985) will increase coverage by 0.16%.
The diff coverage is 90.47%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #35597      +/-   ##
===========================================
+ Coverage    63.94%   64.11%   +0.16%     
===========================================
  Files          811      811              
  Lines        61856    61872      +16     
===========================================
+ Hits         39554    39669     +115     
+ Misses       22302    22203      -99     
Impacted Files Coverage Δ
erpnext/selling/doctype/sales_order/sales_order.py 77.38% <ø> (-0.30%) ⬇️
...xt/accounts/doctype/payment_entry/payment_entry.py 84.01% <89.47%> (+9.39%) ⬆️
erpnext/selling/doctype/quotation/quotation.py 61.22% <100.00%> (+0.31%) ⬆️

... and 2 files with indirect coverage changes

@deepeshgarg007 deepeshgarg007 merged commit 984f89d into frappe:develop Jun 13, 2023
mergify bot pushed a commit that referenced this pull request Jun 13, 2023
* fix: Validation for delivery date in Sales Order

* chore: update utils

* chore: revert

* chore: Add default delivery date

(cherry picked from commit 984f89d)
deepeshgarg007 added a commit that referenced this pull request Jun 14, 2023
fix: Validation for delivery date in Sales Order (#35597)

* fix: Validation for delivery date in Sales Order

* chore: update utils

* chore: revert

* chore: Add default delivery date

(cherry picked from commit 984f89d)

Co-authored-by: Deepesh Garg <deepeshgarg6@gmail.com>
frappe-pr-bot pushed a commit that referenced this pull request Jun 14, 2023
## [14.27.2](v14.27.1...v14.27.2) (2023-06-14)

### Bug Fixes

* `enqueue_after_commit` wherever it makes sense (backport [#35588](#35588)) ([#35590](#35590)) ([e505516](e505516))
* `TypeError` in Closing Stock Balance ([32e5bbb](32e5bbb))
* **accounts:** validate payment entry references with latest data. ([#31166](#31166)) ([4add1b4](4add1b4))
* added process loss in job card ([6a21d61](6a21d61))
* allow user to set rounding loss allowance for accounts balance ([cf14858](cf14858))
* attribute error on payment reconciliation tool ([25b3c77](25b3c77))
* based on status_update.py update opportunity status to converted… ([#35145](#35145)) ([dee8275](dee8275))
* calculate wdv depr schedule properly for existing assets [v14] ([#35613](#35613)) ([feb5d00](feb5d00))
* conflicts ([2060a00](2060a00))
* CSS not applied to product title ([#35630](#35630)) ([2cf871c](2cf871c))
* don't set default payment amount in case of invoice return ([#35645](#35645)) ([79483cc](79483cc))
* Lower deduction certificate not getting applied ([#35667](#35667)) ([6f59fa9](6f59fa9))
* Make difference entry button not working ([#35622](#35622)) ([043815e](043815e))
* make showing taxes as table in print configurable (backport [#35672](#35672)) ([#35678](#35678)) ([f39ae9d](f39ae9d))
* Payment against credit notes will be considered as payment against parent invoice in Accounts Receivable/Payable report ([#35642](#35642)) ([81ef2ba](81ef2ba))
* Project in item-wise sales register ([#35596](#35596)) ([7737b90](7737b90))
* Stock Reconciliation document update while reposting ([8b617fb](8b617fb))
* test case ([7af0380](7af0380))
* Update de.csv ([#35278](#35278)) ([2077f6e](2077f6e))
* Validation for delivery date in Sales Order ([#35597](#35597)) ([4a8ce22](4a8ce22))
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport version-14-hotfix backport to version 14 needs-tests This PR needs automated unit-tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant