fix: don't set default payment amount in case of invoice return #35645
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anandbaburajan
added
backport version-13-hotfix
backport develop
mergify bot
pushed a commit
that referenced
this pull request
Jun 12, 2023
(cherry picked from commit 79483cc)
mergify bot
pushed a commit
that referenced
this pull request
Jun 12, 2023
(cherry picked from commit 79483cc) # Conflicts: # erpnext/public/js/controllers/taxes_and_totals.js
This was referenced Jun 12, 2023
anandbaburajan
added a commit
that referenced
this pull request
Jun 12, 2023
frappe-pr-bot
pushed a commit
that referenced
this pull request
Jun 14, 2023
## [14.27.2](v14.27.1...v14.27.2) (2023-06-14) ### Bug Fixes * `enqueue_after_commit` wherever it makes sense (backport [#35588](#35588)) ([#35590](#35590)) ([e505516](e505516)) * `TypeError` in Closing Stock Balance ([32e5bbb](32e5bbb)) * **accounts:** validate payment entry references with latest data. ([#31166](#31166)) ([4add1b4](4add1b4)) * added process loss in job card ([6a21d61](6a21d61)) * allow user to set rounding loss allowance for accounts balance ([cf14858](cf14858)) * attribute error on payment reconciliation tool ([25b3c77](25b3c77)) * based on status_update.py update opportunity status to converted… ([#35145](#35145)) ([dee8275](dee8275)) * calculate wdv depr schedule properly for existing assets [v14] ([#35613](#35613)) ([feb5d00](feb5d00)) * conflicts ([2060a00](2060a00)) * CSS not applied to product title ([#35630](#35630)) ([2cf871c](2cf871c)) * don't set default payment amount in case of invoice return ([#35645](#35645)) ([79483cc](79483cc)) * Lower deduction certificate not getting applied ([#35667](#35667)) ([6f59fa9](6f59fa9)) * Make difference entry button not working ([#35622](#35622)) ([043815e](043815e)) * make showing taxes as table in print configurable (backport [#35672](#35672)) ([#35678](#35678)) ([f39ae9d](f39ae9d)) * Payment against credit notes will be considered as payment against parent invoice in Accounts Receivable/Payable report ([#35642](#35642)) ([81ef2ba](81ef2ba)) * Project in item-wise sales register ([#35596](#35596)) ([7737b90](7737b90)) * Stock Reconciliation document update while reposting ([8b617fb](8b617fb)) * test case ([7af0380](7af0380)) * Update de.csv ([#35278](#35278)) ([2077f6e](2077f6e)) * Validation for delivery date in Sales Order ([#35597](#35597)) ([4a8ce22](4a8ce22))
|
🎉 This PR is included in version 14.27.2 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
frappe-pr-bot
pushed a commit
that referenced
this pull request
Jun 14, 2023
## [13.51.2](v13.51.1...v13.51.2) (2023-06-14) ### Bug Fixes * **accounts:** validate payment entry references with latest data. (backport [#31166](#31166)) ([#35674](#35674)) ([4d4f218](4d4f218)) * Asset Depreciation Ledger Report - Add Total Row Checkbox Enabled ([3831c79](3831c79)) * calculate wdv depr schedule properly for existing assets [v13] ([#35615](#35615)) ([97f4af8](97f4af8)) * CSS not applied to product title (backport [#35582](#35582)) ([#35635](#35635)) ([1b69b37](1b69b37)) * don't set default payment amount in case of invoice return (backport [#35645](#35645)) ([#35648](#35648)) ([8e3636f](8e3636f)) * Lower deduction certificate not getting applied ([#35667](#35667)) ([c2bf8e3](c2bf8e3)) * make showing taxes as table in print configurable ([#35672](#35672)) ([4c2c037](4c2c037)) * Project in item-wise sales register ([#35596](#35596)) ([9d5b500](9d5b500)) * savepoint policy assignment submission, log errors & inform the user about failures ([#35507](#35507)) ([4a35ff0](4a35ff0)) ### Performance Improvements * refactor `get_all_nodes` in Org Chart ([986a90e](986a90e))
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the payment methods table of a POS profile:
So, when a POS invoice is created, the default method of cash is chosen and the respective amount is set. One user wanted to go with another method, such as wire transfer, in which case, the payments table of the invoice looks like:
Now the issue is that when a return for that POS invoice was created, the default method of cash is chosen along with the other method chosen for the original invoice:
