add an action to remove trailing spaces when opening a PR #551
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
TechQuery
suggested changes
Dec 10, 2024
| if [ -n "$file" ]; then | ||
| echo "Processing file: $file" | ||
| # Remove trailing spaces from each line in the file | ||
| sed -i 's/ $//g' "$file" |
There was a problem hiding this comment.
Suggested change
| sed -i 's/ $//g' "$file" | |
| pnpx prettier --write "$file" |
Prettier can fix all kinds of formatting issues including the tail spaces.
There was a problem hiding this comment.
Thank you for your comment, @TechQuery.
I think we eventually want to utilize Prettier for formatting, but what we are currently trying to do is a little different. We want to intentionally make changes to every lines just to make it easier for proofreaders to comment on any lines in PRs.
There might be a better solution, but let's try this way first.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist:
Update index.md)Remove extra trailing spaces from each line. This one, along with freeCodeCamp/articles-auto-translate-action#12, is made to solve the issue #550