Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(upgrade): v1.11.0 to v1.13.0 #2132

Merged
merged 1 commit into from
Sep 4, 2024
Merged

chore(upgrade): v1.11.0 to v1.13.0 #2132

merged 1 commit into from
Sep 4, 2024

Conversation

enddynayn
Copy link
Collaborator

@enddynayn enddynayn commented Aug 16, 2024 •
edited
Loading

@enddynayn enddynayn changed the title Chore/upgrade polkadot v1.11.0 to v1.13.0 issue 2025 chore(upgrade): upgrade polkadot v1.11.0 to v1.13.0 Aug 16, 2024
@enddynayn enddynayn force-pushed the chore/upgrade-polkadot-v1.11.0-to-v1.13.0-issue-2025 branch 2 times, most recently from d0479f9 to 3bbe0b8 Compare August 19, 2024 14:41
@codecov Codecov
Copy link

codecov bot commented Aug 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

@github-actions github-actions bot added metadata-changed Metadata has changed since the latest full release metadata-version-not-incremented Metadata has changed since the latest full release, but the version has not been incremented labels Aug 19, 2024
@enddynayn enddynayn force-pushed the chore/upgrade-polkadot-v1.11.0-to-v1.13.0-issue-2025 branch from 3bbe0b8 to b023185 Compare August 19, 2024 16:14
@github-actions github-actions bot removed metadata-changed Metadata has changed since the latest full release metadata-version-not-incremented Metadata has changed since the latest full release, but the version has not been incremented labels Aug 19, 2024
@enddynayn enddynayn force-pushed the chore/upgrade-polkadot-v1.11.0-to-v1.13.0-issue-2025 branch from b023185 to e03bfb2 Compare August 19, 2024 16:14
@enddynayn enddynayn changed the title chore(upgrade): upgrade polkadot v1.11.0 to v1.13.0 chore(upgrade): v1.11.0 to v1.13.0 Aug 19, 2024
@github-actions github-actions bot added the metadata-changed Metadata has changed since the latest full release label Aug 19, 2024
@enddynayn enddynayn force-pushed the chore/upgrade-polkadot-v1.11.0-to-v1.13.0-issue-2025 branch from 0862140 to ca0ed47 Compare August 19, 2024 18:55
@github-actions github-actions bot added metadata-changed Metadata has changed since the latest full release and removed metadata-changed Metadata has changed since the latest full release labels Aug 19, 2024
@enddynayn enddynayn force-pushed the chore/upgrade-polkadot-v1.11.0-to-v1.13.0-issue-2025 branch 3 times, most recently from 6bbac99 to 1fee438 Compare August 27, 2024 17:21
@github-actions github-actions bot added metadata-changed Metadata has changed since the latest full release metadata-version-not-incremented Metadata has changed since the latest full release, but the version has not been incremented and removed metadata-changed Metadata has changed since the latest full release metadata-version-not-incremented Metadata has changed since the latest full release, but the version has not been incremented labels Aug 27, 2024
@enddynayn enddynayn force-pushed the chore/upgrade-polkadot-v1.11.0-to-v1.13.0-issue-2025 branch from 0bc1c30 to 9cfffa4 Compare August 28, 2024 19:58
@github-actions github-actions bot removed the metadata-changed Metadata has changed since the latest full release label Aug 28, 2024
@enddynayn enddynayn force-pushed the chore/upgrade-polkadot-v1.11.0-to-v1.13.0-issue-2025 branch 2 times, most recently from eb27333 to d624673 Compare August 28, 2024 20:10
@github-actions github-actions bot added the metadata-changed Metadata has changed since the latest full release label Aug 29, 2024
JoeCap08055
JoeCap08055 approved these changes Aug 29, 2024
View reviewed changes
Copy link
Collaborator

@JoeCap08055 JoeCap08055 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Pulled branch
  • Built/ran unit tests
  • Ran e2e tests
  • Looks good!

aramikm
aramikm reviewed Aug 29, 2024
View reviewed changes
Copy link
Collaborator

@aramikm aramikm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great effort!. Added some comments and suggestions.

node/cli/src/benchmarking.rs Show resolved Hide resolved
node/service/src/chain_spec/frequency.rs Show resolved Hide resolved
node/service/src/service.rs Outdated Show resolved Hide resolved
node/service/src/service.rs Outdated Show resolved Hide resolved
runtime/common/src/constants.rs Outdated Show resolved Hide resolved
runtime/common/src/constants.rs Outdated Show resolved Hide resolved
runtime/common/src/constants.rs Show resolved Hide resolved
runtime/frequency/src/lib.rs Outdated Show resolved Hide resolved
@github-actions github-actions bot added metadata-changed Metadata has changed since the latest full release and removed metadata-changed Metadata has changed since the latest full release labels Aug 30, 2024
mattheworris
mattheworris reviewed Aug 30, 2024
View reviewed changes
README.md Outdated Show resolved Hide resolved
shannonwells
shannonwells approved these changes Aug 30, 2024
View reviewed changes
Copy link
Collaborator

@shannonwells shannonwells left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming all the CI checks out... nice work, that was a long row to hoe. My comments are just questions to make sure I understand - it looks like this upgrade allows async backing but we're not turning it on fully for mainnet, is that right?

runtime/frequency/src/lib.rs Show resolved Hide resolved
runtime/frequency/src/lib.rs Show resolved Hide resolved
scripts/init.sh Show resolved Hide resolved
scripts/js/onboard/onboard.mjs Show resolved Hide resolved
mattheworris
mattheworris approved these changes Aug 30, 2024
View reviewed changes
Copy link
Collaborator

@mattheworris mattheworris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Read through changes.

Nice work!

🚢 it!

@enddynayn enddynayn force-pushed the chore/upgrade-polkadot-v1.11.0-to-v1.13.0-issue-2025 branch from a054892 to 07c292e Compare September 4, 2024 13:48
@github-actions github-actions bot removed the metadata-changed Metadata has changed since the latest full release label Sep 4, 2024
@enddynayn enddynayn force-pushed the chore/upgrade-polkadot-v1.11.0-to-v1.13.0-issue-2025 branch 2 times, most recently from b0c8218 to 03c4ade Compare September 4, 2024 14:07
@github-actions github-actions bot added metadata-changed Metadata has changed since the latest full release metadata-version-not-incremented Metadata has changed since the latest full release, but the version has not been incremented labels Sep 4, 2024
@enddynayn enddynayn force-pushed the chore/upgrade-polkadot-v1.11.0-to-v1.13.0-issue-2025 branch from 03c4ade to f475528 Compare September 4, 2024 14:44
@github-actions github-actions bot added metadata-changed Metadata has changed since the latest full release and removed metadata-changed Metadata has changed since the latest full release metadata-version-not-incremented Metadata has changed since the latest full release, but the version has not been incremented labels Sep 4, 2024
aramikm
aramikm approved these changes Sep 4, 2024
View reviewed changes
Copy link
Collaborator

@aramikm aramikm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Ship It.

@github-actions github-actions bot added the metadata-changed Metadata has changed since the latest full release label Sep 4, 2024
@enddynayn
chore(upgrade): v1.11.0 to v1.13.0
e1534cf 
- Upgrade Polkadot-sdk 1.10.0 to 1.13.0
- Update weights to reflect the new version.1.13.0

Notable Changes:
Polkadot-sdk 1.12.0
- [Improve MockValidationDataInherentDataProvider to support async backing](paritytech/polkadot-sdk#4442)
- [Balances-Pallet add burn_allow_death extrinsic](paritytech/polkadot-sdk#3964)
- [Add Async Backing to Parachain Template](paritytech/polkadot-sdk#4295)

Polkadot-sdk 1.13.0
- [DeprecatedRuntimeGenesisConfig generic type parameter in GenericChainSpec struct](paritytech/polkadot-sdk#4410)
- [Move the `para_id` from `MockXcmConfig` to `MockValidationDataInherentDataProvider` to make it more prominent](paritytech/polkadot-sdk#4555)
- [Remove parameterized-consensus-hook feature](paritytech/polkadot-sdk#4380)

For more details, please refer to:
- [Polkadot-sdk release 1.12.0](https://github.com/paritytech/polkadot-sdk/releases/polkadot-v1.12.0)
- [Polkadot-sdk release 1.13.0](https://github.com/paritytech/polkadot-sdk/releases/polkadot-v1.13.0)
- [Async Backing](https://wiki.polkadot.network/docs/maintain-guides-async-backing)

issue-2025
issue-1983
@enddynayn enddynayn force-pushed the chore/upgrade-polkadot-v1.11.0-to-v1.13.0-issue-2025 branch from 60c4714 to e1534cf Compare September 4, 2024 21:51
@github-actions github-actions bot added metadata-changed Metadata has changed since the latest full release and removed metadata-changed Metadata has changed since the latest full release labels Sep 4, 2024
@enddynayn enddynayn merged commit c7859c5 into main Sep 4, 2024
27 checks passed
@enddynayn enddynayn deleted the chore/upgrade-polkadot-v1.11.0-to-v1.13.0-issue-2025 branch September 4, 2024 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoeCap08055 JoeCap08055 JoeCap08055 approved these changes

@aramikm aramikm aramikm approved these changes

@mattheworris mattheworris mattheworris approved these changes

@shannonwells shannonwells shannonwells approved these changes

@wilwade wilwade Awaiting requested review from wilwade wilwade is a code owner

@claireolmstead claireolmstead Awaiting requested review from claireolmstead

Assignees
No one assigned
Labels
metadata-changed Metadata has changed since the latest full release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@enddynayn @shannonwells @mattheworris @aramikm @JoeCap08055