`sc-chain-spec`: deprecated code removed #4410

michalkucharczyk · 2024-05-08T11:25:28Z

This PR removes deprecated code:

The RuntimeGenesisConfig generic type parameter in GenericChainSpec struct.
ChainSpec::from_genesis method allowing to create chain-spec using closure providing runtime genesis struct
GenesisSource::Factory variant together with no longer needed GenesisSource's generic parameter G (which was intended to be a runtime genesis struct).

polkadot-sdk/substrate/client/chain-spec/src/chain_spec.rs

Lines 559 to 563 in 17b56fa

    
           	#[deprecated( 
        
           		note = "`from_genesis` is planned to be removed in May 2024. Use `builder()` instead." 
        
           	)] 
        
           	// deprecated note: Genesis<G>::Runtime + GenesisSource::Factory shall also be removed 
        
           	pub fn from_genesis<F: Fn() -> G + 'static + Send + Sync>(

…ecated-code-removed

cumulus/polkadot-parachain/Cargo.toml

This reverts commit 02e9b6b.

paritytech-cicd-pr · 2024-05-27T11:20:42Z

The CI pipeline was cancelled due to failure one of the required jobs.
Job name: test-linux-stable 2/3
Logs: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/6308712

…ecated-code-removed

* master: (93 commits) Fix broken windows build (#4636) Beefy client generic on aduthority Id (#1816) pallet-staking: Put tests behind `cfg(debug_assertions)` (#4620) Broker new price adapter (#4521) Change `XcmDryRunApi::dry_run_extrinsic` to take a call instead (#4621) Update README.md (#4623) Publish `chain-spec-builder` (#4518) Add omni bencher & chain-spec-builder bins to release (#4557) Moves runtime macro out of experimental flag (#4249) Filter workspace dependencies in the templates (#4599) parachain-inherent: Make `para_id` more prominent (#4555) Add metric to measure the time it takes to gather enough assignments (#4587) Improve On_demand_assigner events (#4339) Conditional `required` checks (#4544) [CI] Deny adding git deps (#4572) [subsytem-bench] Remove redundant banchmark_name param (#4540) Add availability-recovery from systematic chunks (#1644) Remove workspace lints from templates (#4598) `sc-chain-spec`: deprecated code removed (#4410) [subsystem-benchmarks] Add statement-distribution benchmarks (#3863) ...

This PR removes deprecated code: - The `RuntimeGenesisConfig` generic type parameter in `GenericChainSpec` struct. - `ChainSpec::from_genesis` method allowing to create chain-spec using closure providing runtime genesis struct - `GenesisSource::Factory` variant together with no longer needed `GenesisSource`'s generic parameter `G` (which was intended to be a runtime genesis struct). https://github.com/paritytech/polkadot-sdk/blob/17b56fae2d976a3df87f34076875de8c26da0355/substrate/client/chain-spec/src/chain_spec.rs#L559-L563

- Upgrade Polkadot-sdk 1.10.0 to 1.13.0 - Update weights to reflect the new version.1.13.0 Notable Changes: Polkadot-sdk 1.12.0 - [Improve MockValidationDataInherentDataProvider to support async backing](paritytech/polkadot-sdk#4442) - [Balances-Pallet add burn_allow_death extrinsic](paritytech/polkadot-sdk#3964) - [Add Async Backing to Parachain Template](paritytech/polkadot-sdk#4295) Polkadot-sdk 1.13.0 - [DeprecatedRuntimeGenesisConfig generic type parameter in GenericChainSpec struct](paritytech/polkadot-sdk#4410) - [Move the `para_id` from `MockXcmConfig` to `MockValidationDataInherentDataProvider` to make it more prominent](paritytech/polkadot-sdk#4555) - [Remove parameterized-consensus-hook feature](paritytech/polkadot-sdk#4380) For more details, please refer to: - [Polkadot-sdk release 1.12.0](https://github.com/paritytech/polkadot-sdk/releases/polkadot-v1.12.0) - [Polkadot-sdk release 1.13.0](https://github.com/paritytech/polkadot-sdk/releases/polkadot-v1.13.0) - [Async Backing](https://wiki.polkadot.network/docs/maintain-guides-async-backing) issue-2025 issue-1983

- Upgrade Polkadot-sdk 1.10.0 to 1.13.0 - Update weights to reflect the new version.1.13.0 Notable Changes: Polkadot-sdk 1.12.0 - [Improve MockValidationDataInherentDataProvider to support async backing](paritytech/polkadot-sdk#4442) - [Balances-Pallet add burn_allow_death extrinsic](paritytech/polkadot-sdk#3964) - [Add Async Backing to Parachain Template](paritytech/polkadot-sdk#4295) Polkadot-sdk 1.13.0 - [DeprecatedRuntimeGenesisConfig generic type parameter in GenericChainSpec struct](paritytech/polkadot-sdk#4410) - [Move the `para_id` from `MockXcmConfig` to `MockValidationDataInherentDataProvider` to make it more prominent](paritytech/polkadot-sdk#4555) - [Remove parameterized-consensus-hook feature](paritytech/polkadot-sdk#4380) For more details, please refer to: - [Polkadot-sdk release 1.12.0](https://github.com/paritytech/polkadot-sdk/releases/polkadot-v1.12.0) - [Polkadot-sdk release 1.13.0](https://github.com/paritytech/polkadot-sdk/releases/polkadot-v1.13.0) - [Async Backing](https://wiki.polkadot.network/docs/maintain-guides-async-backing) #2025 #1983

sc-chain-spec: deprecated code removed

db61385

michalkucharczyk changed the title ~~sc-chain-spec: deprecated code removed~~ sc-chain-spec: deprecated code removed May 8, 2024

michalkucharczyk added the T0-node This PR/Issue is related to the topic “node”. label May 8, 2024

michalkucharczyk added 6 commits May 27, 2024 10:39

cleanup

de88dd9

Merge remote-tracking branch 'origin/master' into mku-chain-spec-depr…

ca9180a

…ecated-code-removed

bump versions

02e9b6b

prdoc

33c6a2a

clippy happy

f57d79e

Cargo.lock updated

43b0067

ggwpez reviewed May 27, 2024

View reviewed changes

cumulus/polkadot-parachain/Cargo.toml Outdated Show resolved Hide resolved

michalkucharczyk added 2 commits May 27, 2024 12:53

Revert "bump versions"

3dff76e

This reverts commit 02e9b6b.

Cargo.lock

aff3c4c

michalkucharczyk added 2 commits May 27, 2024 14:59

failing test reworked

172e760

Merge remote-tracking branch 'origin/master' into mku-chain-spec-depr…

b263b6e

…ecated-code-removed

michalkucharczyk marked this pull request as ready for review May 27, 2024 13:27

michalkucharczyk requested a review from andresilva as a code owner May 27, 2024 13:27

michalkucharczyk requested review from a team and removed request for andresilva May 27, 2024 13:28

lexnv approved these changes May 27, 2024

View reviewed changes

michalkucharczyk requested a review from a team May 27, 2024 19:15

bkchr approved these changes May 27, 2024

View reviewed changes

michalkucharczyk added this pull request to the merge queue May 27, 2024

Merged via the queue into master with commit 2d3a693 May 27, 2024
187 of 188 checks passed

michalkucharczyk deleted the mku-chain-spec-deprecated-code-removed branch May 27, 2024 21:56

chungquantin mentioned this pull request Aug 15, 2024

chore: upgrade to 1.13.0 r0gue-io/pop-node#194

Merged

enddynayn mentioned this pull request Aug 19, 2024

chore(upgrade): v1.11.0 to v1.13.0 frequency-chain/frequency#2132

Merged

This was referenced Aug 21, 2024

Update polkadot-sdk from v1.11.0 to stable2407 moondance-labs/tanssi#659

Open

Update polkadot-sdk from v1.11.0 to stable2407 moonbeam-foundation/moonbeam#2912

Open

magecnion added a commit to freeverseio/laos that referenced this pull request Sep 12, 2024

paritytech/polkadot-sdk#4410

3c273a7

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

`sc-chain-spec`: deprecated code removed #4410

`sc-chain-spec`: deprecated code removed #4410

michalkucharczyk commented May 8, 2024 •

edited

Loading

paritytech-cicd-pr commented May 27, 2024

	#[deprecated(
	note = "`from_genesis` is planned to be removed in May 2024. Use `builder()` instead."
	)]
	// deprecated note: Genesis<G>::Runtime + GenesisSource::Factory shall also be removed
	pub fn from_genesis<F: Fn() -> G + 'static + Send + Sync>(

sc-chain-spec: deprecated code removed #4410

sc-chain-spec: deprecated code removed #4410

Conversation

michalkucharczyk commented May 8, 2024 • edited Loading

paritytech-cicd-pr commented May 27, 2024

`sc-chain-spec`: deprecated code removed #4410

`sc-chain-spec`: deprecated code removed #4410

michalkucharczyk commented May 8, 2024 •

edited

Loading