[pallet-balances] `burn_allow_death` extrinsic #3964

Dinonard · 2024-04-03T11:40:19Z

Adds an additional extrinsic call to the pallet-balances to burn tokens.
Depending on the keep_alive flag, the call might or might not reap the account.

Required modification of the fungible's Mutate trait, burn_from function to allow the Preservation argument.

TODO

run benchmarks & update weights
make sure prdoc is required & properly formatted

Related issue: #3943

ggwpez · 2024-04-03T11:50:40Z

substrate/frame/balances/src/lib.rs

+		#[pallet::weight(T::WeightInfo::burn_allow_death())]
+		pub fn burn_allow_death(
+			origin: OriginFor<T>,
+			#[pallet::compact] value: T::Balance,


An additional call is overkill, but a keep_alive: bool similar to thetransfer_all would be fine i think.

I don't mind doing that, but will need to change this function signature:
https://github.com/paritytech/polkadot-sdk/blob/master/substrate/frame/support/src/traits/tokens/fungible/regular.rs#L260

It might end being a slightly lager change, hope that's ok.

Updated per request.

Will need help/suggestion with the remaining TODOs in the PR summary:

running benchmarks & updating weights (I cannot trigger the job)

check whether prdoc is ok

I know you said in another PR that current review process isn't sustainable (I assume due to human resources), but is there someone else we can ask to take a look at the PR?

@ggwpez sorry for the tag but could you please give a timeline when this can be checked out? Can we get someone else to review it?

Yea, it is best to ask in chat for review. We have the open #fellowship-open-channel:parity.io channel for that. I invited you.
Otherwise it can get lost or not have any priority...

Thanks a lot!

substrate/frame/support/src/traits/tokens/fungible/regular.rs

substrate/frame/balances/src/benchmarking.rs

substrate/frame/balances/src/lib.rs

cumulus/parachains/runtimes/assets/asset-hub-rococo/src/weights/pallet_balances.rs

ggwpez · 2024-04-30T11:05:13Z

bot bench-all pallet --pallet=pallet_balances

command-bot · 2024-04-30T11:05:17Z

@ggwpez https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/6092354 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/bench-all/bench-all.sh" --pallet=pallet_balances. Check out https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 4-02c5a23e-ef01-4cbd-aba7-be284195e69c to cancel this command or bot cancel to cancel all commands in this pull request.

command-bot · 2024-04-30T11:43:54Z

@ggwpez Command "$PIPELINE_SCRIPTS_DIR/commands/bench-all/bench-all.sh" --pallet=pallet_balances has finished. Result: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/6092354 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/6092354/artifacts/download.

…s/pallet_balances.rs Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

…trinsics' into dinonard/pallet-balances-burn-extrinsics

mordamax · 2024-05-08T06:24:40Z

that issue is known, we have it to fix in our backlog,
lets try ) im not sure either

bot bench polkadot-pallet --pallet=pallet_balances --runtime=rococo-dev

command-bot · 2024-05-08T06:24:43Z

@mordamax option '--runtime ' argument 'rococo-dev' is invalid. Allowed choices are rococo, westend.

mordamax · 2024-05-08T06:24:56Z

bot bench polkadot-pallet --pallet=pallet_balances --runtime=rococo

command-bot · 2024-05-08T06:25:01Z

@mordamax https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/6156561 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" --subcommand=pallet --runtime=rococo --target_dir=polkadot --pallet=pallet_balances. Check out https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 1-c26120b1-4f7e-40f2-9c19-05d76c505cc4 to cancel this command or bot cancel to cancel all commands in this pull request.

…=rococo --target_dir=polkadot --pallet=pallet_balances

command-bot · 2024-05-08T07:06:06Z

@mordamax Command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" --subcommand=pallet --runtime=rococo --target_dir=polkadot --pallet=pallet_balances has finished. Result: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/6156561 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/6156561/artifacts/download.

mordamax · 2024-05-08T07:07:39Z

@Dinonard looks good now. I will need to make sure those ones are part of bench-all pallet 👍

Dinonard · 2024-05-08T08:07:25Z

Thank you all for the support!

Adds an additional extrinsic call to the `pallet-balances` to _burn_ tokens. Depending on the `keep_alive` flag, the call might or might not reap the account. Required modification of the _fungible's_ `Mutate` trait, `burn_from` function to allow the `Preservation` argument. **TODO** - [x] run benchmarks & update weights - [x] make sure prdoc is required & properly formatted Related issue: #3943 --------- Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> Co-authored-by: command-bot <>

Adds an additional extrinsic call to the `pallet-balances` to _burn_ tokens. Depending on the `keep_alive` flag, the call might or might not reap the account. Required modification of the _fungible's_ `Mutate` trait, `burn_from` function to allow the `Preservation` argument. **TODO** - [x] run benchmarks & update weights - [x] make sure prdoc is required & properly formatted Related issue: paritytech#3943 --------- Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> Co-authored-by: command-bot <>

- Upgrade Polkadot-sdk 1.10.0 to 1.13.0 - Update weights to reflect the new version.1.13.0 Notable Changes: Polkadot-sdk 1.12.0 - [Improve MockValidationDataInherentDataProvider to support async backing](paritytech/polkadot-sdk#4442) - [Balances-Pallet add burn_allow_death extrinsic](paritytech/polkadot-sdk#3964) - [Add Async Backing to Parachain Template](paritytech/polkadot-sdk#4295) Polkadot-sdk 1.13.0 - [DeprecatedRuntimeGenesisConfig generic type parameter in GenericChainSpec struct](paritytech/polkadot-sdk#4410) - [Move the `para_id` from `MockXcmConfig` to `MockValidationDataInherentDataProvider` to make it more prominent](paritytech/polkadot-sdk#4555) - [Remove parameterized-consensus-hook feature](paritytech/polkadot-sdk#4380) For more details, please refer to: - [Polkadot-sdk release 1.12.0](https://github.com/paritytech/polkadot-sdk/releases/polkadot-v1.12.0) - [Polkadot-sdk release 1.13.0](https://github.com/paritytech/polkadot-sdk/releases/polkadot-v1.13.0) - [Async Backing](https://wiki.polkadot.network/docs/maintain-guides-async-backing) issue-2025 issue-1983

- Upgrade Polkadot-sdk 1.10.0 to 1.13.0 - Update weights to reflect the new version.1.13.0 Notable Changes: Polkadot-sdk 1.12.0 - [Improve MockValidationDataInherentDataProvider to support async backing](paritytech/polkadot-sdk#4442) - [Balances-Pallet add burn_allow_death extrinsic](paritytech/polkadot-sdk#3964) - [Add Async Backing to Parachain Template](paritytech/polkadot-sdk#4295) Polkadot-sdk 1.13.0 - [DeprecatedRuntimeGenesisConfig generic type parameter in GenericChainSpec struct](paritytech/polkadot-sdk#4410) - [Move the `para_id` from `MockXcmConfig` to `MockValidationDataInherentDataProvider` to make it more prominent](paritytech/polkadot-sdk#4555) - [Remove parameterized-consensus-hook feature](paritytech/polkadot-sdk#4380) For more details, please refer to: - [Polkadot-sdk release 1.12.0](https://github.com/paritytech/polkadot-sdk/releases/polkadot-v1.12.0) - [Polkadot-sdk release 1.13.0](https://github.com/paritytech/polkadot-sdk/releases/polkadot-v1.13.0) - [Async Backing](https://wiki.polkadot.network/docs/maintain-guides-async-backing) #2025 #1983

Init commit

d1fadb2

Dinonard mentioned this pull request Apr 3, 2024

[pallet-balances] burn extrinsic #3943

Closed

2 tasks

Dinonard requested a review from a team as a code owner April 3, 2024 11:41

Newline

e9c5ee5

ggwpez reviewed Apr 3, 2024

View reviewed changes

Modify interface

cc8641d

Dinonard requested a review from a team as a code owner April 3, 2024 14:28

paritytech-review-bot bot requested a review from a team April 3, 2024 14:29

Dinonard and others added 7 commits April 3, 2024 16:31

Polish

fbfcb62

Sort out missing weight functions

f1db75e

CI fixes

0094a2c

More fixes

b8f4f48

Fix prdoc

d9493fe

Merge branch 'master' into dinonard/pallet-balances-burn-extrinsics

2c7c067

Merge branch 'master' into dinonard/pallet-balances-burn-extrinsics

58268e4

ggwpez requested review from a team and ggwpez and removed request for a team April 30, 2024 10:36

ggwpez approved these changes Apr 30, 2024

View reviewed changes

ggwpez added the T1-FRAME This PR/Issue is related to core FRAME, the framework. label Apr 30, 2024

ggwpez reviewed Apr 30, 2024

View reviewed changes

cumulus/parachains/runtimes/assets/asset-hub-rococo/src/weights/pallet_balances.rs Outdated Show resolved Hide resolved

Dinonard and others added 6 commits April 30, 2024 14:11

Update cumulus/parachains/runtimes/assets/asset-hub-rococo/src/weight…

56d3379

…s/pallet_balances.rs Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

Update substrate/frame/balances/src/benchmarking.rs

45d191f

Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

Review comments

d8ade46

Merge remote-tracking branch 'origin/dinonard/pallet-balances-burn-ex…

41d70ef

…trinsics' into dinonard/pallet-balances-burn-extrinsics

Formatting

293ee0f

Merge branch 'master' into dinonard/pallet-balances-burn-extrinsics

79db74f

".git/.scripts/commands/bench/bench.sh" --subcommand=pallet --runtime…

04f75af

…=rococo --target_dir=polkadot --pallet=pallet_balances

liamaharon added this pull request to the merge queue May 8, 2024

Merged via the queue into paritytech:master with commit c3e57c1 May 8, 2024
146 of 147 checks passed

nazar-pc mentioned this pull request Jun 21, 2024

Update Substrate to 1.13.0 autonomys/subspace#2868

Merged

1 task

This was referenced Aug 16, 2024

Chore/upgrade polkadot v1.11.0 to v1.13.0 frequency-chain/frequency#2131

Closed

chore(upgrade): v1.11.0 to v1.13.0 frequency-chain/frequency#2132

Merged

This was referenced Aug 21, 2024

Update polkadot-sdk from v1.11.0 to stable2407 moondance-labs/tanssi#659

Open

Update polkadot-sdk from v1.11.0 to stable2407 moonbeam-foundation/moonbeam#2912

Closed

magecnion added a commit to freeverseio/laos that referenced this pull request Sep 12, 2024

paritytech/polkadot-sdk#3964

a37221d

This was referenced Oct 4, 2024

feat: ⏫ upgrade to Polkadot SDK v1.13.0 Moonsong-Labs/storage-hub#214

Closed

feat: ⏫ upgrade to Polkadot SDK v1.13.0 Moonsong-Labs/storage-hub#216

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[pallet-balances] `burn_allow_death` extrinsic #3964

[pallet-balances] `burn_allow_death` extrinsic #3964

Dinonard commented Apr 3, 2024 •

edited

Loading

ggwpez Apr 3, 2024

Dinonard Apr 3, 2024

Dinonard Apr 3, 2024

Dinonard Apr 12, 2024

Dinonard Apr 30, 2024

ggwpez Apr 30, 2024

Dinonard Apr 30, 2024

ggwpez commented Apr 30, 2024

command-bot bot commented Apr 30, 2024 •

edited

Loading

command-bot bot commented Apr 30, 2024

mordamax commented May 8, 2024

command-bot bot commented May 8, 2024

mordamax commented May 8, 2024

command-bot bot commented May 8, 2024 •

edited

Loading

command-bot bot commented May 8, 2024

mordamax commented May 8, 2024

Dinonard commented May 8, 2024

[pallet-balances] burn_allow_death extrinsic #3964

[pallet-balances] burn_allow_death extrinsic #3964

Conversation

Dinonard commented Apr 3, 2024 • edited Loading

ggwpez Apr 3, 2024

Choose a reason for hiding this comment

Dinonard Apr 3, 2024

Choose a reason for hiding this comment

Dinonard Apr 3, 2024

Choose a reason for hiding this comment

Dinonard Apr 12, 2024

Choose a reason for hiding this comment

Dinonard Apr 30, 2024

Choose a reason for hiding this comment

ggwpez Apr 30, 2024

Choose a reason for hiding this comment

Dinonard Apr 30, 2024

Choose a reason for hiding this comment

ggwpez commented Apr 30, 2024

command-bot bot commented Apr 30, 2024 • edited Loading

command-bot bot commented Apr 30, 2024

mordamax commented May 8, 2024

command-bot bot commented May 8, 2024

mordamax commented May 8, 2024

command-bot bot commented May 8, 2024 • edited Loading

command-bot bot commented May 8, 2024

mordamax commented May 8, 2024

Dinonard commented May 8, 2024

[pallet-balances] `burn_allow_death` extrinsic #3964

[pallet-balances] `burn_allow_death` extrinsic #3964

Dinonard commented Apr 3, 2024 •

edited

Loading

command-bot bot commented Apr 30, 2024 •

edited

Loading

command-bot bot commented May 8, 2024 •

edited

Loading