Added support for the custom time range in the stacked graph module #289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No need to %__cp %SOURCE1 as well. More over, using more than one source prevent a build from tarball using rpmbuild -tb ganglia-web-3.5.12.tar.gz for instance.
…in the same installation whatever the build is (manual, deb pkg or rpm pkg) - Use Makefile to make install for deb and rpm as well including config files. - Include specfile in the dist-gzip so a rpmbuild -tb (tarbuild) can be used - Added customization for rpmbuild using --with tags (see spec file for usage and more details). - Use adequate default values for rpm. The apache_user is not www-data. it's apache... - Use /etc/ganglia-webfrontend to store conf.php what ever the distro is. Make sure that a link is set to apache config dir using triggers or postinstall. - Use /etc/ganglia-webfrontend to store conf.php what ever the distro is. Use a generic conf.php in /usr/share/ganglia-webfrontend to load the file from /etc/ganglia-webfrontend. - Replaced vargwebstatedir with vargwebdir in conf_default.php.in and Makefile. - filters dir was not created under debian pkg or manual make install - Added possibility to have a httpd_group different from user. For instance you can choose to install files under apache.daemon identity. If not specified, a group with the same name as the user is used. - Added comment in the install section of the Makefile so it's clear. - Reworked dist-gzip target so version.php and spec file are generated while other .in files remain so they can be tuned by make or make install. - Make sure that sharedstatedir is not owned by rpm package (conflict on fc-18+), and updated %file section accordingly. - Removed the manual install and specific config files in debian packaging. Using standard make install DESTDIR=...
Get upstream changes.
… adapted specfile for this. Now Makefile has a rule that install files without setting ownership. this permit to build an rpm without being root. using --define magro for specfile tunning.
…ic graphs and reports. This is accomplished by specifying a tz query parameter to the ganaglia-web url. The timezone parameter takes the standard Linux form, e.g. tz=UTC, tz=America/New_York
Reworked the install and packaging so it results in the same installation whatever the build is (manual, deb pkg or rpm pkg)
Use jstz to determine browser timezone. In the future my hope is that we can do this with the moment library.
Some cleanup work in the area of date/time manipulation.
…ression to allow for hyphens.
…ly display the "now" button if the gweb timezone is set to "browser"
Added the capability to control the timezone used to display rrd metric graphs
Lock the cache file while writing to prevent partial reads
No need to fold since gmetad returns upper-case
…etric group graphs.
…graph.php. This enables Flot graphs to better control how data points are generated based on the width of the graph.
…n their width. A value of maxrows is passed in the querystring to graph.php.
…be in the local directory instead of the ganglia-web root directory.
Update ganglia master
Micro-optimize XML calls
… avoids interference with right mouse click to initiate alternate action such as getting image properties.
…enu lists. We exploit this functionality in the creation of aggregate graphs.
…f aggregate graphs. We use the multiselect version of the chosen widget to define an array of regular expressions each of which represents a set of metrics. The user can slect a single metric from the list, and/or provide a regular expression that is added to the list.
This reverts commit 86cc8c7.
Conflicts: ganglia.php graph_all_periods.php js/jquery-1.11.1.js lib/Cache/Driver_Json.php templates/default/header.tpl
|
We may just need to cherry pick these. There are way too many changes to make sure we don't break something inadvertently. |
|
Vladimir, cherry pick makes sense to me. I am going to review the commits in detail to get familiar with the differences. I can then make some suggestions on how to move forward. Sound ok? Peter To: ganglia/ganglia-web ganglia-web@noreply.github.com We may just need to cherry pick these. There are way too many changes to make sure we don't break something inadvertently.— |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Vladimir,
The files that were changed as part of this fix are cluster_view.php and stacked.php; however, I am having problems with my github repo. Could be due to the one pull request that never landed.
Peter