Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add project() to examples and remove hard-dependency on Ogre1 #345

Merged
merged 3 commits into from
Jan 7, 2022

Conversation

chapulina
Copy link
Contributor

@chapulina chapulina commented Jan 6, 2022

🦟 Bug fix

Summary

This is needed to silence CMake warnings like this:

33: CMake Warning (dev) in CMakeLists.txt:
33:   No project() command is present.  The top-level CMakeLists.txt file must
33:   contain a literal, direct call to the project() command.  Add a line of
33:   code such as
33: 
33:     project(ProjectName)
33: 
33:   near the top of the file, but after cmake_minimum_required().
33: 
33:   CMake is pretending there is a "project(Project)" command on the first
33:   line.
33: This warning is for project developers.  Use -Wno-dev to suppress it.

These warnings show up on Jenkins CI since we migrated from Bionic to Focal:

There's still another warning coming from ign-rendering, tracked here:

I added a workaround for the warning coming from ign-rendering until we fix it upstream

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸

Signed-off-by: Louise Poubel <louise@openrobotics.org>
@github-actions github-actions bot added the 🏰 citadel Ignition Citadel label Jan 6, 2022
@codecov
Copy link

codecov bot commented Jan 6, 2022

Codecov Report

Merging #345 (1f7164b) into ign-gui3 (803bf23) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           ign-gui3     #345   +/-   ##
=========================================
  Coverage     66.83%   66.83%           
=========================================
  Files            25       25           
  Lines          2964     2964           
=========================================
  Hits           1981     1981           
  Misses          983      983           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 803bf23...1f7164b. Read the comment docs.

@chapulina chapulina mentioned this pull request Jan 6, 2022
7 tasks
Signed-off-by: Louise Poubel <louise@openrobotics.org>
@chapulina chapulina changed the title Add project command to examples Add project command to examples and silence CMP0072 Jan 6, 2022
CMakeLists.txt Outdated Show resolved Hide resolved
Signed-off-by: Louise Poubel <louise@openrobotics.org>
@chapulina chapulina changed the title Add project command to examples and silence CMP0072 Add project command to examples and remove hard-dependency on Ogre1 Jan 6, 2022
@chapulina chapulina changed the title Add project command to examples and remove hard-dependency on Ogre1 Add project() to examples and remove hard-dependency on Ogre1 Jan 6, 2022
@chapulina
Copy link
Contributor Author

@osrf-jenkins run tests now that the buildfarm is back, please

@chapulina chapulina merged commit 9af7abf into ign-gui3 Jan 7, 2022
@chapulina chapulina deleted the chapulina/3/project branch January 7, 2022 01:23
@chapulina chapulina mentioned this pull request Jan 15, 2022
7 tasks
@osrf-triage
Copy link

This pull request has been mentioned on Gazebo Community. There might be relevant details there:

https://community.gazebosim.org/t/new-ignition-releases-2022-01-24-citadel-edifice-fortress/1241/1

@chapulina chapulina mentioned this pull request Jan 26, 2022
8 tasks
@osrf-triage
Copy link

This pull request has been mentioned on Gazebo Community. There might be relevant details there:

https://community.gazebosim.org/t/new-ignition-releases-2022-03-01-citadel-edifice-fortress/1313/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏰 citadel Ignition Citadel
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants