Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge ign-gui3 ➡️ ign-gui6 #409

Merged
merged 5 commits into from
Jun 1, 2022
Merged

Merge ign-gui3 ➡️ ign-gui6 #409

merged 5 commits into from
Jun 1, 2022

Conversation

chapulina
Copy link
Contributor

➡️ Forward port

Port ign-gui3 ➡️ ign-gui6

Branch comparision: ign-gui6...ign-gui3

Note to maintainers: Remember to Merge with commit (not squash-merge or rebase)

mabelzhang and others added 5 commits April 14, 2022 09:20
Signed-off-by: Mabel Zhang <mabel@openrobotics.org>
Signed-off-by: Mabel Zhang <mabel@openrobotics.org>
Signed-off-by: youhy <haoyuan2019@outlook.com>
* search bar text highlight

* add search bar shortcut "/"

Signed-off-by: youhy <haoyuan2019@outlook.com>

Co-authored-by: Jenn Nguyen <jenn@openrobotics.org>
Signed-off-by: Louise Poubel <louise@openrobotics.org>
@chapulina chapulina requested a review from jennuine as a code owner June 1, 2022 17:35
@github-actions github-actions bot added the 🏯 fortress Ignition Fortress label Jun 1, 2022
@codecov
Copy link

codecov bot commented Jun 1, 2022

Codecov Report

Merging #409 (5184313) into ign-gui6 (cce99b5) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##           ign-gui6     #409   +/-   ##
=========================================
  Coverage     30.54%   30.54%           
=========================================
  Files            41       41           
  Lines          1748     1748           
=========================================
  Hits            534      534           
  Misses         1214     1214           
Impacted Files Coverage Δ
include/ignition/gui/qrc_resources.cpp 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cce99b5...5184313. Read the comment docs.

@chapulina chapulina merged commit 2ba68b8 into ign-gui6 Jun 1, 2022
@chapulina chapulina deleted the chapulina/3_to_6 branch June 1, 2022 23:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏯 fortress Ignition Fortress
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants