Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated image data api #1563

Closed
wants to merge 4 commits into from

Conversation

luca-della-vedova
Copy link
Member

🦟 Bug fix

Summary

Same as the gz-gui PR. Migrate to new and safer Image API to avoid deprecation warnings.
Depends on gz-common PR.

In the process I actually found out the test that was using the deprecated API was actually doing nothing since it was comparing an image to itself. I fixed that so the test should now do what it's supposed to, with the consequence that it actually fails since I guess bytewise equality in a whole image is quite a strict constraint.
I'm not too familiar with that system so I'm not sure if the test can be fixed or should be disabled.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Luca Della Vedova <luca@openrobotics.org>
Signed-off-by: Luca Della Vedova <luca@openrobotics.org>
Signed-off-by: Luca Della Vedova <luca@openrobotics.org>
@luca-della-vedova
Copy link
Member Author

Replaced by #1570.
Will be effective as of next gazebo6->main forward port

@luca-della-vedova luca-della-vedova deleted the luca/remove_deprecated_api branch July 21, 2022 05:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌱 garden Ignition Garden needs upstream release Blocked by a release of an upstream library
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants