Auto-Instrumentation UI thread #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romtsn
commented
Nov 9, 2022
|
Since somebody asked if this info should go under the transaction or span, I believe the span makes more sense. |
brustolin
reviewed
Nov 10, 2022
brentc
reviewed
Nov 10, 2022
Co-authored-by: Dhiogo Brustolin <dhiogorb@gmail.com>
marandaneto
reviewed
Nov 23, 2022
4 tasks
markushi
added a commit
to getsentry/relay
that referenced
this pull request
Nov 28, 2022
In order to be consistent with getsentry/rfcs#36
wmak
added a commit
to getsentry/sentry
that referenced
this pull request
Nov 28, 2022
- Introduce the file io on main thread performance problem. Not hooking up the options or anything yet. Just want to get the main core of the code ready to go first - I think this won't actually create any of the file io perf problems yet since the option is only added to default.py with 0 - Depends on getsentry/rfcs#36
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add new
blocked_main_threadattribute to thedatakey-value map of theSpaninterface, indicating whether an auto-instrumented span has run its entire duration on the UI/Main thread.Rendered RFC