feat(protocol): Add app.in_foreground and thread.main flag #1578
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jjbayer
approved these changes
Nov 11, 2022
There was a problem hiding this comment.
This looks good to me. Let's not merge until getsentry/develop#728 is approved and we know the naming is final.
| @@ -36,6 +36,9 @@ pub struct AppContext { | |||
| /// Amount of memory used by the application in bytes. | |||
| pub app_memory: Annotated<u64>, | |||
|
|
|||
| /// A flag indicating whether the app is in foreground or not. An app is in foreground when it's visible to the user. | |||
| pub app_in_foreground: Annotated<bool>, | |||
There was a problem hiding this comment.
nit: I realize it's consistent with the other fields in this context, but the app_ prefix seems redundant to me.
There was a problem hiding this comment.
Yeah, I prefer to not have the app_ prefix as well. It might not be consistent within the app context, but looking at other contexts, it seems to be a better fit without the prefix. Let me remove the prefix 👍
There was a problem hiding this comment.
Update the changelog too to reflect this name change, please.
markushi
changed the title
In order to be consistent with getsentry/rfcs#36
markushi
changed the title
iker-barriocanal
approved these changes
Nov 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extends the protocol for contexts
in_foregroundfor the app context event payloadmainfor the thread contextThis is especially useful for analysing events for mobile platforms, as it provides extra context for e.g. crashes.
Related PRs:
develop: getsentry/develop#728
Related Issues:
getsentry/team-mobile#36
getsentry/rfcs#36