-
-
Notifications
You must be signed in to change notification settings - Fork 206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build with dotnet 8 sdk #2622
build with dotnet 8 sdk #2622
Conversation
|
CI fails due to: #2639 |
@@ -15,7 +15,7 @@ jobs: | |||
strategy: | |||
fail-fast: false | |||
matrix: | |||
os: [ubuntu-latest, windows-latest, macos-latest] | |||
os: [ubuntu-latest, windows-latest, macos-13] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pinned? Maybe put a comment in there explaining why so we know in the future whether this is still required or not.
|
||
- name: Update workloads | ||
shell: bash | ||
run: dotnet workload update |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we include an explanation for this? We just ran dotnet workload restore
right? Won't doing dotnet workload update
give us non-deterministic builds (we don't know what version of the workloads is going to be used for the build)?
After talking to @bitsandfoxes, I'm merging this to unblock other PRs and he'll follow up the review comments on |
Thanks! |
When trying to run tests on .NET 8 (#2617) it was clear that it was too much of a jump. Mobile support issues came up (Android and iOS, different issues). .NET 6 Android support was completely removed from .NET 8, so we need to chose between the two: dotnet/android#7900
This PR attempts to do the minimum changes required to build the repo with the .NET 8 SDK
This can be reverted possibly (as fixed in xamarin/xamarin-macios#18793)
sentry-dotnet/samples/Directory.Build.props
Line 38 in 2f11b30
Depends on:
Dotnet: Multi-target projects require all 'TargetFrameworks' installed in order to build dotnet/sdk#34496 (comment)Since there's no customer-facing change:
#skip-changelog