build with dotnet 8 sdk #2622
Merged
build with dotnet 8 sdk #2622
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bruno-garcia
requested review from
bitsandfoxes and
jamescrosswell
as code owners
|
This was referenced Sep 16, 2023
Closed
Merged
|
CI fails due to: #2639 |
Merged
Closed
vaind
approved these changes
Oct 16, 2023
| @@ -15,7 +15,7 @@ jobs: | |||
| strategy: | |||
| fail-fast: false | |||
| matrix: | |||
| os: [ubuntu-latest, windows-latest, macos-latest] | |||
| os: [ubuntu-latest, windows-latest, macos-13] | |||
There was a problem hiding this comment.
Pinned? Maybe put a comment in there explaining why so we know in the future whether this is still required or not.
|
|
||
| - name: Update workloads | ||
| shell: bash | ||
| run: dotnet workload update |
There was a problem hiding this comment.
Can we include an explanation for this? We just ran dotnet workload restore right? Won't doing dotnet workload update give us non-deterministic builds (we don't know what version of the workloads is going to be used for the build)?
|
After talking to @bitsandfoxes, I'm merging this to unblock other PRs and he'll follow up the review comments on |
|
Thanks! |
This was referenced Nov 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When trying to run tests on .NET 8 (#2617) it was clear that it was too much of a jump. Mobile support issues came up (Android and iOS, different issues). .NET 6 Android support was completely removed from .NET 8, so we need to chose between the two: dotnet/android#7900
This PR attempts to do the minimum changes required to build the repo with the .NET 8 SDK
This can be reverted possibly (as fixed in xamarin/xamarin-macios#18793)
sentry-dotnet/samples/Directory.Build.props
Line 38 in 2f11b30
Depends on:
Dotnet: Multi-target projects require all 'TargetFrameworks' installed in order to build dotnet/sdk#34496 (comment)Since there's no customer-facing change:
#skip-changelog